aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #30412 from ↵Richard Schneeman2017-08-253-3/+3
|\ | | | | | | | | yhirano55/add_nodoc_for_active_record_attribute_methods Add :nodoc: for ActiveRecord::AttributeMethods [ci skip]
| * Add :nodoc: for ActiveRecord::AttributeMethods [ci skip]Yoshiyuki Hirano2017-08-263-3/+3
|/
* Merge pull request #30404 from yhirano55/fix_link_in_doc_for_active_storageRobin Dupret2017-08-251-1/+1
|\ | | | | Fix link in doc for active storage [ci skip]
| * Fix link in doc for active storage [ci skip]Yoshiyuki Hirano2017-08-251-1/+1
| |
* | Should work inverse association when eager loadingRyuta Kamizono2017-08-254-15/+24
|/ | | | | | | This regression was caused by caa178c1. The block for `set_inverse_instance` should also be passed to join dependency. Fixes #30402.
* Merge pull request #30401 from yhirano55/add_paths_to_docs_for_active_storageRyuta Kamizono2017-08-251-0/+1
|\ | | | | Add paths to docs for Active Storage
| * Add paths to docs for Active StorageYoshiyuki Hirano2017-08-251-0/+1
|/
* Merge pull request #30398 from yahonda/seed52024Ryuta Kamizono2017-08-251-0/+4
|\ | | | | Address `test_after_save_callback_with_autosave` failure
| * Address `test_after_save_callback_with_autosave` failureYasuo Honda2017-08-241-0/+4
|/ | | | | | | when other `AutomaticInverseFindingTests` load `:comments` fixture but does not load `:posts`. Refer #30385 for similar issue
* Widen blob size columnGeorge Claghorn2017-08-241-1/+1
|
* Remove unused returning value `stream`Ryuta Kamizono2017-08-241-2/+0
|
* Merge pull request #30337 from kamipo/refactor_schema_dumperRyuta Kamizono2017-08-2415-56/+54
|\ | | | | Refactor `SchemaDumper` to make it possible to adapter specific customization
| * Refactor `SchemaDumper` to make it possible to adapter specific customizationRyuta Kamizono2017-08-2213-38/+51
| | | | | | | | | | | | | | Currently `SchemaDumper` is only customizable for column options. But 3rd party connection adapters (oracle-enhanced etc) need to customizable for table or index dumping also. To make it possible, I introduced adapter specific `SchemaDumper` classes for that.
| * Remove deprecated `#migration_keys`Ryuta Kamizono2017-08-225-19/+4
| |
* | Remove unnecessary fixture loadingRyuta Kamizono2017-08-241-5/+1
| |
* | Merge pull request #30394 from ydakuka/fixing-indentationRyuta Kamizono2017-08-245-11/+11
|\ \ | | | | | | Fix indentation [ci skip]
| * | Fix indentation [ci skip]Yauheni Dakuka2017-08-245-11/+11
| | |
* | | Merge pull request #30393 from ydakuka/patch-1Ryuta Kamizono2017-08-241-2/+2
|\ \ \ | | | | | | | | Update active_support_core_extensions.md [ci skip]
| * | | Update active_support_core_extensions.md [ci skip]Yauheni Dakuka2017-08-241-2/+2
|/ / /
* | | Merge pull request #30390 from bradleybuda/masterRyuta Kamizono2017-08-241-3/+4
|\ \ \ | | | | | | | | Update azure-core to 0.1.11 to fix rails-dev-box
| * | | Update azure-core to 0.1.11 to fix rails-dev-boxBradley Buda2017-08-231-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rails-dev-box was failing to install gems with a filesystem permission error. The issue was introduced when azure-core was bumped from 0.1.9 to 0.1.10 in d2f493c. azure-core has fixed the build problem [1] and released a new version, 0.1.11 with the fix. This change is just to run `bundle update azure-core` to pick up that fix. [1]: https://github.com/Azure/azure-ruby-asm-core/commit/536c3fc21cc48c292959cc10a9e5551e165aa0ed
* | | | Merge pull request #30376 from willnet/belongs-to-dependent-optionRyuta Kamizono2017-08-241-6/+5
|\ \ \ \ | |/ / / |/| | | [ci skip]Revert commits changing wrong place
| * | | [ci skip]Revert commits changing wrong placewillnet2017-08-241-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commits 5147ab121d628f29451c654a8c312d5a3f491ffb and 391043ab04007bfd4c4c4c8e8d3308c1eae60175. These commits looked to intend to change documents of has_many dependent options, but actually changed documents of belongs_to dependent options.
* | | | Merge pull request #30383 from y-yagi/followup_of_30213Eileen M. Uchitelle2017-08-232-7/+7
|\ \ \ \ | | | | | | | | | | Remove `alt` text from `image_tag` example [ci skip]
| * | | | Remove `alt` text from `image_tag` example [ci skip]yuuji.yaginuma2017-08-242-7/+7
|/ / / / | | | | | | | | | | | | Follow up of #30213
* | | | Merge pull request #30382 from yhirano55/fix_broken_link_for_java_xmlRafael França2017-08-231-1/+1
|\ \ \ \ | | | | | | | | | | Fix broken link for Java xml [ci skip]
| * | | | Fix broken link for Java xml [ci skip]Yoshiyuki Hirano2017-08-241-1/+1
| | | | |
* | | | | Merge pull request #30366 from MrOutis/action-cable-env-varRafael França2017-08-231-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Use REDIS_URL var for Action Cable config template
| * | | | | Use REDIS_URL var for Action Cable config templateMr. Outis2017-08-221-1/+1
| | | | | |
* | | | | | Make sure image_alt is deprecatedRafael Mendonça França2017-08-231-5/+15
| | | | | |
* | | | | | Remove alt generation from image_submit_tagRafael Mendonça França2017-08-232-7/+7
| | | | | |
* | | | | | Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-239-40/+42
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | Do not generate default alt text for images
| * | | | | Do not generate default alt text in image tagsCameron Cundiff2017-08-179-40/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | | | | | Merge pull request #30365 from yahonda/require_post_before_commentRyuta Kamizono2017-08-231-0/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | `counter_cache` requires association class before `attr_readonly`
| * | | | | | `counter_cache` requires association class before `attr_readonly`Yasuo Honda2017-08-231-0/+3
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | There were similar pull requests #26370 #27575 fixed by different way by moving `require "models/post"` before `require "models/comment"`
* | | | | | Merge pull request #30373 from ↵Ryuta Kamizono2017-08-2318-27/+27
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/use_https_instead_of_http_in_rails_guide Use https instead of http in guide [ci skip]
| * | | | | | Use https instead of http in guide [ci skip]Yoshiyuki Hirano2017-08-2318-27/+27
| | | | | | |
* | | | | | | Merge pull request #28991 from yahonda/load_authors_and_author_addressesRyuta Kamizono2017-08-234-4/+4
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Load :author_addresses fixture to keep data integrity with :authors
| * | | | | | Load both `:authors` and `:author_addresses` to keep data integrityYasuo Honda2017-08-224-4/+4
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `:authors` has a foreign key to `:author_addresses`. If only `:authors` fixture loaded into the database which supports foreign key and checks the existing data when enabling foreien keys like Oracle, it raises the following error `ORA-02298: cannot validate (ARUNIT.FK_RAILS_94423A17A3) - parent keys not found` It is because there is no parent data exists in `author_addresses` table. Here are how other database with foreign key support works: - MySQL does not check the existing data when enabling foreign key by `foreign_key_checks=1` https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_foreign_key_checks > Setting foreign_key_checks to 1 does not trigger a scan of the existing table data. Therefore, rows added to the table while foreign_key_checks=0 will not be verified for consistency. - PostgreSQL database itself has a feature to check existing data when enabling foreign key and discussed at #27636, which is reverted.
* | | | | | Merge pull request #30360 from gcourtemanche/transaction_timedoutRafael França2017-08-223-0/+14
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add TransactionTimeout for MySQL error code 1205
| * | | | | | Add TransactionTimeout for MySQL error code 1205Gabriel Courtemanche2017-08-223-0/+14
| | | | | | |
* | | | | | | Merge pull request #30371 from yhirano55/fix_spaces_in_the_comment_blockRichard Schneeman2017-08-221-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix spaces in the comment block [ci skip]
| * | | | | | | Fix spaces in the comment block [ci skip]Yoshiyuki Hirano2017-08-231-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #30369 from dustMason/security-guide-grammar-fixGeorge Claghorn2017-08-221-1/+1
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Grammar fix
| * | | | | | | Grammar fixJordan Sitkin2017-08-221-1/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Changed the phrase '... and many more high targets' to '... and many more high _profile_ targets'
* | | | | | | Merge pull request #30363 from ibrahimab/patch-1Ryuta Kamizono2017-08-231-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fixing nginx configuration added missing semicolon [ci skip]
| * | | | | | | Fixing nginx configuration added missing semicolonIbrahim2017-08-221-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #30336 from bogdanvlviv/use_version_5_2_for_activestorageRafael França2017-08-222-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Use 5.2 version of ActiveRecord::Migration for Active Storage
| * | | | | | | Use 5.2 version of ActiveRecord::Migration for Active Storagebogdanvlviv2017-08-222-2/+2
|/ / / / / / /
* | | | | | | Merge pull request #30356 from ↵Kasper Timm Hansen2017-08-222-2/+1
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | bogdanvlviv/remove-frozen_string_literal-from-blob-migration Remove frozen_string_literal comment from activestorage's migration
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-08 19:33:37 +0000