| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
this makes scope rollback much easier
|
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
just ask whether or not the route is defined
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
we can `super` in to the previous implementation.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
we already know what helpers are path helpers, so just iterate through
that list and define the helpers with warnings
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
this lets us avoid hard coding a regexp for separating path and url
helpers in the clear! method.
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Deprecate `*_path` methods in mailers
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
Paired @sgrif & @schneems
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
JackDanger/remove_redundant_self_in_class_method_calls
Remove redundant `self.` in class method calls
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
These are the only instances of this in the whole code base.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Prevent using String#scrub on Rubinius
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rubinius' has built-in support for String#scrub but it doesn't have yet
support for ASCII-incompatible chars so for now, we should rely on the
old implementation of #tidy_bytes.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing
changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d.
Closes #16343
|
|\ \ \ \
| | | | |
| | | | | |
remove unneeded test model for ActiveModel test cases.
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Add implicit receiver support to `Object#with_options`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove @state.parent assignment on commit
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This piece of code was introduced on
67d8bb963d5d51fc644d6b1ca20164efb4cee6d7 , which was calling
`committed?` in the `transaction_state` before calling the `committed!`
method. However on 7386ffc781fca07a0c656db49fdb54678caef809, the
`committed?` check was removed and replaced by a `finalized?`, which
only checks if the state is not nil. Thus we can remove that line.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
use helpers.include? so we don't get any false positives
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
we should not be accessing internals to figure out if a method is
defined.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
since helpers is a set, we can be confident about when to remove methods
from the module.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
after this, we can disconnect @module from the instance
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
we can cache the module on the stack, then reuse it
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
GET request should not write to database note added. [ci skip]
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add missing test case for Array#to_sentence, collect all test cases for Object#to_param at one place and avoid repitition
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Object#to_param at one place and avoid repitition
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Move array test files under array
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
This fixes the broken code block rendering and indents the examples
within the parameter list.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] fix doc typo for validates_uniqueness_of
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Give password_confirmation div the "field" class in the scaffold generator "_form" partial
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix json autoload
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a
delegation that is set up in `active_support/json/encoding`. We cannot simply
require that file in `core_ext/object/json` because it would cause a circular
dependency problem (see #12203 for background). We should instead rely on AS's
autoload to load that file for us on-demand.
To trigger autoload correctly, we need to reference the `AS::JSON::Encoding`
constant instead of using the delegated version.
Fixes #16131.
|
| |/ / / / / |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #16163
Adding attachments after a call to `mail` will result in invalid emails.
This is related to the fact, that `mail` is making the required preparations
before the email is ready to be sent. These change depending on your
added attachments.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Define Hash#to_query and set Hash#to_param as alias to it; with test cases
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Move object test files under object
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove blank lines at the start of the ActiveRecord files
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
we know the routes should not be "optimized" when mounting an
application
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
this caching doesn't increase performance, but does increase complexity.
remove it for now and find better ways to speed up this code.
|