| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
References https://github.com/rails/homepage/issues/46.
|
| |/ / / / /
|/| | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
add return values to example [ci skip]
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit b3c487515c11c367855eda7742bda4a3d680b740, reversing
changes made to 4b43651884309c0f5be4dbdd11ea4d16fb880c30.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Rename dependencies.rake to cache_digests.rake
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
As the tasks are related to cache_digests and
as they are already namespaced under cache_digests,
renaming to cache_digests.rake makes it to know
where to find these tasks.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove passing `with_dispatchers` to AppGenerator
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- While working on https://github.com/rails/rails/pull/22790 I found out
that we pass `with_dispatchers: true` but it's not used at all by Rails.
- We were passing `with_dispatchers: true` in few tests too but again
it's not used by Rails.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Job payload should be symmetric across JSON dump/load
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Placing non-native JSON data types, like symbols, in the hash to serialize means that the deserialize method will return something different from what was serialized, a common bug and source of frustration for devs.
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
use same name to type object
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
Follow up to #24079
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This method will only be added when used with Ruby 2.3.0 or greater.
This method has the same behavior as `Hash#dig`, except it will convert
hashes to `ActionController::Parameters`, similar to `#[]` and `#fetch`.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
AppGenerator: allow both 'rake' and 'rails'
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637
and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364
The idea is that if you type (for example) "rake db:migrate" in an AppGenerator,
then this should actually invoke `rake db:migrate` on the command line, whereas
if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Pass headers through to payload for logging.
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Make request headers available in the event payload so that it is available to attached ActionController::LogSubscribers.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove redundant regexp escapes in generators
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Execute default_scope defined by abstract class within the scope of subclass
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Friendly error message if missing `listen` development dependency
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Advertise the console web-console feature
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
In the latest version of Web Console, you can call `console` anywhere in
your application and get a console with that binding in it. I think this
is worth advertising, as it may be useful to do outside of controllers
and views.
[ci skip]
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Optimize url helper
|
| | |/ / / / / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
reduce string allocation.
- Use freezed empty string instead of create one every time we need to return it
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Fix the tests after #24104
|
| | |/ / / / / / /
| |/| | | | | | | |
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Drop the explicit version requirements for web-console
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
however, the explicit 2.x requirement of `~> '2.0'` will prevent people
from getting the fix with `bundle update` and they would have to
explicitly set the constraint to `~> '3.0'`.
For more information see: rails/web-console#178.
I propose we drop the explicit version constraints in the Gemfile. Web
Console has been relatively stable for the past couple of years, and I
don't anticipate any major alterations, like we saw between major
versions 1 and 2.
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
Remove extra 'the' and unwanted comma [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove outdated comment [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Currently column options handled by the type map in Rails 4.2.
|
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
related to #19324 and #18606
[skip ci]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
extract ActionDispatch::IntegrationTest::Behavior
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Similar to 176fbfd6, this makes it possible for other test
frameworks to hook into Rails integration test facilities.
|
| | | | | | | |
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fixes funny spelling in an AR test
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- marked_for_destroyal -> marked_for_destruction
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove incorrect Rack documentation example
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`Sprockets` does not respond to the call method, so I changed the
example to use a fake `MyRackApp`.
Closes #22579.
[ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fixed semantics of couple of tests in the configuration_test.rb [ci skip]
|
| | |_|/ / / /
| |/| | | | | |
|