| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix typo in PostresSQLAdapter's documentation [ci skip]
|
|/ |
|
| |
|
|
|
|
|
|
|
| |
The last supported plugin on the list was protected_attributes, which is
not going to be supported anymore on Rails 5.
[ci skip]
|
|
|
|
| |
Related to #10690.
|
|\
| |
| | |
Switching SecureTokens to Base58
|
| |
| |
| |
| |
| |
| | |
Update Secure Token Doc [ci skip]
remove require securerandom, core_ext/securerandom already do that ref 7e006057
|
|\ \
| | |
| | | |
Remove attributes_protected_by_default reference
|
| | |
| | |
| | |
| | | |
MassAssignmentSecurity was removed from ActiveModel f8c9a4d3e88181
|
| |/
|/| |
|
|/ |
|
|\
| |
| | |
Copy records to parent transaction should happen on TransactionManager
|
| |
| |
| |
| | |
It is up to the TransactionManager keep the state of current transaction, so after it commits it needs to copy any remaning record to the next current transaction
|
|\|
| |
| | |
Use keyword args on committed! and rolledback!
|
|/
|
|
| |
As discussed before, those methods should receive a keyword args instead of just parameters
|
|
|
|
|
|
|
|
|
|
|
| |
This is cropping up all over the place. After a brief dive, I'm really
not sure why we have `arel.bind_values` at all. A cursory grep didn't
reveal where they're actually being assigned (it's definitely in AR, not
in Arel). I'd like to dig further into it, as I'm fairly certain we
don't actually need it, we just need a way for the predicate builder to
communicate merged binds upstream.
Fixes #18414
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason this bug occured is that we never actually check to see if
this column has changed from it's default, since it was never assigned
and is not mutable.
It appears I was wrong in b301c40224c6d15b539dbcc7485adb44d810f88c, with
my statement of "there is no longer a case where a given value would
differ from the default, but would not already be marked as changed."
However, I chose not to revert the deletion of
`initialize_internals_callback` from that commit, as I think a solution
closer to where the problem lies is less likely to get erroneously
removed. I'm not super happy with this solution, but it mirrors what is
being done in `_update_record`, and a fix for one should work for the
other.
I toyed with the idea of changing the definition of `changed?` on the
type to `changed_in_place?`. If we type cast the raw value, it'll break
a test about updating not modifying the lock column if nothing else was
changed. We could have the definition check if `raw_old_value` is `nil`,
but this feels fragile and less intention revealing. It would, however,
have the benefit of cleaning up old data that incorrectly persisted as
`nil`.
Fixes #18422
|
|\
| |
| | |
Use parallel bundler install.
|
| |
| |
| |
| |
| | |
Travis recommends a default of 3.
See: http://docs.travis-ci.com/user/languages/ruby/#Default-Test-Script
|
|\ \
| | |
| | | |
Correctly count methods when using declarative `#test` in minitest
|
| | |
| | |
| | |
| | |
| | | |
- test/functional
- test/unit
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Default headers, removed in controller actions, will not be reapplied to the test response
|
|/ / /
| | |
| | |
| | | |
test response.
|
|\ \ \
| | | |
| | | | |
Add _mailer suffix to i18n path
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For mailers created via generators
Follow up to #18074
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
yoshiokatsuneo/active_record_connection_pool_error_disconnect
ActiveRecord: release connection on reconnect failure.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When trying to checkout connection from connection pool,
checkout()(and checkout_and_verify) verify whether the connection
is active or not.
And, if the connection is not active, connection adapters try to
reconnect to server. And, if database is down at this moment,
reconnect fails and exception is raised.
(Ex: Mysql2::Error: Can't connect to local MySQL server through socket xxx)
But, ConnectionPool does not catch the exception, but leaks current
disconnected connection to @connection.
So, if database's temporary down happens several times and exceeds
the number of connection pool(5 by default), activerecord will be
no more available, even if database server is already recovered.
This patch fix it by catching exception and releasing connection.
|
|\ \ \
| | | |
| | | | |
remove *_filter
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add test case and documentation for skip_before_filter.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new test/docs further explain the conflicts that can happen when
mixing `:if`/`:unless` options with `:only`/`:except` options in
`skip_before_action`.
The gist is that "positive" filters always have priority over negative
ones.
The previous commit already showed that `:only` has priority over `:if`.
This commit shows that `:if` has priority over `:except`.
For instance, the following snippets are equivalent:
```ruby
skip_before_action :some_callback, if: -> { condition }, except: action
```
```ruby
skip_before_action :some_callback, if: -> { condition }
```
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Test case for using skip_before_filter with the options :only and :if
both present. In this case, the :if option will be ignored and :only
will be executed.
Closes #14549 (the commit was cherry-picked from there).
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add prepend option to protect_from_forgery.
|
|/ / / / |
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove ActionController::HideActions (closes #18336)
|
| | | | |
|
| |/ /
|/| |
| | |
| | | |
https://github.com/rails/rails/commit/5937bd02dee112646469848d7fe8a8bfcef5b4c1#commitcomment-9205786
|
|\ \ \
| | | |
| | | | |
Enqueued email assertions
|
| | | | |
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add :only option to assert_enqueued_jobs
|
|/ / /
| | |
| | |
| | | |
With the option, assert_enqueued_jobs will check the number of times a specific kind of job is enqueued.
|
|\ \ \
| | | |
| | | | |
Fix potenital infinite recursion in changed_for_autosave?
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When associations checked for autosave have a cycle, and
none of them is dirty, then changed_for_autosave? will be an
infinite loop. We now remember if we're in the check and
will short circuit the recursion.
|
|\ \ \ \
| |_|_|/
|/| | | |
Fix count on a separate connection
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previosly count and other AR calculations would convert
column_name_for_operation to sql on a default Arel::Table.engine
(AR::Base) connection. That could lead to trouble if current
model has a connection to a different adapter or Base connection
is inaccessible.
|