| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
fix QueryCache nil dup
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
make sql statements frozen
dup if arel is not our string
expect runtime error
dont wrap runtime error in invalid
log errors will now be treated as runtime errors
update changelog
|
|\
| |
| | |
Avoid invalid attribute on local forms generated by `form_with`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes that the following ERB template would result in invalid HTML
output:
<%= form_with model: Post.new, local: true do |form| %>
<% end %>
Specifically, the resulting form tag would have a spurious `remote`
attribute:
<form remote="false" ...>
|
|/ |
|
|\
| |
| | |
Mention JS Runtime dependency in dev dependencies guide [ci skip].
|
| | |
|
|\ \
| | |
| | | |
Fix constantize edge case involving prepend, autoloading and name conflicts
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the following situation:
```ruby
class Bar
end
module Baz
end
class Foo
prepend Baz
end
class Foo::Bar
end
```
Running `Inflector.constantize('Foo::Bar')` would blow up with a NameError.
What is happening is that `constatize` was written before the introduction
of prepend, and wrongly assume that `klass.ancestors.first == klass`.
So it uses `klass.ancestors.inject` without arguments, as a result
a prepended module is used in place of the actual class.
|
|\ \
| |/
|/| |
Remove unused method `namespaced_file_path`
|
|/
|
|
|
|
|
|
| |
```
$ git grep namespaced_file_path
railties/lib/rails/generators/named_base.rb: def namespaced_file_path
railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/")
```
|
|\
| |
| | |
use appropriate type for `rc` option
|
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the following warning.
```
Expected boolean default value for '--rc'; got "~/.railsrc" (string)
```
|
| | |
|
|\ \
| |/
|/| |
fix new warning in ruby 2.4
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following warning.
```
test/caching_test.rb:986: warning: parentheses after method name is interpreted as
test/caching_test.rb:986: warning: an argument list, not a decomposed argument
test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as
test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument
```
Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24
|
|
|
|
|
|
|
|
|
|
|
| |
Continuing 67f81cc where we decided not to output ids
by default in the new form helpers.
Went with @dhh's suggestion of just requiring ids on
fields being labelled:
https://github.com/rails/rails/issues/25197#issuecomment-231797117
Seems okay enough.
|
|
|
|
| |
[ci skip]
|
|\
| |
| | |
Schema cache in YAML
|
| | |
|
|\ \
| | |
| | | |
change return value of `duplicable?` with Ruby 2.4+
|
|/ /
| |
| |
| |
| |
| |
| | |
`NilClass`, `FalseClass`, `TrueClass`, `Symbol` and `Numeric` can dup
with Ruby 2.4+.
Ref: https://bugs.ruby-lang.org/issues/12979
|
| |
| |
| |
| |
| |
| |
| | |
Unintentionally makes `--webpack` implied on `rails new apper`.
If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`,
so we can check for that instead of `"base"`.
|
| |
| |
| |
| | |
setup
|
| | |
|
| |
| |
| |
| | |
https://bugs.ruby-lang.org/issues/12979
|
| |
| |
| |
| |
| | |
BigDecimal('an invalid string') has changed its behavior to raise an ArgumentError since 1.3.0
https://bugs.ruby-lang.org/issues/10286
|
| | |
|
| |
| |
| |
| | |
namespace_ladder can be nil here
|
| |
| |
| |
| | |
Don't expect the caller of this method to know that the return value has an extra " "
|
|\ \
| | |
| | | |
Add a changelog entry for #26687 [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Remove duplicated line
|
|/ / |
|
|\ \
| | |
| | | |
Add a changelog entry for #25227 [ci skip]
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Fix CI failure caused by #25227 and #25280 were merged at the same time
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
kamipo/prevent_range_error_for_belongs_to_associations
Prevent `RangeError` for `belongs_to` associations
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently to access `belongs_to` associations raises a `RangeError` if
foreign key attribute has out of range value.
It should return a nil value rather than raising a `RangeError`.
Fixes #20140.
|
|\ \ \
| | | |
| | | | |
Translate numeric value out of range to the specific exception
|
| | | |
| | | |
| | | |
| | | | |
Raise `ActiveRecord::RangeError` when values that executed are out of range.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/run_webpack_command_only_when_webpack_option_is_specified
run `webpack` command only when webpack option is specified
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes the following error when executing rails new command.
```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```
Follow up to #27288
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add a changelog entry for #25451 [ci skip]
|
| | | | | |
|