aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Applied changes to stylesheet_link_tag from javascript_include_tag which ↵Josh Kalderimis2011-02-133-14/+38
| | | | corrects issues with ordering and duplicates.
* This corrects two issues with javascript_include_tag, the order at which ↵Josh Kalderimis2011-02-132-5/+47
| | | | | | | | they are expanded, and removing duplicates. When individual js assets are specified, they will override the order of the same asset specified in an expansion. [#5938 state:resolved]
* Remove duplicated action pack tests added to fix issue with fields_for, ↵Carlos Antonio da Silva2011-02-121-42/+0
| | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add block support to button_tag helperTom Stuart2011-02-122-4/+18
| | | | | | | | | | | | | | | | | | | As per the HTML 4.01 spec: Buttons created with the BUTTON element function just like buttons created with the INPUT element, but they offer richer rendering possibilities: the BUTTON element may have content. For example, a BUTTON element that contains an image functions like and may resemble an INPUT element whose type is set to "image", but the BUTTON element type allows content. Since rich content is the main purpose of the <button> element, it makes sense for the button_tag helper to accept a block. http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#the-button-element Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
* Make type="submit" the default for button_tag helperTom Stuart2011-02-122-7/+12
| | | | | | | | | | | | "submit" is the default value of the <button> element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag is going to have a default, type="submit" is a more sensible choice than type="button". http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
* Updated the json date regex to recognize xmlschema formatted date times ↵Josh Kalderimis2011-02-122-1/+5
| | | | | | during json decoding. [#3031 state:resolved] Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
* key habtm fixtures off table nameAaron Patterson2011-02-111-5/+5
|
* Fixture class no longer needs a reference to the database connectionAaron Patterson2011-02-111-16/+4
|
* convert fixtures to a list of hashes to insertAaron Patterson2011-02-111-2/+6
|
* fixture should quack like a hashAaron Patterson2011-02-111-1/+9
|
* Fixtures class constantizes this value, so no need to do it twiceAaron Patterson2011-02-111-3/+3
|
* database quoting should take care of this, no need to gsubAaron Patterson2011-02-111-1/+1
|
* calculate model class on constructionAaron Patterson2011-02-111-16/+11
|
* clear cache for all connections when resettingAaron Patterson2011-02-111-4/+3
|
* avoid side effects from method calls, localize ivar assignmentAaron Patterson2011-02-111-3/+4
|
* create fixtures always returns a list, so build a hash from the listAaron Patterson2011-02-111-10/+2
|
* create_fixtures() should always return a listAaron Patterson2011-02-112-9/+9
|
* fixing variable namesAaron Patterson2011-02-111-4/+10
|
* use hash defaults to dry up ||= callsAaron Patterson2011-02-111-27/+22
|
* refactor fixtures to do less work in the constructorAaron Patterson2011-02-112-11/+24
|
* favor composition over inheritence. use AS::OrderedHash rather than omapAaron Patterson2011-02-112-20/+25
|
* Fixes an issue when decoding a json string which looks like a date but is ↵Josh Kalderimis2011-02-114-3/+23
| | | | | | invalid. This DateTime parse error is now caught and the original string is instead passed back [#6286 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add missing deprecation requireCarlos Antonio da Silva2011-02-111-0/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove misleading reference to polymorphic_url.José Valim2011-02-111-2/+0
|
* fixing tests on 1.8, using a list of lists because order is importantAaron Patterson2011-02-102-2/+4
|
* simplify bind parameter loggingAaron Patterson2011-02-102-4/+2
|
* bind parameters are logged to debug logAaron Patterson2011-02-102-6/+48
|
* test cases for bind parameter loggingAaron Patterson2011-02-101-0/+56
|
* Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵Josh Kalderimis2011-02-107-116/+70
| | | | | | the same same. This also changes how safe_join works, if items or the separator are not html_safe they are html_escape'd, a html_safe string is always returned. Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Removed Array#safe_join in AS core_ext and moved it to a view helper ↵José Valim2011-02-107-97/+116
| | | | | | | | with the same same." Applied the wrong version. This reverts commit 98c0c5db50a7679b3d58769ac22cb0a27a62c930.
* Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵Josh Kalderimis2011-02-107-116/+97
| | | | the same same.
* Corrected the html_safe implementation for Array. Moved the html safe ↵Josh Kalderimis2011-02-102-20/+35
| | | | version of join to its own method (safe_join) as not to degrade the performance of join for unrelated html_safe use. [#6298 state:resolved]
* Initial html_safe implemention for ArrayPaul Hieromnimon2011-02-102-0/+60
|
* log method takes an option list of bind valuesAaron Patterson2011-02-094-8/+10
|
* fanout unsubscribe only accepted one argument, so taking *args here is ↵Aaron Patterson2011-02-091-2/+2
| | | | probably bad
* just use an attr_accessor so we do not pay ||= on every notification callAaron Patterson2011-02-092-7/+10
|
* fixing indentationAaron Patterson2011-02-091-4/+4
|
* speed up notification publishing by writing the delegate methodAaron Patterson2011-02-091-1/+4
|
* rawr, mysql, mysql2, why do you hate me. :'(Aaron Patterson2011-02-091-2/+4
|
* Fixed a bug where ActiveResource::HttpMock would not replace an existing ↵Josh Bassett2011-02-092-5/+39
| | | | | | response when passing a block to the respond_to method. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Override attributes_protected_by_default when has_secure_password is called.Tsutomu Kuroda2011-02-094-2/+38
| | | | | | | attr_protected should not be called, because it nullifies the mass assignment protection that has been set by attr_accessible. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* removed some duplication from LH issue 5505 regarding AR touch and ↵Josh Kalderimis2011-02-092-9/+11
| | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com>
* The optimistic lock column should be increased when calling touchFranck Verrot2011-02-093-0/+16
| | | | Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com>
* use parenthesis so limit works on all dbsAaron Patterson2011-02-091-6/+4
|
* now that the API guidelines are a guide, it is enough to assert that the ↵Xavier Noria2011-02-091-1/+1
| | | | names of Rails components have a space, no need to say it was checked with David in the past
* removing text-format in favor of a more simple solutionAaron Patterson2011-02-093-13/+19
|
* bugfix for serialized_attributes to be class specificRaimonds Simanovskis2011-02-092-1/+8
| | | | previously serialized_attributes were kept as class attribute of ActiveRecord::Base - if some attribute was defined as serialized in one subclass then it was serialized in all other subclasses as well (if it had the same name)
* implementing include? on AM::ErrorsAaron Patterson2011-02-092-0/+11
|
* text-format requires text-hyphen, which needs ruby 1.8Piotr Sarnacki2011-02-091-3/+1
|
* we do not need message to be an arrayAaron Patterson2011-02-091-9/+8
|