| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
| |
Those two files are required by active_support/rails.rb
loaded in active_model.rb
It is common to require common dependencies on the root
files to avoid boilerplate in each file.
This reverts commit 763635e30f17800ebc0a8ae98d780edc8ebfb4e5, reversing
changes made to 4f46ef36aaef217834f3f96d3689d32f6a6761ea.
|
| |
|
|
| |
Closes #11026
|
| |\
| |
| | |
Add explicit dependencies of ActiveSupport to enable independent usage of ActiveModel::Name
|
| | |
| |
| |
| |
| |
| |
| |
| | |
There are two missing ActiveSupport dependencies to use ActiveModel::Name class or ActiveModel::Naming module independently.
Missing dependencies for Module#delegate defined in `active_support/core_ext/module/delegation`, used at [L148](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L148)
Missing dependencies for Object#blank? defined in `active_support/core_ext/object/blank`, used at [L131](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L131)
|
| |\ \
| | |
| | | |
flatten merged join_values before building the joins
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
fixes #10669
While joining_values special treatment is given to string values.
By flattening the array it ensures that string values are detected
as strings and not arrays.
|
| |\ \
| | |
| | | |
Remove code related to the rails test command
|
| | | |
| | |
| | |
| | |
| | | |
Remove the mention about this command in the rails command's help
message and remove the "t" alias related to it.
|
| |\ \ \
| |/ /
|/| | |
do not load all child records for inverse case
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
currently `post.comments.find(Comment.first.id)` would load all
comments for the given post to set the inverse association.
This has a huge performance penalty. Because if post has 100k
records and all these 100k records would be loaded in memory
even though the comment id was supplied.
Fix is to use in-memory records only if loaded? is true. Otherwise
load the records using full sql.
Fixes #10509
|
| |\ \
| | |
| | | |
fix bad test by making number that fits for integer
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
PR https://github.com/rails/rails/pull/10566 had to be reverted
because after applying the fix test
"test_raise_record_not_found_error_when_invalid_ids_are_passed"
started failing.
In this test invalid_id is being assigned a really large number
which was causing following failure when PR #10566 was applied.
```
RangeError: bignum too big to convert into `long long'
SELECT `interests`.* FROM `interests`
WHERE `interests`.`man_id` = ? AND `interests`.`id` = ?
LIMIT 1 [["man_id", 970345987], ["id", 2394823094892348920348523452345]]
```
This test is not failing in master because when test code
`man.interests.find(invalid_id)` is executed then interests
are fully loaded in memory and no database query is executed.
After PR #10566 was merged then test code
`man.interests.find(invalid_id)` started executing sql query
and hence the error.
In case someone is wondering why the second part of query is not
failing, then that's because the actual query does not require
any variable substituation where the number is large. In that
case the sql generate is following.
```
SELECT `interests`.* FROM `interests`
WHERE `interests`.`man_id` = ? AND `interests`.`id`
IN (8432342, 2390102913, 2453245234523452) [["man_id", 970345987]]
```
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
jetthoughts/10428_bug_with_config_assets_precompile
#10428: Added tests for config.assets.precompile
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Tests for bug in sprocket-rails:
do not use value of configuration options
which changed after environment loaded
|
| |\ \ \ \
| | | | |
| | | | | |
Fix documents for create_join_table [ci skip]
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Saying gemcutter => rubygems [ci skip]
|
| | | |_|/ /
| |/| | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
fix the path of action view from actionpack/lib/action_view => actionvie...
|
| |/ / / /
| | | |
| | | |
| | | | |
actionview/lib/action_view
|
| |\ \ \ \
| |/ / /
|/| | | |
Backport #11033 to master
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
Since docrails as moved from lifo/docrails to rails/docrails we have
to ask for commit rights or submit patches directly to the rails
repository
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously when app was mounted as following:
class Foo
def call(env)
[200, {}, [env['PATH_INFO']]]
end
end
RackMountRailsBug::Application.routes.draw do
mount RackTest.new => "/foo"
end
trailing slash was removed from PATH_INFO. For example requesting
GET /foo/bar/
on routes defined above would result in a response containing "/foo/bar"
instead of "/foo/bar/".
This commit fixes the issue.
(closes #3215)
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
senny/10936_inspect_does_not_crash_without_connection
`inspect` for AR model classes does not initiate a new connection.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
mjtko/fix/backtrace-silencer-noise-with-multiple-silencers
Fix BacktraceSilencer#noise when multiple silencers are configured
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous implementation of BacktraceSilencer#noise did not
work correctly if more than one silencer was configured --
specifically, it would only return noise which was matched by all
silencers.
The new implementation is such that anything that has been matched by
silencers is removed from the backtrace using Array#- (array
difference), ie. we now return all elements within a backtrace that
have been matched by any silencer (and are thus removed by #silence).
Fixes #11030.
|
| |\ \ \ \
| |/ / /
|/| | | |
Extract ActionView to separate directory
|
| | | | |
| | | |
| | | |
| | | | |
Now if somebody by mistake will remove malformed files test will raise error.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
They were moved to actionview/ and are not used in actionpack
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
ActionView still relies on ActionPack in some of the tests.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |/ / /
| | |
| | |
| | |
| | | |
This commit creates structure for Action View gem and is first of a
series of commits extracting Action View from Action Pack.
|
| |\ \ \
| | | |
| | | | |
ActiveModel::Model inclusion chain backward compatibility
|
