aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | :scissors:Rafael França2017-04-071-1/+1
| | | | | |
* | | | | | Fix Guides to include #23138 [ci skip]claudiob2017-04-071-8/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A long-standing bug has been fixed in Rails 5.1 by @pixeltrix See https://github.com/rails/rails/blame/5-1-stable/actionpack/CHANGELOG.md#L52-L64 This PR updates the guides accordingly. Before: <img width="799" alt="before" src="https://cloud.githubusercontent.com/assets/10076/24809105/4ec7066c-1b73-11e7-98c6-c709c3465306.png"> After: <img width="799" alt="after" src="https://cloud.githubusercontent.com/assets/10076/24809109/50b21188-1b73-11e7-8a1a-32c3d0ed512a.png">
* | | | | Merge pull request #28670 from aledalgrande/activerecord-docs-fixRafael França2017-04-071-1/+5
|\ \ \ \ \ | | | | | | | | | | | | Fix edge guides for Active Record callbacks
| * | | | | Fix edge guides for Active Record callbacksAlessandro Dal Grande2017-04-041-1/+5
| | | | | |
* | | | | | Merge pull request #28632 from ↵Rafael França2017-04-071-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_warning_extra_states_are_no_longer_copied Fix `warning: extra states are no longer copied`
| * | | | | | Fix `warning: extra states are no longer copied`Ryuta Kamizono2017-04-011-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `messages` has `default_proc` so calling `reject` causes the warning. https://github.com/ruby/ruby/blob/v2_4_1/hash.c#L1335-L1337
* | | | | | | Merge pull request #28687 from kamipo/fix_warning_already_initialized_constantRafael França2017-04-061-1/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `warning: already initialized constant HashWithIndifferentAccessTest::HashWithIndifferentAccess`
| * | | | | | | Fix `warning: already initialized constant ↵Ryuta Kamizono2017-04-071-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HashWithIndifferentAccessTest::HashWithIndifferentAccess` Caused since #28607.
* | | | | | | | Merge pull request #28688 from kamipo/remove_duplicated_test_prefixRafael França2017-04-065-8/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove duplicated "test" prefix
| * | | | | | | | Remove duplicated "test" prefixRyuta Kamizono2017-04-075-8/+8
|/ / / / / / / /
* | | | | | | / Improve logging when Origin header doesn't matchJon Leighton2017-04-062-1/+16
| |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I came up against this while dealing with a misconfigured server. The browser was setting the Origin header to "https://example.com", but the Rails app returned "http://example.com" from request.base_url (because it was failing to detect that HTTPS was used). This caused verify_authenticity_token to fail, but the message in the log was "Can't verify CSRF token", which is confusing because the failure had nothing to do with the CSRF token sent in the request. This made it very hard to identify the issue, so hopefully this will make it more obvious for the next person.
* | | | | | | Work around all the thingsMatthew Draper2017-04-061-1/+11
| |_|_|/ / / |/| | | | |
* | | | | | Merge pull request #28673 from koic/oracle_does_not_support_index_commentAndrew White2017-04-051-5/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | Ignore AR tests of index comment when using Oracle
| * | | | | | Ignore AR tests of index comment when using OracleKoichi ITO2017-04-051-5/+9
| | |_|/ / / | |/| | | |
* | | | | | Merge pull request #28671 from y-yagi/use_appropriate_type_to_header_optionMatthew Draper2017-04-051-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Use appropriate type to `header` option
| * | | | | Use appropriate type to `header` optionyuuji.yaginuma2017-04-051-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | The `header` option checks only whether it is specified or not. https://github.com/rails/rails/blob/e8c33349bfabca28996ac74d344d69c7aaffec50/railties/lib/rails/commands/dbconsole/dbconsole_command.rb#L52
* | | | | Avoid "can't modify frozen IOError" failuresMatthew Draper2017-04-051-5/+16
| | | | | | | | | | | | | | | | | | | | https://bugs.ruby-lang.org/issues/13239
* | | | | Merge pull request #28665 from claudiob/don-t-highlight-code-in-linksClaudio B2017-04-041-4/+2
|\ \ \ \ \ | | | | | | | | | | | | Don't highlight code in anchorlink [ci skip]
| * | | | | Don't highlight code in anchorlink [ci skip]claudiob2017-04-041-4/+2
|/ / / / / | | | | | | | | | | | | | | | Minor fix to #28662
* | | | | Merge pull request #28662 from diazruy/guides-linksMatthew Draper2017-04-051-1/+4
|\ \ \ \ \ | |_|/ / / |/| | | | Downplay links in Guides headers
| * | | | Downplay links in Guides headersRuy Diaz2017-04-041-1/+4
|/ / / / | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #27832 from bdewater/backtrace-silencer-regexMatthew Draper2017-04-041-1/+1
|\ \ \ \ | | | | | | | | | | Update backtrace cleaner to use `Regexp#match?`
| * | | | Update backtrace cleaner to use `Regexp#match?`Bart de Water2017-02-131-1/+1
| | | | |
* | | | | Merge pull request #28057 from eugeneius/clear_active_connectionsMatthew Draper2017-04-042-0/+16
|\ \ \ \ \ | | | | | | | | | | | | Clear active connections after initialization
| * | | | | Clear active connections after initializationEugene Kenny2017-02-172-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any connections that were checked out during initialization should be checked back in before the first request is processed, for two reasons: - Returning the connection to the pool allows it to be health checked before it's used again. If the connection dies before the first request arrives, the health check will replace it with a new one. - If the thread that initialized Rails is not the same thread that will be performing work, checking in the connection will allow it to be reused instead of being stuck to the initialization thread forever.
* | | | | | Merge pull request #28029 from koic/empty_insert_statement_value_not_supportedMatthew Draper2017-04-042-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Raise NotImplementedError when using empty_insert_statement_value with Oracle
| * | | | | | Raise NotImplementedError when using empty_insert_statement_value with OracleKoichi ITO2017-02-172-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Refer: https://github.com/rsim/oracle-enhanced/pull/1180
* | | | | | | Revert "Merge pull request #28598 from wnadeau/patch-1"Rafael Mendonça França2017-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a680a5814184e2f37c4686aa53d0ad3c7fb6b1ee, reversing changes made to 842f67dd242e738419f27e752ea7dcd0bbe87b6d. Reason: I can't resist to the joke, so better to keep it there https://github.com/rails/rails/pull/28598#issuecomment-290945339.
* | | | | | | Merge pull request #28649 from y-yagi/ruby-241Matthew Draper2017-04-031-1/+1
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | CI against Ruby 2.4.1
| * | | | | | CI against Ruby 2.4.1yuuji.yaginuma2017-04-031-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | Related #28532, #27636
* | | | | | Revert "Avoid broken faraday 0.12.0 release"Matthew Draper2017-04-022-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 82a7593e3ac427215a280dae5bd6cd42f9404650.
* | | | | | Avoid broken faraday 0.12.0 releaseMatthew Draper2017-04-022-1/+3
| | | | | |
* | | | | | Merge pull request #28641 from diazruy/anchorsMatthew Draper2017-04-022-0/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add anchor links to all headers
| * | | | | | Add anchor links to all headersRuy Diaz2017-04-012-0/+7
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | To allow easy linking at all levels and not just from index
* | | | | | Merge pull request #28642 from ttanimichi/patch-1Matthew Draper2017-04-021-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | No need to check nil
| * | | | | | No need to check nilTsukuru Tanimichi2017-04-021-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby nil.respond_to?(:stringify_keys) # => false ``` ```ruby include ActiveModel::AttributeAssignment Object.new.assign_attributes(nil) # => ArgumentError: When assigning attributes, you must pass a hash as an argument. ```
* | | | | | Merge pull request #28636 from bkeepers/patch-2Matthew Draper2017-04-021-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Limit stale checks to issues
| * | | | | | Limit stale checks to issuesBrandon Keepers2017-04-011-0/+2
| |/ / / / /
* | | | | | Remove CHANGELOG.md entry that appears in 5-1-stableJon Moss2017-04-011-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CHANGELOG.md is a continuation of the 5-1-stable one, there shouldn't be any duplicate entries. [ci skip]
* | | | | | Merge pull request #28629 from rossta/patch-4Jon Moss2017-04-011-2/+14
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Add default_scope note to ActiveRecord guide
| * | | | | Add default_scope note to AR guide [ci skip]Ross Kaffenberger2017-03-311-2/+14
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds note to explain unexpected behavior described in issue #28561. Developers may be surprised that the internal representation of similar query conditions in Hash and Array formats in default_scope will yield different results for model initialization. Link: https://github.com/rails/rails/issues/28561
* | | | | Correct typo in component nameAndrew White2017-03-311-1/+1
| | | | |
* | | | | Merge pull request #28621 from koic/fix_failed_test_when_running_with_oracleEileen M. Uchitelle2017-03-311-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Fix a failed AR test when running with OracleAdapter
| * | | | | Fix a failed AR test when running with OracleAdapterKoichi ITO2017-03-311-0/+2
| | | | | |
* | | | | | Merge pull request #28612 from tricknotes/ruby-2.3.4Andrew White2017-03-311-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | CI against Ruby 2.3.4
| * | | | | | CI against Ruby 2.3.4Ryunosuke Sato2017-03-311-3/+3
| |/ / / / / | | | | | | | | | | | | | | | | | | https://www.ruby-lang.org/en/news/2017/03/30/ruby-2-3-4-released/
* | | | | | Merge pull request #28620 from ↵Kasper Timm Hansen2017-03-311-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | y-yagi/add_missing_backtick_to_deprecation_message Add missing backtick to deprecation message
| * | | | | Add missing backtick to deprecation messageyuuji.yaginuma2017-03-311-1/+1
|/ / / / /
* | | | | Merge pull request #28616 from spdawson/patch-4Jon Moss2017-03-301-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix example usage of ActiveRecord::Base.establish_connection [ci skip]
| * | | | | Fix example usage of ActiveRecord::Base.establish_connectionSimon Dawson2017-03-301-1/+1
| | | | | | | | | | | | | | | | | | `ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 09:49:33 +0000