aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | | | | | Merge pull request #125 from lsylvester/handle-custom-loggersDavid Heinemeier Hansson2015-12-113-8/+14
| | |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Handle cases where logger is not a tagged logger.
| | | * | | | | | | | | Handle cases where logger is not a tagged logger.Lachlan Sylvester2015-11-183-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, a TaggedLoggerProxy was only created if the logger responded to :tagged, but was still used as if it was a TaggedLoggerProxy elsewhere in the code, causing undefined method errors. This moved the check for tagging abilities inside the TaggedLoggerProxy so the code can always tread the logger like a tagged logger, and if it is not a tagged logger the tags will just be ignored. This prevents needing to check if the logger is tagged every time we use it.
| | * | | | | | | | | | Merge pull request #126 from mikecarroll/add_allowed_request_origins_to_readmeDavid Heinemeier Hansson2015-12-111-3/+24
| | |\ \ \ \ \ \ \ \ \ \ | | | |_|_|_|/ / / / / / | | |/| | | | | | | | | README.md instructions for configuring allowed request origins
| | | * | | | | | | | | Add README.md instructions on configuring ↵Michael Carroll2015-11-201-3/+24
| | | |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionCable.server.config.allowed_request_origins
| | * | | | | | | | | Merge pull request #133 from assimovt/masterDavid Heinemeier Hansson2015-12-091-1/+1
| | |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Update README find_verified_user example
| | | * | | | | | | | | Update README find_verified_user exampleTair Assimov2015-12-081-1/+1
| | |/ / / / / / / / /
| | * | | | | | | | | Merge pull request #128 from ma2gedev/patch1Rafael França2015-12-031-1/+1
| | |\ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / | | |/| | | | | | | | fix typo
| | | * | | | | | | | fix typoTakayuki Matsubara2015-12-031-1/+1
| | |/ / / / / / / /
| | * | | | | | | | Tune whitespace in README.mdKasper Timm Hansen2015-11-151-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Realign `end` statements with the opening `class` statement. * Pad JavaScript objects with spaces to match Rails styleguide and for consistency with other examples.
| | * | | | | | | | Merge pull request #117 from rails/shared-constantsJavan Makhmali2015-11-068-27/+30
| | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Share internal identifiers and message types with the JavaScript client
| | | * | | | | | | | Share internal identifiers and message types with the JavaScript clientJavan Makhmali2015-11-068-27/+30
| | |/ / / / / / / /
| | * / / / / / / / Missed updating a method namePratik Naik2015-11-061-1/+1
| | |/ / / / / / /
| | * | | | | | | Rename Subscription#reject! to Subscription#reject as there's only one ↵Pratik Naik2015-11-052-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version of the method
| | * | | | | | | Merge pull request #102 from rails/subscription-rejectionPratik2015-11-048-17/+102
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Allow rejecting subscriptions from the channel
| | | * | | | | | | Add some documentation explaining subscription rejectionPratik Naik2015-11-042-0/+19
| | | | | | | | | |
| | | * | | | | | | Fix a merge fail syntax issuePratik Naik2015-11-041-1/+1
| | | | | | | | | |
| | | * | | | | | | Merge branch 'master' into subscription-rejectionPratik Naik2015-11-0410-50/+65
| | | |\ \ \ \ \ \ \ | | | |/ / / / / / / | | |/| | | | | | |
| | * | | | | | | | Make sure cable closes the connection if open when responding to an invalid ↵Pratik Naik2015-11-042-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | request
| | * | | | | | | | Merge pull request #113 from dballona/fix-subscription-callbacksJeremy Daer2015-11-042-3/+9
| | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fixing subscription callbacks
| | | * | | | | | | | Fixing subscription callbacksDiego Ballona2015-11-042-3/+9
| | | | | | | | | | |
| | * | | | | | | | | Merge pull request #106 from nobrick/masterKasper Timm Hansen2015-10-241-2/+2
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unnecessary space in README [ci skip]
| | | * | | | | | | | Remove unnecessary space in README [ci skip]Ming Qu2015-10-241-2/+2
| | |/ / / / / / / /
| | * | | | | | | | Don't ask an yanked celluloid versionRafael Mendonça França2015-10-231-4/+4
| | | | | | | | | |
| | * | | | | | | | Use our standard name for the GemfileRafael Mendonça França2015-10-232-1/+1
| | | | | | | | | |
| | * | | | | | | | Fix travis matrixRafael Mendonça França2015-10-231-1/+2
| | | | | | | | | |
| | * | | | | | | | Merge pull request #69 from mieko/callbacksRafael Mendonça França2015-10-234-34/+29
| | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use ActiveSupport::Callbacks for Channel subscription callbacks.
| | | * | | | | | | | Use ActiveSupport::Callbacks for Channel subscription callbacks.Mike A. Owens2015-08-244-33/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rely on AS::Callbacks for callback handling. * Add before_subscribe, after_subscribe, before_unsubscribe and after_unsubscribe convenience methods * alias on_subscribe and on_unsubscribe to after_subscribe and after_unsubscribe, respectively. * Remove `subscribed` and `unsubscribed` from the callback chain: these methods are now executed as the subject of the callbacks. * Update portions of ActionCable to use the more specific callback names.
| | * | | | | | | | | Merge pull request #84 from alexpeattie/nonstandard-logger-fixRafael França2015-10-231-3/+5
| | |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix NoMethodError when using a custom Rails.logger class
| | | * | | | | | | | | Fix NoMethodError when using a custom Rails.logger classAlex Peattie2015-10-061-3/+5
| | | | | | | | | | | |
| | * | | | | | | | | | Merge pull request #46 from rajcybage/readme_fixRafael França2015-10-231-0/+2
| | |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | small description on readme for identified_by
| | | * | | | | | | | | | [ci skip] small description on readme for identified_byRajarshi Das2015-07-301-0/+2
| | | | | | | | | | | | |
| | | | | | * | | | | | | Better method names in Javascript based on the feedback from @javanPratik Naik2015-10-222-18/+19
| | | | | | | | | | | | |
| | | | | | * | | | | | | Allow rejecting subscriptions from the channelPratik Naik2015-10-217-10/+75
| | | |_|_|/ / / / / / / | | |/| | | | | | | | |
| | * | | | | | | | | | Fix the error message in testsPratik Naik2015-10-191-1/+1
| | | | | | | | | | | |
| | * | | | | | | | | | Better test namePratik Naik2015-10-191-1/+1
| | | | | | | | | | | |
| | * | | | | | | | | | Make sure the subscription confirmaion is only sent out oncePratik Naik2015-10-192-2/+34
| | | | | | | | | | | |
| | * | | | | | | | | | Merge pull request #98 from rails/subscription-confirmationPratik2015-10-198-18/+76
| | |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Send subscription confirmation from server to the client to avoid race conditions
| | | * | | | | | | | | | Freeze the SUBSCRIPTION_CONFIRMATION_INTERNAL_MESSAGE valuePratik Naik2015-10-191-1/+1
| | | | | | | | | | | | |
| | | * | | | | | | | | | Fix an error message in the subscription testsPratik Naik2015-10-161-1/+1
| | | | | | | | | | | | |
| | | * | | | | | | | | | Send subscription confirmation from server to the client to avoid race ↵Pratik Naik2015-10-168-18/+76
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conditions. Without this, it's very easy to send messages over a subscription even before the redis pubsub has been fully initialized. Now we delay calling the subscription#connected method on the client side until we receive a subscription confirmation message from the server.
| | * | | | | | | | | | Fix stream testsPratik Naik2015-10-161-2/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Cover stray deps for the logging convenience requireJeremy Daer2015-10-161-0/+4
| | | | | | | | | | | |
| | * | | | | | | | | | Merge branch 'adjust-reconnect'Jeremy Daer2015-10-162-23/+29
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | Tweak reconnect timingJavan Makhmali2015-10-141-14/+15
| | | | | | | | | | | | |
| | | * | | | | | | | | | Remove immediate reconnect to help avoid thundering herd after server restartsJavan Makhmali2015-10-141-4/+0
| | | | | | | | | | | | |
| | | * | | | | | | | | | Avoid returning results of loopJavan Makhmali2015-10-141-0/+1
| | | | | | | | | | | | |
| | | * | | | | | | | | | Add delay before reopeningJavan Makhmali2015-10-141-2/+9
| | | | | | | | | | | | |
| | | * | | | | | | | | | Improve guard against opening multiple web socketsJavan Makhmali2015-10-141-3/+4
| | | | | | | | | | | | |
| | * | | | | | | | | | | Merge pull request #97 from lsylvester/speed-up-testsJeremy Daer2015-10-161-1/+2
| | |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speed up tests be calling EM.run_deferred_callbacks instead of setting a timer
| | | * | | | | | | | | | | Speed up tests be calling EM.run_deferred_callbacks instead of setting a timerLachlan Sylvester2015-10-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The run_in_eventmachine test helper method is setting a 0.1 second timer to stop the event machine loop. This causes each test that requires an event machine loop to wait for 0.1 second regardless of how long the test takes to process. This changes that to call EM.run_deferred_callbacks, which immediatly process pending actions in the event loop and then is able to exit the event loop without doing any waiting. Before this change, running tests produced Finished in 2.957857s, 15.8899 runs/s, 27.7228 assertions/s. After, the tests get Finished in 0.065942s, 712.7514 runs/s, 1243.5237 assertions/s.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-05 03:45:16 +0000