| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 026d0555685087845b74dd87a0417b5a164b1c13.
Conflicts:
activerecord/lib/active_record/fixtures.rb
Fixes #13383
|
| |\ \ \
| | |/ /
| |/| | |
Adding Hash#compact and Hash#compact! methods
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Adding Hash#compact and Hash#compact! methods
* Using Ruby 1.9 syntax on documentation
* Updating guides for `Hash#compact` and `Hash#compact!` methods
* Updating CHANGELOG for ActiveSupport
* Removing unecessary protected method and lambda for `Hash#compact` implementations
* Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883
* fixing order position
* Fixing typo
|
| |\ \ \
| | | | |
| | | | | |
MySQL version 4.1 was EOL on December 31, 2009 [ci-skip]
|
| |/ / /
| | | |
| | | |
| | | | |
We should at least recommend modern versions of MySQL to users.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
fixes #13547
The body may use the local cache during rendering. `call`ing the app
doesn't mean that rendering is finished, so we need to wait until
`close` is called on the body.
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Move finish_template as the last public method defined in the generator
|
| | |/ / |
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
Fix typo [ci skip]
|
| |/ / |
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes #13623.
|
| |\ \
| | | |
| | | | |
Be more explicit about the default of db:drop and db:create
|
| |/ /
| | |
| | |
| | | |
Closes #13625
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3.
As described in PR #13627 this commit broke functionality when passing
a negative Fixnum to the `String#to` method:
```ruby
assert_equal "hell", s.to(-2)
```
Before the revert, this failed with:
```
1) Failure:
StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]:
Expected: "hell"
Actual: nil
```
This revert is to keep the functionality on `master` working.
If there is another way to get the performance benefit and keep
the documented functionality we can add that.
/cc @amatsuda @carlosantoniodasilva
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I also extracted the tests from a single bulk method into a separate test-case.
The new tests cover the API described in the docs.
There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3
* #to with negative Fixnum, position is counted from the end
* #from and #to can be combined
This was brought to my attention by #13627.
Closes #13627.
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
activerecord: Initialize Migration with version from MigrationProxy.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Fix typo in image_tag documentation [ci skip]
|
| |/ / /
| | | |
| | | | |
image_tag only supports :alt and :size as additional keys, not three.
|
| |\ \ \
| | | | |
| | | | | |
Make change_table use object of current database adapter
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Earlier, change_table was creating database-agnostic object.
- After this change, it will create correct object based on current
database adapter.
- This will ensure that create_table and change_table will get same objects.
- This makes update_table_definition method public and nodoc.
- Fixes #13577 and #13503
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Also improve changelog entries related to secure password to proper
highlight.
|
| |\ \ \
| | | | |
| | | | | |
Add 'e' var on rescue DalliError, in order to log it
|
| |/ / / |
|
| |\ \ \
| | |/ /
| |/| | |
Remove warnings in test suite
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
lib/active_record/store.rb:79: warning: method redefined; discarding old color=
lib/active_record/store.rb:79: warning: previous definition of color= was here
lib/active_record/store.rb:83: warning: method redefined; discarding old color
lib/active_record/store.rb:83: warning: previous definition of color was here
|
| |\ \
| | | |
| | | | |
Fix: ActiveRecord::Store TypeError conversion when using YAML coder
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Renaming the test accordingly to its behaviour
Adding 'Fixes' statement to changelog
Improving tests legibility & changelog
Undoing mistakenly removed empty line & further improving changelog
|
| | | |
| | | |
| | | |
| | | | |
/cc @pixeltrix
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Wrapping symbols with + does not work, we must use <tt> instead.
|
| |\ \ \
| | | | |
| | | | | |
Add missing tests for invalid names in `rails plugin new` generator
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Test for: Invalid plugin name, because of reserved rails word.
* Test for: Invalid plugin name because of constant name that is already in use.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Require actionview/version
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
just like all the other modules do require their version file
|
| |\ \ \ \
| | |_|/ /
| |/| | | |
Ruby is a proper noun here, not part of code fragment [ci skip]
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Last line of note also relates heavily to first part
and parenthesis broke reading flow.
|
| | | |
| | | |
| | | |
| | | | |
Fixes #12777
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Maintain proleptic gregorian in Time#advance
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Time#advance uses Time#to_date and Date#advance to calculate a new date.
The Date object returned by Time#to_date is constructed with the assumption
that the Time object represents a proleptic gregorian date, but it is
configured to observe the default julian calendar reform date (2299161j)
for purposes of calculating month, date and year:
Time.new(1582, 10, 4).to_date.to_s # => "1582-09-24"
Time.new(1582, 10, 4).to_date.gregorian.to_s # => "1582-10-04"
This patch ensures that when the intermediate Date object is advanced
to yield a new Date object, that the Time object for return is contructed
with a proleptic gregorian month, date and year.
|