rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| \| * \| \| \| \| \|	Initialized tags and attributes to nil.	Timm	2014-06-16	1	-0/+4
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Refactored scrub to keep_node? instead of scrub_node calling it. Also added ↵	Timm	2014-06-16	1	-6/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ability to stop traversing by returning STOP from scrub_node.
\| \| * \| \| \| \| \|	Changed PermitScrubber to be even more extensible. Updated TargetScrubber to ↵	Timm	2014-06-16	1	-39/+40
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
\| \| * \| \| \| \| \|	Changed PermitScrubbers documentation to list override points for ↵	Timm	2014-06-16	1	-12/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
\| \| * \| \| \| \| \|	Already killed off LinkScrubber. Changed it instead to be TargetScrubber, ↵	Timm	2014-06-16	2	-9/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	which is more general, while still allowing maximum code reuse.
\| \| * \| \| \| \| \|	Added LinkScrubber to remove duplication in LinkSanitizer. As such made ↵	Timm	2014-06-16	2	-11/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	PermitScrubber easier to subclass.
\| \| * \| \| \| \| \|	Changed FullSanitizer sanitize to use tap method instead of temporary variable.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Extracted the common xpaths to remove into XPATHS_TO_REMOVE.	Timm	2014-06-16	1	-2/+4
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Refactored remove_xpaths to use duck typing and read better.	Timm	2014-06-16	1	-4/+5
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Changed explanation for no duck typing of custom scrubbers.	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Added correct requires in html-scanner tests. Sanitizers are not based on ↵	Timm	2014-06-16	7	-330/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	html-scanner anymore, so sanitizer_test.rb is removed.
\| \| * \| \| \| \| \|	Require ActionView::Assertions in ActionController test_case.rb.	Timm	2014-06-16	1	-0/+1
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Marked test_feed_xhtml as pending. See description in the test.	Timm	2014-06-16	1	-0/+1
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Removed copyright notice since we aren't relying on html-scanner anymore.	Timm	2014-06-16	1	-5/+0
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Removed require for active_support/core_ext/object/inclusion since in? isn't ↵	Timm	2014-06-16	1	-2/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	used anywhere.
\| \| * \| \| \| \| \|	Moved Dom and Selector assertions from ActionDispatch to ActionView.	Timm	2014-06-16	11	-545/+557
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Fixed: assert_select_encoded finds the right content. No longer uses a ↵	Timm	2014-06-16	2	-14/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	<encoded> wrapper. Updated tests to reflect this.
\| \| * \| \| \| \| \|	Removed mention of css_select supporting substitution values. It is not ↵	Timm	2014-06-16	1	-7/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tested anywhere.
\| \| * \| \| \| \| \|	Updated documentation to state more things about css selectors with ↵	Timm	2014-06-16	1	-3/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	substitution values.
\| \| * \| \| \| \| \|	Reworked the wrapping root in NodeSet implementation in css_select.	Timm	2014-06-16	1	-3/+5
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Wrapped element to search in NodeSet. Changed selectors to selector.	Timm	2014-06-16	1	-3/+5
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Moved around alias line.	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Returning from filter if matches are empty.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Fixed: no longer wrapped @selected in fragment, since .css works fine ↵	Timm	2014-06-16	1	-2/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	without it.
\| \| * \| \| \| \| \|	Reverted to using documents instead of document fragments, since searching ↵	Timm	2014-06-16	1	-3/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	via default xml namespaces didn't work.
\| \| * \| \| \| \| \|	add_regex returns inspected value for non Regexp objects. Workaround, so ↵	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	users don't have to care about enclosing values in double quotes.
\| \| * \| \| \| \| \|	Added test case for non-comment. Removed pending assertion that passed.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Fixed: test_nested_assert_select selects from elements instead of ↵	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	elements[0] and elements[1].
\| \| * \| \| \| \| \|	Fixed: inadvertently called message method in MiniTest instead of ↵	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	selector.message.
\| \| * \| \| \| \| \|	Cleaned up SubstitutionContext class.	Timm	2014-06-16	1	-10/+8
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Simplified assert_select further by moving match filtering into HTMLSelector ↵	Timm	2014-06-16	1	-32/+29
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	select.
\| \| * \| \| \| \| \|	Fixed: now only compares html of children in filter_matches.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Added NodeSet comparison to possible root element in determine_root_from.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Changed html_document to use fragments. Changed response_from_page to be an ↵	Timm	2014-06-16	1	-6/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	alias of html_document.
\| \| * \| \| \| \| \|	Changed xml_namespace test to correct syntax. However, Nokogiri won't ↵	Timm	2014-06-16	1	-2/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	recognize the namespace.
\| \| * \| \| \| \| \|	Fixed bug by switching to Loofah fragment instead of document.	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Changed test methods to use new substitution syntax more in line with css ↵	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	selectors.
\| \| * \| \| \| \| \|	Changed css_select to not count on multiple selectors. Fixed bug in ↵	Timm	2014-06-16	1	-8/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document.
\| \| * \| \| \| \| \|	Added a proper substitution context class. Changed ArgumentFilter to be a ↵	Timm	2014-06-16	1	-34/+47
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	selector. It is now called HTMLSelector.
\| \| * \| \| \| \| \|	Fixed nested assert_select bug. Trying to create a full document for a ↵	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	nested call that already had a document.
\| \| * \| \| \| \| \|	Added implementation for substitution values via Nokogiri's custom pseudo ↵	Timm	2014-06-16	1	-5/+35
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	classes.
\| \| * \| \| \| \| \|	Readded some documentation about substitution values.	Timm	2014-06-16	2	-5/+15
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError.	Timm	2014-06-15	1	-2/+2
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Updated testing guide to reflect changes in ActionDispatch::SelectorAssertions.	Timm	2014-06-15	1	-3/+3
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Updated documentation to remove mention of HTML::Selector and clarify what ↵	Timm	2014-06-15	1	-21/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	is expected of a selector now.
\| \| * \| \| \| \| \|	Changed tests to assert_kind_of Loofah::HTML::Document.	Timm	2014-06-15	1	-3/+3
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Readded html_document method since it is used integration tests.	Timm	2014-06-15	1	-1/+5
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Removed selector_test.rb since HTML::Selector will be removed. Soon.	Timm	2014-06-15	1	-629/+0
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Changed filter_matches to return a new NodeSet instead of Array.	Timm	2014-06-15	1	-1/+2
\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \|	Fixed Nokogiri::CSS::SyntaxErrors.	Timm	2014-06-15	2	-34/+34
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters.