Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #8398 from rmascarenhas/active-model-errors-spec-fixes | Rafael Mendonça França | 2012-12-01 | 1 | -3/+2 |
|\ | | | | | ActiveModel::Errors spec fixes | ||||
| * | Actually test that ActiveModel::Errors#add defaults to :invalid. | Renato Mascarenhas | 2012-12-01 | 1 | -1/+1 |
| | | |||||
| * | Call `full_messages` instead of `to_a` in its spec. | Renato Mascarenhas | 2012-12-01 | 1 | -2/+1 |
|/ | |||||
* | Merge pull request #8397 from mmb/gitignore_global_home | Rafael Mendonça França | 2012-12-01 | 1 | -1/+1 |
|\ | | | | | Quote ~ in git config global excludes command. | ||||
| * | Quote ~ in git config global excludes command. | Matthew M. Boedicker | 2012-12-01 | 1 | -1/+1 |
|/ | | | | | This will put ~/ in .gitconfig so it will not be hardcoded to the home directory where the command was run. | ||||
* | Only take the date parts from Time.zone.now | Andrew White | 2012-12-01 | 2 | -3/+10 |
| | | | | | | | When there are missing components in the Hash returned by Date._parse only the date components should default to the value of Time.zone.now, the time components should all default to zero. | ||||
* | Merge pull request #8382 from asanghi/mailerguide | Vijay Dev | 2012-12-01 | 1 | -1/+52 |
|\ | | | | | Add Mailer Callback section to Mailer guides | ||||
| * | Add Mailer Callback section to Mailer guides | Aditya Sanghi | 2012-12-02 | 1 | -1/+52 |
| | | |||||
* | | Remove not used variable warnigns | Carlos Antonio da Silva | 2012-12-01 | 2 | -5/+5 |
|/ | |||||
* | Merge pull request #8391 from rmascarenhas/reset-attribute-doesnt-change-it | Rafael Mendonça França | 2012-12-01 | 3 | -3/+9 |
|\ | | | | | Reset attributes should not report changes. | ||||
| * | Reset attributes should not report changes. | Renato Mascarenhas | 2012-12-01 | 3 | -3/+9 |
| | | | | | | | | | | | | | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~ | ||||
* | | Merge pull request #8379 from steveklabnik/validations_guide | Vijay Dev | 2012-12-01 | 4 | -347/+342 |
|\ \ | |/ |/| | Validations guide | ||||
| * | Here's a few updates to the validations guide. A bunch of small changes, | Steve Klabnik | 2012-12-01 | 4 | -347/+342 |
|/ | | | | | | | | plus: * 80 column formats * replacing the explanation of the dynamic_form gem with the example HTML/CSS that Rails scaffolds generate. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-12-01 | 40 | -261/+299 |
|\ | | | | | | | | | Conflicts: guides/source/active_record_validations.md | ||||
| * | copy edits [ci skip] | Vijay Dev | 2012-12-01 | 2 | -2/+2 |
| | | |||||
| * | Fix Calculations#pluck doc to mention several attributes can be selected [ci ↵ | Florent Guilleux | 2012-12-01 | 1 | -3/+3 |
| | | | | | | | | skip] | ||||
| * | Normalize on 'After reading this guide, you will know:' | Steve Klabnik | 2012-11-29 | 37 | -28/+80 |
| | | | | | | | | | | We have three or four different introduction sentences to the guides. After this commit, we use the same one everywhere. | ||||
| * | nodoc AS::Deprecation::InstanceDelegator class [ci skip] | Francesco Rodriguez | 2012-11-29 | 1 | -3/+3 |
| | | |||||
| * | add documentation to CollectionProxy #length and #size methods [ci skip] | Francesco Rodriguez | 2012-11-29 | 1 | -2/+7 |
| | | |||||
| * | add documentation to CollectionProxy#empty? | Francesco Rodriguez | 2012-11-29 | 1 | -1/+6 |
| | | |||||
| * | Asset Pipeline: add 'the' | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | | | | | Some guides work without 'the'. For instance, 'Migrations' or 'Form Helpers.' But when we talk about the asset pipeline, we... always say 'the asset pipeline.' The guide title should reflect this. | ||||
| * | Command Line: remove 'A Guide to' | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | It's obvious that this is a guide. | ||||
| * | Migrations: add 'Active Record' to title | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | | | Other guides that talk about Active Record specific features include the name of the library in the title, this one should too for consistency. | ||||
| * | Fix title of 'form helpers' guide. | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | | | | | They're Rails Guides, so obviously we're talking about Rails Form Helpers. Also, 'helpers' should be capitalized. | ||||
| * | Associations: s/A Guide// | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | It's obvious that this is a guide, and none of the other guides say 'A Guide to'. | ||||
| * | Remove 'This guide is based on ' warnings. | Steve Klabnik | 2012-11-29 | 4 | -9/+0 |
| | | | | | | | | It's obvious that the guide is based on this version of Rails, and may not be backwards compatible. | ||||
| * | Add periods to the bullet points in guides. | Steve Klabnik | 2012-11-29 | 28 | -126/+126 |
| | | | | | | | | Talked with @fxn about this. Bullet points should have periods at the ends. | ||||
| * | Migrations: Fix opening bullets. | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | The wording of these was a bit off, so I fixed them. | ||||
| * | ActionView -> Action View | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | The proper name has a space. | ||||
| * | ActionController -> Action Controller | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | The proper name has a space. | ||||
| * | ActiveSupport -> Active Support | Steve Klabnik | 2012-11-29 | 1 | -4/+4 |
| | | | | | | | | The proper name has a space. | ||||
| * | ActionMailer -> Action Mailer. | Steve Klabnik | 2012-11-29 | 1 | -2/+2 |
| | | | | | | | | The proper name for the library has a space. | ||||
| * | ActionPack -> Action Pack. | Steve Klabnik | 2012-11-29 | 1 | -1/+1 |
| | | | | | | | | The proper name has a space. | ||||
| * | ActiveRecord -> Active Record | Steve Klabnik | 2012-11-29 | 5 | -6/+6 |
| | | | | | | | | | | The proper name, as per the documentation guides, is 'Active Record.' I've updated several references to it as 'ActiveRecord'. | ||||
| * | Migrations: move massive paragraph out of intro. | Steve Klabnik | 2012-11-29 | 1 | -10/+19 |
| | | | | | | | | | | | | | | Most of the guides have a few simple sentences describing what they will show you at the top. This one had a few big paragraphs. I've moved those paragraphs down to an introductory one, and written a new smaller one for the introduction. This makes this guide more consistent with the others. | ||||
| * | Getting Started: Improve instructions on opening a terminal | Steve Klabnik | 2012-11-29 | 1 | -1/+4 |
| | | |||||
| * | Getting Started: remove reference to attr_accessible | Steve Klabnik | 2012-11-29 | 1 | -11/+0 |
| | | |||||
| * | Getting Started: mac -> Mac OS X | Steve Klabnik | 2012-11-29 | 1 | -1/+1 |
| | | | | | | | | It's properly called "Mac OS X" | ||||
| * | Getting Started: Rails 3.2 -> Rails 4. | Steve Klabnik | 2012-11-29 | 1 | -1/+1 |
| | | | | | | | | This is based on Rails 4, not Rails 3.2. | ||||
| * | Revert "correct css selector for the display of validation error messages: ↵ | Xavier Noria | 2012-11-28 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | changed #error_explanation to #errorExplanation" At least in master the selector is snake case. This reverts commit ba2fed41613e02bb6cfc46c92ace00abb99ce313. | ||||
| * | Clarifies the cookie store docs a bit and uses correct Markdown syntax for ↵ | Andy Lindeman | 2012-11-27 | 1 | -1/+1 |
| | | | | | | | | preformatted text | ||||
| * | Adding a note about :inverse_of for validations. | Steve Klabnik | 2012-11-27 | 1 | -0/+8 |
| | | | | | | | | From https://github.com/lifo/docrails/commit/cfd324b4b68469ba3188e4b7ba8586e59b239693\#commitcomment-2213592 | ||||
| * | Fix validation based on object not _id. | Steve Klabnik | 2012-11-27 | 1 | -2/+2 |
| | | | | | | | | From https://github.com/rails/rails/issues/6161\#issuecomment-10750118 | ||||
| * | correct css selector for the display of validation error messages: changed ↵ | Harper Henn | 2012-11-27 | 1 | -4/+4 |
| | | | | | | | | #error_explanation to #errorExplanation | ||||
| * | Set fixed-width style where appropriate on Getting Started guide. | Hendy Tanata | 2012-11-27 | 1 | -2/+2 |
| | | |||||
| * | Merge pull request #119 from c0/master | Caleb Wright | 2012-11-25 | 1 | -1/+1 |
| |\ | | | | | | | Clarification to ActiveRecord Validations Doc in 7.2 Custom Methods | ||||
| | * | Update guides/source/active_record_validations_callbacks.md | Caleb Wright | 2012-11-25 | 1 | -1/+1 |
| |/ | | | | | In the expiration_date_cannot_be_in_the_past validation method, use `expiration_date.present?` instead of the double negative `!expiration_date.blank?`. Also join the comparisons with `&&` instead of `and`, which could cause unintended consequences. | ||||
| * | Revert "Updated with where functional/helper tests go" | Jason Noble | 2012-11-25 | 1 | -2/+2 |
| | | | | | | | | | | | | This reverts commit c94cfdad6388dcdfaf4c10b9e8cee46baf2a7901. * This is the new 4.0 (master) directory structure | ||||
| * | Reword Post model to note there are lines not shown | Jason Noble | 2012-11-24 | 1 | -1/+2 |
| | | |||||
| * | We should use post_path, not post_url | Jason Noble | 2012-11-24 | 1 | -1/+1 |
| | |