Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Missing require | Akira Matsuda | 2013-01-07 | 1 | -0/+2 | |
| | | ||||||
* | | These are already required through AS/rails | Akira Matsuda | 2013-01-07 | 8 | -12/+0 | |
| | | | | | | | | | | | | * dependencies/autoload * concern * deprecation | |||||
* | | Merge pull request #8263 from senny/refactor_plugin_new_generator | Yehuda Katz | 2013-01-06 | 5 | -11/+13 | |
|\ \ | | | | | | | refactor the naming within plugin new generator | |||||
| * | | refactor the naming within plugin new generator | Yves Senn | 2012-11-18 | 5 | -11/+13 | |
| | | | | | | | | | | | | | | | | | | Having a method called `full?`, which checks on :full and :mountable is very confusing. I renamed `full?` to `engine?` and created a `full?` method that only checks the `:full` option | |||||
* | | | Merge pull request #8770 from goshakkk/guides-img-fix | Xavier Noria | 2013-01-06 | 1 | -0/+4 | |
|\ \ \ | | | | | | | | | Fix img width in guides | |||||
| * | | | fix img width in guides | Gosha Arinich | 2013-01-05 | 1 | -0/+4 | |
| | | | | ||||||
* | | | | Merge pull request #8780 from diogomafra/require_core_ext | Carlos Antonio da Silva | 2013-01-06 | 1 | -0/+1 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Require 'active_support/core_ext/module/aliasing' in the infinite_comparable module When requiring 'active_support/core_ext', the following error is raised: undefined method `alias_method_chain' for Date:Class (NoMethodError) Adding the missing require to this module fixes the problem. | |||||
| * | | | | Require 'active_support/core_ext/module/aliasing' in the infinite_comparable ↵ | Diogo Mafra | 2013-01-06 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | module | |||||
* | | | | | Needless requires | Akira Matsuda | 2013-01-06 | 2 | -6/+0 | |
| | | | | | ||||||
* | | | | | Missing requires | Akira Matsuda | 2013-01-06 | 2 | -0/+2 | |
| | | | | | ||||||
* | | | | | These are already required through AS/rails | Akira Matsuda | 2013-01-06 | 5 | -6/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * core_ext/object/blank * concern * core_ext/class/attribute * deprecation | |||||
* | | | | | Rescue from LoadError when trying to load the debugger gem for console | Carlos Antonio da Silva | 2013-01-06 | 1 | -1/+1 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid swallowing all exceptions that might happen when requiring debugger, just catch a LoadError if it cannot be loaded. Check for more background: https://github.com/rails/rails/commit/28fd867c9bc790636d37a28f288791cd0089a6fd#commitcomment-2386952 | |||||
* | | | | Rename route_wrapper partial layout to table | Carlos Antonio da Silva | 2013-01-06 | 2 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler. | |||||
* | | | | Move table routes formatter class to the inspector and rename it | Carlos Antonio da Silva | 2013-01-06 | 4 | -20/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page. | |||||
* | | | | Merge pull request #8777 from goshakkk/delegate-class | Andrew White | 2013-01-06 | 5 | -5/+5 | |
|\ \ \ \ | | | | | | | | | | | Delegate to :class rather than 'self.class' | |||||
| * | | | | delegate to :class rather than 'self.class' | Gosha Arinich | 2013-01-06 | 5 | -5/+5 | |
| | | | | | ||||||
* | | | | | Refactor the logic that checks whether or not to emit the hidden id field | Carlos Antonio da Silva | 2013-01-06 | 1 | -7/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects. | |||||
* | | | | | Move the hidden :id field logic to where it belongs to | Carlos Antonio da Silva | 2013-01-06 | 1 | -6/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense. | |||||
* | | | | | Eliminate the usage of parent_builder option from form_for | Carlos Antonio da Silva | 2013-01-06 | 1 | -19/+15 | |
| | | | | | | | | | | | | | | | | | | | | Just use it internally from fields_for until we come up with a better solution. | |||||
* | | | | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 2 | -6/+18 | |
| | | | | | ||||||
* | | | | | Refactor to not call path.ast twice | Carlos Antonio da Silva | 2013-01-06 | 1 | -2/+3 | |
| | | | | | ||||||
* | | | | | Merge pull request #8779 from goshakkk/refactor-route-ast | Carlos Antonio da Silva | 2013-01-06 | 1 | -5/+4 | |
|\ \ \ \ \ | | | | | | | | | | | | | Refactor Route#ast to use or-equals and block, instead of return with a check | |||||
| * | | | | | refactor Route#ast to use or-equals and block, instead of return with a cond | Gosha Arinich | 2013-01-06 | 1 | -5/+4 | |
| | | | | | | ||||||
* | | | | | | Improve javascript in welcome page [ci skip] | Carlos Antonio da Silva | 2013-01-06 | 1 | -4/+5 | |
| | | | | | | ||||||
* | | | | | | This is not that common of a change to warrant top-line billing and you ↵ | David Heinemeier Hansson | 2013-01-06 | 1 | -6/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | should read more about the consequences than just toggling a boolean to make best use of it | |||||
* | | | | | | Include the standard reminder that you need to restart for changes in ↵ | David Heinemeier Hansson | 2013-01-06 | 2 | -0/+4 | |
|/ / / / / | | | | | | | | | | | | | | | | config/initializers to take effect | |||||
* | | | | | Update generated app's README [ci skip] | Akira Matsuda | 2013-01-06 | 1 | -7/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * a controller that destroying Weblogs might be WeblogsController * a controller that indexing Posts might be PostsController * Post.all returns a Relation * modernize Model.inspect results | |||||
* | | | | | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 15 | -123/+94 | |
| | | | | | ||||||
* | | | | | The controller generator invokes assets generator in addition | Akira Matsuda | 2013-01-06 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Fix generated migration file name in model generator USAGE | Akira Matsuda | 2013-01-06 | 1 | -7/+7 | |
| | | | | | ||||||
* | | | | | Update mailer generator USAGE | Akira Matsuda | 2013-01-06 | 1 | -3/+2 | |
|/ / / / | | | | | | | | | | | | | | | | | * it does not generate fixtures * it generates .text.erb templates | |||||
* | | | | Merge pull request #8774 from goshakkk/multiline-block-do-end | Carlos Antonio da Silva | 2013-01-05 | 3 | -6/+6 | |
|\ \ \ \ | |_|_|/ |/| | | | Prefer do-end for multiline block [ci skip] | |||||
| * | | | prefer do-end for multiline block | Gosha Arinich | 2013-01-06 | 3 | -6/+6 | |
|/ / / | ||||||
* | | | Merge pull request #8772 from goshakkk/guides-warning-fix | Rafael Mendonça França | 2013-01-05 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Fix guides' warning bottom padding | |||||
| * | | | fix guides' warning bottom padding | Gosha Arinich | 2013-01-06 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Remove the content_tag_for change from CHANGELOG since it was reverted | Rafael Mendonça França | 2013-01-05 | 1 | -5/+3 | |
| | | | ||||||
* | | | Merge pull request #8771 from lucasmazza/unobtrusive-javascript-examples | Steve Klabnik | 2013-01-05 | 1 | -31/+33 | |
|\ \ \ | | | | | | | | | New code examples on "Working with JavaScript in Rails" guide. | |||||
| * | | | Update some code examples on the "Working with JavaScript in Rails" guide. | Lucas Mazza | 2013-01-05 | 1 | -31/+33 | |
| | | | | ||||||
* | | | | Fix documentation to content_tag_for [ci skip] | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 | |
|/ / / | ||||||
* | | | Move config.filter_parameters to you own initializer file | Rafael Mendonça França | 2013-01-05 | 3 | -5/+4 | |
| | | | | | | | | | | | | This is very rarely changed and does not deserve to be in application.rb | |||||
* | | | Merge pull request #8766 from jcoglan/session_token_docs | Andrew White | 2013-01-05 | 1 | -7/+4 | |
|\ \ \ | | | | | | | | | | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip] | |||||
| * | | | Remove suggestion that Procs can be used as session secrets. | James Coglan | 2013-01-05 | 1 | -7/+4 | |
| | | | | ||||||
* | | | | Needless fancy structure that did not anything | David Heinemeier Hansson | 2013-01-05 | 1 | -1/+3 | |
| | | | | ||||||
* | | | | Assert config.filter_parameters should be able to be set in a initializer | Rafael Mendonça França | 2013-01-05 | 1 | -0/+10 | |
| | | | | ||||||
* | | | | Fix indention issue in generated template | David Heinemeier Hansson | 2013-01-05 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Fix indention issue in generated template | David Heinemeier Hansson | 2013-01-05 | 1 | -2/+2 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #8769 from senny/deprecate_assert_blank | David Heinemeier Hansson | 2013-01-05 | 16 | -43/+60 | |
|\ \ \ | | | | | | | | | deprecate `assert_blank` and `assert_present`. | |||||
| * | | | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 16 | -43/+60 | |
| | | | | | | | | | | | | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | |||||
* | | | | No need to give an example where there is generated code right there to ↵ | David Heinemeier Hansson | 2013-01-05 | 1 | -5/+1 | |
| | | | | | | | | | | | | | | | | serve as the example | |||||
* | | | | Make sure assets is disable when --skip-sprockets is used | Rafael Mendonça França | 2013-01-05 | 1 | -1/+2 | |
| | | | |