aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add CHANGELOG entryPrathamesh Sonpatki2016-02-251-0/+4
|
* Added deprecation for older appsPrathamesh Sonpatki2016-02-252-8/+28
| | | | | | | | - For old apps which are not setting any value for hsts[:subdomains], a deprecation warning will be shown saying that hsts[:subdomains] will be turned on by default in Rails 5.1. Currently it will be set to false for backward compatibility. - Adjusted tests to reflect this change.
* Old applications will not get the ssl_options initializerPrathamesh Sonpatki2016-02-252-0/+33
| | | | | - We will remove the initializer for old apps which are migrated to Rails 5 so that they are not affected by this breaking change.
* New applications will be generated with ssl_options to enable HSTS with ↵Prathamesh Sonpatki2016-02-251-0/+4
| | | | | | subdomains - We will reuse config.ssl_options for setting the HSTS settings.
* HSTS without IncludeSubdomains is often uselessEgor Homakov2016-02-251-1/+1
| | | | | | | | 1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases 2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing. That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted. Yes, many developers forget to add subdomains=true by default, believe me :)
* Merge pull request #23843 from maclover7/fix-23471Matthew Draper2016-02-253-10/+29
|\ | | | | Only hijack Rack socket when first needed
| * Only hijack Rack socket when first neededJon Moss2016-02-243-10/+29
| | | | | | | | Fixes #23471
* | Merge pull request #23863 from delftswa2016/fix-readme-headingJon Moss2016-02-243-4/+4
|\ \ | | | | | | Fix README heading according to Markdown conventions
| * | Fix title of README according to Markdown conventionsAaron Ang2016-02-253-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | The first heading in some README's are indicated using a second level heading (`##`), which in my opinion is of incorrect structure. Therefore, in this patch I changed the first heading to a first level heading (`#`) in README's where this incorrect structure occurs. [ci skip]
* | | Merge pull request #23488 from maclover7/actioncable-defaultsMatthew Draper2016-02-2512-21/+49
|\ \ \ | |_|/ |/| | Enable ActionCable routes by default
| * | Only open Action Cable connection if data is being sentJon Moss2016-02-242-6/+6
| | |
| * | Enable Action Cable routes by defaultJon Moss2016-02-2410-15/+43
| | | | | | | | | | | | This also marks Action Cable routes as internal to Rails.
* | | Merge pull request #23862 from prathamesh-sonpatki/test-for-strong-etagRafael França2016-02-241-0/+8
|\ \ \ | |/ / |/| | Added a test for generating Strong ETag
| * | Added a test for generating Strong ETagPrathamesh Sonpatki2016-02-241-0/+8
| | |
* | | Merge pull request #23870 from ↵Jon Moss2016-02-241-0/+17
|\ \ \ | | | | | | | | | | | | | | | | akshaymohite/api-app-debug-exception-response-format-in-doc [ci skip] Need to mention debug_exception_response_format in the api_app documentation.
| * | | [ci skip] Need to mention debug_exception_response_format in the api_app ↵Akshay2016-02-251-0/+17
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | documentation. - #23771 removed the reference to debug_exception_response_format from the api_app documentation. - We need to let users know, they have ability to configure debug_exception_response_format in their development environment. - Added documentation for the same in api_app.md file - Grammar corrections
* | | Merge pull request #23866 from abhishekjain16/documentJon Moss2016-02-242-2/+2
|\ \ \ | | | | | | | | [ci skip] Replace usage of rake routes with rails routes
| * | | [ci skip] Replace usage of rake routes with rails routesAbhishek Jain2016-02-252-2/+2
| | | |
* | | | Ensure suppressor runs before validationseileencodes2016-02-244-2/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I ran into an issue where validations on a suppressed record were causing validation errors to be thrown on a record that was never going to be saved. There isn't a reason to run the validations on a record that doesn't matter. This change moves the suppressor up the chain to be run on the `save` or `save!` in the validations rather than in persistence. The issue with running it when we hit persistence is that the validations are run first, then we hit persistance, and then we hit the suppressor. The suppressor comes first. The change to the test was required since I added the `validates_presence_of` validations. Adding this alone was enough to demonstrate the issue. I added a new test to demonstrate the new behavior is explict.
* | | | Merge branch 'master' into treewipAaron Patterson2016-02-24198-1246/+2139
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (113 commits) remove useless method Updated file documentation [ci skip] changes caching guide to add note on weak etags Don't put config.action_mailer.perform_caching entry twice in development.rb Fix wording and wrong reference Add Ruby formatting to CHANGELOG entry Fix ActionView's cache section reference Do not define methods in the included block Add caching guide in ActionMailer basics Add ActionMailer configuration options Preparing for 5.0.0.beta3 release Update 5.0 release notes Enable tmp_restart plugin for puma Prep release for Rails 5 beta3 [ci skip] Move collection caching changelog entry. Ensure `drop_table` even if tests failure or interrupted :bomb: run the test @rafaelfranca :angry: Remove changelog entry for reverted commit Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip] No need CHANGELOG entry for #23849. ...
| * | | remove useless methodAaron Patterson2016-02-241-2/+0
| | | |
| * | | Merge pull request #23861 from chashmeetsingh/patch-1प्रथमेश Sonpatki2016-02-241-1/+1
| |\ \ \ | | |/ / | |/| | Updated file documentation [ci skip]
| | * | Updated file documentation [ci skip]Chashmeet Singh2016-02-241-1/+1
| |/ /
| * | Merge pull request #23860 from zerothabhishek/weak-etag-guideRafael França2016-02-241-0/+8
| |\ \ | | | | | | | | Changes caching guide to add note on weak etags
| | * | changes caching guide to add note on weak etagsAbhishek Yadav2016-02-241-0/+8
| | | |
| * | | Merge pull request #23859 from ↵Rafael França2016-02-241-8/+2
| |\ \ \ | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/dont-put-perform-caching-config-twice Don't put config.action_mailer.perform_caching entry twice in development.rb
| | * | | Don't put config.action_mailer.perform_caching entry twice in development.rbPrathamesh Sonpatki2016-02-241-8/+2
| | | | |
| * | | | Merge pull request #23857 from st0012/update-documentsRafael França2016-02-244-1/+26
| |\ \ \ \ | | |/ / / | |/| | | [ci skip] Update guide sources for mailer view caching feature
| | * | | Fix wording and wrong referenceStan Lo2016-02-252-2/+2
| | | | |
| | * | | Fix ActionView's cache section referenceStan Lo2016-02-251-1/+1
| | | | |
| | * | | Add caching guide in ActionMailer basicsStan Lo2016-02-251-0/+16
| | | | |
| | * | | Add ActionMailer configuration optionsStan Lo2016-02-251-0/+3
| | | | |
| | * | | Update 5.0 release notesStan Lo2016-02-251-0/+6
| | | | |
| * | | | Merge pull request #23858 from claudiob/fix-aca-readmeClaudio B2016-02-241-4/+5
| |\ \ \ \ | | | | | | | | | | | | Add Ruby formatting to CHANGELOG entry
| | * | | | Add Ruby formatting to CHANGELOG entryclaudiob2016-02-241-4/+5
| |/ / / / | | | | | | | | | | | | | | | [ci skip]
| * | | | Do not define methods in the included blockRafael Mendonça França2016-02-241-293/+289
| | | | | | | | | | | | | | | | | | | | Instance methods can be defined in the module itself
| * | | | Preparing for 5.0.0.beta3 releaseeileencodes2016-02-2410-0/+26
| | | | | | | | | | | | | | | | | | | | Adds changelog headers for beta3 release
| * | | | Enable tmp_restart plugin for pumaRafael Mendonça França2016-02-241-0/+3
| | | | | | | | | | | | | | | | | | | | Fixes #23855
| * | | | Prep release for Rails 5 beta3eileencodes2016-02-2412-45/+45
| |/ / /
| * | | [ci skip] Move collection caching changelog entry.Kasper Timm Hansen2016-02-241-25/+25
| | | | | | | | | | | | | | | | | | | | We changed this in beta2, and only editing the original entry means people can't see that it was significantly changed.
| * | | Merge pull request #23853 from kamipo/ensure_drop_tableRafael França2016-02-241-7/+5
| |\ \ \ | | | | | | | | | | Ensure `drop_table` even if tests failure or interrupted
| | * | | Ensure `drop_table` even if tests failure or interruptedRyuta Kamizono2016-02-241-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was encountered remaining `:binary_testings` table by tests failure. When remaining `:binary_testings` table, never reach `drop_table` due to `create_table` in the test always fails.
| * | | | :bomb: run the test @rafaelfranca :angry:Rafael Mendonça França2016-02-241-1/+1
| |/ / /
| * | | Remove changelog entry for reverted commiteileencodes2016-02-241-12/+0
| | | | | | | | | | | | | | | | | | | | I had to revert changes made for this CHANGELOG entry so this is no longer valid. The change for this entry was removed in 2c02bc0.
| * | | Merge pull request #23850 from prathamesh-sonpatki/changelog-for-23734Rafael França2016-02-241-0/+5
| |\ \ \ | | | | | | | | | | Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip]
| | * | | Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip]Prathamesh Sonpatki2016-02-241-0/+5
| |/ / /
| * | | No need CHANGELOG entry for #23849.Rafael Mendonça França2016-02-241-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It is not a released feature so we don't need to add changelogs to changes on it. [ci skip]
| * | | Make internal class as nodocRafael Mendonça França2016-02-241-2/+2
| | | | | | | | | | | | | | | | Also use the new hash syntax.
| * | | Merge pull request #23616 from piotrj/issue_23609_logger_broadcast_silencingRafael Mendonça França2016-02-244-21/+86
| |\ \ \ | | | | | | | | | | | | | | | Fix logger silencing for broadcasted loggers
| | * | | Fix logger silencing for broadcasted loggersPiotr Jakubowski2016-02-114-21/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix #23609 Commit 629efb6 introduced thread safety to logger silencing but it didn't take into account the fact that the logger can be extended with broadcasting to other logger. This commit introduces local_level to broadcasting Module which enables broadcasted loggers to be properly silenced.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 19:31:06 +0000