aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* fixing invalid yaml [#4418 state:resolved]Aaron Patterson2010-04-161-1/+4
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Revert "Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled"Jeremy Kemper2010-04-162-3/+3
| | | | | | They can be bundled. Just the git repos can't. Use rails/rack-mount for that. This reverts commit ef6cdc974f7c3d98eb0a3ad65761e10600f04110.
* Fix Active Model observer testsJeremy Kemper2010-04-162-2/+4
|
* improve how ActiveRecord::Observer defines callbacks on observed modelsMislav Marohnić2010-04-162-7/+24
| | | | | | | | | | | | | | | | | | Instead of using a single `notify_observers` call for every callback type, each observer now registers a unique callback for itself. Example: before_save :_notify_user_observer_for_before_save def _notify_user_observer_for_before_save observer.update(:before_save, self) end Benefit: "before" callbacks halt when `observer.update` returns false. This way, ActiveRecord observers can prevent records from saving. [#4087 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* ActiveModel::Observing: stop using Observable Ruby module, re-implement ↵Mislav Marohnić2010-04-162-7/+36
| | | | | | | | | `notify_observers` `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord callback chains) and has extra features (like `changed`) that were never used. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* merge callbacks_observers_test.rb into lifecycle_test.rb where other ↵Mislav Marohnić2010-04-162-37/+34
| | | | | | | | observers test reside Benefits: test able to run independently, subclassing instead of changing the original Comment model Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* fix a failure and some warnings on 1.9.2 [#4417 state:resolved]Aaron Patterson2010-04-162-2/+2
| | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* page_cache_extension is delegating to config so no need to deprecateSantiago Pastorino2010-04-161-1/+0
|
* Added test get to js should have a header with content-type text/javascriptSantiago Pastorino2010-04-161-1/+8
|
* Tidy up a bit this test fileSantiago Pastorino2010-04-161-7/+2
|
* Revert "Add test case which check content type when rendering rjs" partial ↵Santiago Pastorino2010-04-161-9/+1
| | | | | | in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag This reverts commit dc251389d1ab4303b80a22642f4241940b73cbe7.
* add missing requires to Rescuable and RouteSet [#4415 state:committed]Mislav Marohnić2010-04-162-0/+2
| | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* Split the observer railtie into two phases.Michael Koziarski2010-04-161-3/+7
| | | | Observers observing models with scopes defined will require the connection to be established.
* Make perform_caching work again, with the tests passing and backward compatibleSantiago Pastorino and Carl Lerche2010-04-156-26/+25
|
* Revert "logger added to the deprecated config accessor" we need a major ↵Santiago Pastorino and Carl Lerche2010-04-151-1/+0
| | | | | | refactor to get this working This reverts commit 68f4e046a7f5db3f7c48a3721bead73a625b6f6e.
* Avoid deprecation warnings and potential TypeErrors [#4404 state:resolved]Nicolas Sanguinetti2010-04-152-3/+3
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* logger added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+1
|
* protected instance variables added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+1
|
* asset and helper path added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+2
|
* page_cache added to the deprecated config accessorSantiago Pastorino2010-04-141-3/+6
|
* Make use of config.perform_cachingSantiago Pastorino2010-04-143-7/+7
|
* action_dispatch/routing/deprecated_mapper needs with_optionsMatthew Rudy Jacobs2010-04-141-0/+1
| | | | | | [#4398 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* utc_offset returns nil for unknown zonesSantiago Pastorino2010-04-142-3/+10
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Test for unknown zone with nil utc_offsetSantiago Pastorino2010-04-141-0/+5
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge branch 'master' of github.com:rails/railsJeremy Kemper2010-04-140-0/+0
|\
| * Merge branch 'master' of github.com:rails/railswycats2010-04-141-2/+2
| |\
| * | Rely specifically on 0.6.0 and add a missing requirewycats2010-04-142-1/+2
| | |
* | | Fix missing dependency on Hash#to_querySantiago Pastorino2010-04-141-0/+1
| |/ |/| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Require rack-mount 0.6.0 since 0.6.1 and later can't be bundledJeremy Kemper2010-04-142-3/+3
|/
* i18n -> AS/i18nXavier Noria2010-04-141-1/+1
|
* adds missing requires for arel and i18n, prevents Arel constant from being ↵Xavier Noria2010-04-141-1/+3
| | | | autoloaded (which was still seen), though it probably hides an issue related to dependencies
* Merge commit 'docrails/master'Xavier Noria2010-04-1414-54/+56
|\
| * fixed typo in RUNNING_UNIT_TESTSDiego Carrion2010-04-141-1/+1
| |
| * Use <plain> instead of <text>Ryan Bigg2010-04-141-6/+12
| |
| * Changes in guide as per Rails 3 featuresAnil Wadghule2010-04-131-15/+15
| |
| * Updated guide to use 'Rails.root.join' to construct pathAnil Wadghule2010-04-131-4/+4
| |
| * Replace 'RAILS_ROOT' to 'Rails.root' and 'RAILS_ENV' to 'Rails.env' in ↵Anil Wadghule2010-04-1211-16/+16
| | | | | | | | significant places.
| * low and behold => lo and behold!Malcolm Locke2010-04-121-1/+1
| |
| * Merge commit 'rohit/master'Xavier Noria2010-04-110-0/+0
| |\
| | * Fixed indentation of database.yml examples.Rohit Arondekar2010-04-101-13/+13
| | |
| * | Fixed indentation of database.yml examples.Rohit Arondekar2010-04-101-13/+13
| |/
| * Merge branch 'master' into docrails_masterwycats2010-04-10111-1892/+1312
| |\
| * | release notes: updates instructions for installing the current betaXavier Noria2010-04-091-5/+1
| | |
| * | Expansion on require method from runtime.rbRyan Bigg2010-04-091-1/+36
| | |
| * | Continue expanding on Bundler.Ryan Bigg2010-04-091-0/+19
| | |
| * | Further work on the bundler section. Almost there now.Ryan Bigg2010-04-091-6/+111
| | |
| * | Mention a way to turn off bundler and begin talking about version_requirementsRyan Bigg2010-04-091-0/+4
| | |
| * | Further expansion into how Bundler loads the gemfile.Ryan Bigg2010-04-091-2/+49
| | |
| * | CL guide: fix font format in rails plugin sectioneparreno2010-04-081-4/+4
| | |
| * | CL guide: convert rails server to shell texteparreno2010-04-081-2/+6
| | |