| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
supercaracal/fix_force_ssl_redirection_flash_error"
This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing
changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3.
|
| |/
|
|
|
|
| |
Thanks for patch @sgrif :trollface:
Closes #18216
|
| | |
|
| |
|
|
| |
Closes #19492 and fixes #19453
|
| |\ |
|
| | |
| |
| |
| |
| | |
Documentation is giving an example that can be replaced by a more dry command.
Give a hint that ids can be used instead of pluck(:id).
|
| |\ \
| | |
| | | |
[skip ci] Fix counter_cache in the Rails Guides
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the AR Associations Guide, this PR fixes:
- The counter_cache declaration is now shown only in the `belongs_to`
association.
- The docs stated that the counter_cache declaration needs to be on the
`has_many` side; now corrected to the `belongs_to` side.
- Split the custom column explanation out to a separate paragraph.
- Simplify the NOTE because it is true both with and without a custom
column name.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
We don't actually need to enumerate the possible types here any more;
that dates back to before e105e599e706780905d4c348394da989de3b200f, when
they were symbols, and indistinguishable from other options.
|
| |\ \ \
| | | |
| | | | |
Speedup String#squish
|
| | | | | |
|
| |\ \ \ \ |
|
| | | | | | |
|
| |/| | | |
| | | | |
| | | | |
| | | | | |
nishantmodak-view_paths
|
| | | | | | |
|
| |\ \ \ \ \ |
|
| | | | | | | |
|
| |/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/mfazekas/rails into mfazekas-action-mailer-async-doc-fixes
Conflicts:
actionmailer/lib/action_mailer/base.rb
|
| | | | | | | |
|
| | |_|/ / /
|/| | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Error message no longer tells you to set the (deprecated) secret_token.
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Update contributing guide
|
| | | | | | | |
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove reference to `register_javascript_expansion` and `register_stylesheet_expansion` from guide [ci skip]
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`register_stylesheet_expansion` from guide [ci skip]
These methods no longer exists.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Speed up Levenshtein by 50% and reduce 97% of memory usage
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Calculating -------------------------------------
each_char 924.000 i/100ms
each_codepoint 1.381k i/100ms
-------------------------------------------------
each_char 9.320k (¡Þ 5.1%) i/s - 47.124k
each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k
Comparison:
each_codepoint: 13857.4 i/s
each_char: 9319.5 i/s - 1.49x slower
The full report can be found here:
https://gist.github.com/yuki24/a80988f35aceac76f1d5
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
[ci skip] remove duplicate doc for current_page?
|
| | | |_|_|/ /
| |/| | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
It was removed long ago: e358b1fce8fdcbac896dde08286be020420e843e.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Missing note on validates_presence_of validation [ci skip]
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Without this note, someone can misunderstand the usage of validates_presence_of method
add missing note for the validates_presence_of
|
| |\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Rename railties/bin to railties/exe to match the new Bundler convention
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
That will match the new Bundler executables convention.
Bundler Blog Post: http://bundler.io/blog/2015/03/20/moving-bins-to-exe.html
Also updated the necessary tests.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix a wrong feature test method name
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
These methods were removed in cb9f7f4 and are no longer methods in the
Rails codebase.
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
[skip ci] primay_key -> primary_key
|
| |/ / / / / / |
|
| |\ \ \ \ \ \ |
|
| | | | | | | | |
|
| |/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
https://github.com/girishso/rails into girishso-belongs_to_primary_key_doc
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
fixes issue #16698
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
JackDanger/danger/use-default-view-pattern-in-docs
[docs] Using the real resolver pattern in docs
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
If someone copies the docs into their app they'll find it simply doesn't
work because the locale pattern doesn't have the same logic. This makes
the doc examples work exactly as written.
[ci skip]
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
into queue-adapter-docs
|
