| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Use frozen string literal in actionmailer/
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \ |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
So releasing 5.1 and 5.0 together won't require manual copy
and paste.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Basically revises the release flow to:
* Update the version in RAILS_VERSION + rake changelog:header
* Run rake all:verify (click around in the booted app)
* If that checks out, run rake release.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix a failued AR test when using OracleAdapter
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| |_|_|/ / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Sort enabled adapter extensions in schema dump
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
The list of enabled adapter extensions in the schema dump isn't
sorted by default, so it may happen that the sorting changes
over time. If you're using a VCS, a change to the sorting results
in a diff without any real change. Sorting the list should solve
this problem.
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|_|_|/
|/| | | | | | | |
Use `TRUE` and `FALSE` boolean literals for MySQL
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Since #29699, abstract boolean serialization has been changed to use
`TRUE` and `FALSE` literals. MySQL also support the literals.
So we can use the abstract boolean serialization even for MySQL.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
y-yagi/use_argument_error_instead_of_own_error_class
Use `ArgumentError` instead of own error class
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If the argument is invalid, I think that it is more intuitive to use
`ArgumentError` than its own error class.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make `type_map` to private because it is only used in the connection adapter
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`type_map` is an internal API and it is only used in the connection
adapter. And also, some type map initializer methods requires passed
`type_map`, but those instances already has `type_map` in itself.
So we don't need explicit passing `type_map` to the initializers.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
removed already
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
`ActionView::Helpers::RecordTagHelper`
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix false positive test related to wrong app root path.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Without setting root config, `config.paths["config/secrets"]`
located in https://github.com/rails/rails/blob/84eb498f84ebc5d1be0b0db6f7bca9da3d679ca6/railties/lib/rails/application.rb#L390
always returned empty list.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Match destroyed_by_association for has_one to has_many
|
| | |_|_|_|_|_|/
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
When a has_many association is destroyed by `dependent: destroy`,
destroyed_by_association is set to the reflection, and this can be
checked in callbacks. This matches that behaviour for has_one
associations.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Use frozen-string-literal in ActiveRecord
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This fixes the following failures.
https://travis-ci.org/rails/rails/jobs/253990014
|
| | |_|_|/ / / /
| |/| | | | | | |
|
| |_|/ / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit b6ad4052d18e4b29b8a092526c2beef013e2bf4f.
This is not something that the majority of Active Record should be
testing or care about. We should look at having fewer places rely on
these details, not make it easier to rely on them.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove log directory in test postprocessing
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
The "log" is directory. So it is necessary to use `FileUtils.rm_rf`.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add jQuery to test/ujs/vendor files for testing rails-ujs
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
... so that we can run most, if not all, of rails-ujs
tests without necessarily requiring an internet connection.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Make `rails yarn:install` ignore dev dependencies
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add Expiry & Purpose to Message Verifier
|
|/ / / / / / |
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Add purpose and expiry to messages encrypted using Message Encryptor
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix `warning: circular argument reference`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This fixes the following warnings:
```
rails/activejob/lib/active_job/test_helper.rb:119: warning: circular argument reference - except
rails/activejob/lib/active_job/test_helper.rb:166: warning: circular argument reference - except
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Create `rails@localhost` user on travis ci
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Looks like that latest CI failure is due to missing `rails@localhost`.
Creating the user may solve the issue.
https://travis-ci.org/rails/rails/jobs/254996063#L831
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
[ci skip]Replace jquery-ujs with rails-ujs
|
|/ / / / |
|
|\ \ \ \
| |_|_|/
|/| | | |
Make preload query to preparable
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently preload query cannot be prepared statements even if
`prepared_statements: true` due to array handler in predicate builder
doesn't support making bind params. This makes preload query to
preparable by don't passing array value if possible.
|
|\ \ \ \
| | | | |
| | | | | |
Fix type casting a time for MariaDB
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Context #24542.
Since 8ebe1f2, it has lost stripping date part for a time value. But I
confirmed it is still needed even if MariaDB 10.2.6 GA.
MariaDB 10.2.6, `prepared_statements: true`:
```
% ARCONN=mysql2 be ruby -w -Itest test/cases/time_precision_test.rb -n test_formatting_time_according_to_precision
Using mysql2
Run options: -n test_formatting_time_according_to_precision --seed 37614
F
Failure:
TimePrecisionTest#test_formatting_time_according_to_precision [test/cases/time_precision_test.rb:53]:
Failed assertion, no message given.
bin/rails test test/cases/time_precision_test.rb:46
Finished in 0.040279s, 24.8268 runs/s, 24.8268 assertions/s.
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
```
|