| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
namespace_ladder can be nil here
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Don't expect the caller of this method to know that the return value has an extra " "
|
|\ \ \ \ \ \ \
| |_|_|_|_|_|/
|/| | | | | | |
Add a changelog entry for #26687 [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
Remove duplicated line
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add a changelog entry for #25227 [ci skip]
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix CI failure caused by #25227 and #25280 were merged at the same time
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/prevent_range_error_for_belongs_to_associations
Prevent `RangeError` for `belongs_to` associations
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently to access `belongs_to` associations raises a `RangeError` if
foreign key attribute has out of range value.
It should return a nil value rather than raising a `RangeError`.
Fixes #20140.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Translate numeric value out of range to the specific exception
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Raise `ActiveRecord::RangeError` when values that executed are out of range.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
y-yagi/run_webpack_command_only_when_webpack_option_is_specified
run `webpack` command only when webpack option is specified
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This fixes the following error when executing rails new command.
```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```
Follow up to #27288
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add a changelog entry for #25451 [ci skip]
|
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When content type header is blank we were raising an exception because
`empty?` was being called on nil.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Idempotent option for after_commit :destroy callback
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Race conditions can occur when an ActiveRecord is destroyed
twice or destroyed and updated. The callbacks should only be
triggered once, similar to a SQL database trigger.
|
| |_|_|/ /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove deprecated `assert_send` from assertion list [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
`assert_send` was deprecated in minitest 5.10.0.
Ref: https://github.com/seattlerb/minitest/commit/f95ef007ec64d956d88fedc37fd2ed7e106b777e
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | | |
Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Enable `block` variable in view
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Remove `block` keyword from reserved method names
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If a Error object was serialized in the database as YAML in the Rails
4.2 version, if we load in the Rails 5.0 version it will miss the
@details instance variable so methods like #clear and #add will start to
fail.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix test breaking error uninitialized constant ActiveRecord::Type::Value
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract notes as binary
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Prevents:
ArgumentError: invalid byte sequence in UTF-8
railties/lib/rails/source_annotation_extractor.rb:115:in `=~'
railties/lib/rails/source_annotation_extractor.rb:115:in `block in extract_annotations_from'
And there's no reason we need to interpret the files as UTF-8
when scanning for annotations.
Applies to Rails 4.2 as well.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Moved database-specific ActiveModel types into ActiveRecord
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ie. DecimalWithoutScale, Text and UnsignedInteger
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Check whether the current attribute being read is aliased or not before reading
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- If aliased, then use the aliased attribute name.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- If aliased, then use the aliased attribute name.
- Fixes #26417.
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Should be sync the `primary_key` definition with actually created
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Actually the `primary_key` definition is not used but the inconsistency
is confusing. Actual definition is `bigint auto_increment PRIMARY KEY`
so `UNSIGNED` and `(8)` is unnecessary.
See also #21607.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
While these method aren't public API, they are a non-trivial internal
API which warrant a bit of explanation.
|