aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-145-2/+47
| | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* Add tests with an explanation of why we're using `_before_type_cast`Sean Griffin2015-01-141-3/+4
| | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0.
* Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-144-3/+13
| | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-144-13/+3
| | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* Go through normal where logic in destroy with lockingSean Griffin2015-01-141-6/+2
| | | | | | Building the Arel AST, and manipulating the relation manually like this is prone to errors and breakage as implementation details change from underneath it.
* Go through normal where logic in destroySean Griffin2015-01-141-9/+1
| | | | | | Building the Arel AST, and manipulating the relation manually like this is prone to errors and breakage as implementation details change from underneath it.
* Don't default to YAML dumping when quoting valuesSean Griffin2015-01-143-11/+13
| | | | | | | This behavior exists only to support fixtures, so we should handle it there. Leaving it in `#quote` can cause very subtle bugs to slip through, by things appearing to work when they should be blowing up loudly, such as #18385.
* Merge pull request #18521 from andrewvida/masterRafael Mendonça França2015-01-141-1/+1
|\ | | | | Correct the views that the mail method sends in API docs.
| * Correct views mail method sends in API docsAndrew Vida2015-01-141-1/+1
| |
* | Merge pull request #18510 from prathamesh-sonpatki/some-more-in-on-githubXavier Noria2015-01-142-2/+2
|\ \ | | | | | | Changed "in GitHub" to "on GitHub" [ci skip]
| * | Changed "in GitHub" to "on GitHub" [ci skip]Prathamesh Sonpatki2015-01-142-2/+2
| | | | | | | | | | | | - Followup of https://github.com/rails/rails/pull/18503.
* | | Merge pull request #18509 from prathamesh-sonpatki/cg-typoRobin Dupret2015-01-141-1/+1
|\ \ \ | |/ / |/| | Fix typo in ActionView CHANGELOG [ci skip]
| * | Fix typo in ActionView CHANGELOG [ci skip]Prathamesh Sonpatki2015-01-141-1/+1
|/ /
* | Merge pull request #18503 from vipulnsward/guides-in-onXavier Noria2015-01-1451-51/+51
|\ \ | | | | | | Changed `IN` to `ON` in markdown renderer condition
| * | - Changed `IN` to `ON` in markdown renderer conditionVipul A M2015-01-1451-51/+51
| | | | | | | | | | | | - Changed `IN` to `ON` in all note sentences in guides.
* | | require 'rails' if not include_all_railties, just as 'rails/all' doesAkira Matsuda2015-01-141-0/+1
| | |
* | | Merge pull request #18500 from nippysaurus/typo_fixYves Senn2015-01-141-1/+1
|\ \ \ | | | | | | | | Grammar: "By default, Rails loads generators from your load path." [ci skip]
| * | | improve grammarMichael Dawson2015-01-141-1/+1
| | | |
* | | | Merge pull request #18504 from vipulnsward/extract-dateYves Senn2015-01-141-3/+4
|\ \ \ \ | | | | | | | | | | Extract `Date` header to string constant in Http Response, similar to other headers
| * | | | Extract `Date` header to string constant in Http Response, similar to other ↵Vipul A M2015-01-141-3/+4
| |/ / / | | | | | | | | | | | | headers
* | | | Merge pull request #18502 from y-yagi/fix_autoloading_guideYves Senn2015-01-141-1/+1
|\ \ \ \ | |/ / / |/| | | fix link in autoloading guide [ci skip]
| * | | fix link in autoloading guide [ci skip]yuuji.yaginuma2015-01-141-1/+1
|/ / /
* | | Merge pull request #18478 from ↵Sean Griffin2015-01-131-1/+2
|\ \ \ | | | | | | | | | | | | | | | | yoshiokatsuneo/active_record_connection_pool_error_disconnect ActiveRecord: On reconnection failure, release only failed connetion.
| * | | ActiveRecord: On reconnection failure, release only failed connetion.Yoshioka Tsuneo2015-01-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | On reconnection failure, all the connection was released. But, it is better to release only failed connection. This patch changes not to release all the connection but release only failed connection.
* | | | Merge pull request #18491 from dreeve/form-for-guide-fix-generated-actionAbdelkader Boudih2015-01-131-2/+2
|\ \ \ \ | | | | | | | | | | Fix form_for guide binding a form to an object. [ci skip]
| * | | | Fix form_for guide binding a form to an object.Derek Reeve2015-01-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The HTML generated using url: { action: :create} will not generate the form action "/articles/create", it should generate the form action "/articles" for a new object.
* | | | | Merge pull request #18489 from Envek/ru_timezonesAndrew White2015-01-132-1/+9
|\ \ \ \ \ | |/ / / / |/| | | | Add missing time zone definitions for Russian Federation
| * | | | Add missing time zone definitions for Russian FederationAndrey Novikov2015-01-132-1/+9
| | | | | | | | | | | | | | | | | | | | Also sync Russian Federation time zones with `zone.tab` file from tzdata version 2014j.
* | | | | Merge pull request #18490 from andreynering/security-guides-remove-resourceAbdelkader Boudih2015-01-131-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Guides: Removing reference to blog that is not updated anymore [ci skip]
| * | | | | Guides: Removing reference to blog that is not updated anymore [ci skip]Andrey Nering2015-01-131-1/+0
| | | | | |
* | | | | | Merge pull request #18476 from Alamoz/scaffold_index_view_grammarDavid Heinemeier Hansson2015-01-131-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Clean up grammar in scaffold index view, by removing the word 'Listing' ...
| * | | | | | Clean up grammar in scaffold index view, by removing the word 'Listing' from ↵Adrien Lamothe2015-01-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | list title.
* | | | | | | Add the `method_source` gem to the default GemfileSean Griffin2015-01-133-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #18473
* | | | | | | Stop promoting rack-cache usage at the moment (not so common or important to ↵David Heinemeier Hansson2015-01-131-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | deserve that billing)
* | | | | | | Show how to change the queuing backend for ActiveJob in productionDavid Heinemeier Hansson2015-01-131-0/+4
| | | | | | |
* | | | | | | Set all asset options togetherDavid Heinemeier Hansson2015-01-131-3/+3
| |_|/ / / / |/| | | | |
* | | | | | Merge pull request #18471 from ahmad-alkheat/masterRafael Mendonça França2015-01-131-0/+6
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Added the SQL equivalent of the find_by method. [ci skip]
| * | | | | Updated active_record_querying.mdAhmad Al-kheat2015-01-121-0/+6
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added the SQL equivalent of the find_by method Update active_record_querying.md Update active_record_querying.md
* | | | | Merge pull request #18480 from karpah/patch-1Claudio B.2015-01-131-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Update asset pipeline guide
| * | | | | Digesting is now enabled by default in developmentRebecca Skinner2015-01-131-1/+1
| |/ / / /
* | | | | Merge pull request #18479 from mechanicles/change-a-to-an-for-htmlClaudio B.2015-01-131-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | Change a to an for HTML word [ci skip]
| * | | | Change a to an for HTML word [ci skip]Santosh Wadghule2015-01-131-1/+1
|/ / / /
* | | | Merge pull request #18439 from mokhan/validates-acceptance-of-arraySean Griffin2015-01-123-2/+18
|\ \ \ \ | | | | | | | | | | allow '1' or true for acceptance validation.
| * | | | allow '1' or true for acceptance validation.mo khan2015-01-103-2/+18
| | | | |
* | | | | Merge pull request #18462 from dmasur/patch-1Yves Senn2015-01-122-1/+10
|\ \ \ \ \ | | | | | | | | | | | | Removing :en in favor of default locale for duration#inspect
| * | | | | Removing :en in favor of I18n.default_locale in duration#inspectDominik Masur2015-01-122-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi there, i have an app without english as available locale. So i got an error when we try to inspect something like 1.day. This is done automatically when we use the dalli cache. I would like to change the :en to ::I18n.default_locale to be sure that this is always constant and is an available locale. Tests are all green with this change. Calculating ------------------------------------- :locale => :en 2.024k i/100ms :locale => ::I18n.default_locale 2.236k i/100ms ------------------------------------------------- :locale => :en 25.758k (±26.3%) i/s - 117.392k :locale => ::I18n.default_locale 26.311k (±18.1%) i/s - 127.452k
* | | | | | Relax Rack dependencySantiago Pastorino2015-01-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rack is very carefully released, we should be able to upgrade minor versions without much effort. We are a bunch of Rails core who are also Rack core members so there won't be any issue with that. And in case there's something wrong, we should fix on both sides. Even though, doesn't seem like we will have a 1.7 version, this will be useful as an example for when we go with Rack 2.0. We should ~> 2.0.
* | | | | | Merge pull request #18466 from davydovanton/error_message_docAbdelkader Boudih2015-01-121-2/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix description for ActiveModel::Errors#generate_message [skip ci]
| * | | | | Fix error messages scope [skip ci]Anton Davydov2015-01-121-2/+2
|/ / / / /
* | | | | Merge pull request #18460 from mechanicles/a-to-an-for-xmlXavier Noria2015-01-121-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Change 'a' to 'an' for 'XML' word [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 14:10:45 +0000