aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Fix the doc on the `IndexDefinition` [ci skip]Ryuta Kamizono2017-04-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since 1a92ae83 all `indexes` methods are under the `SchemaStatements`.
* | | | | | Small grammar fixJon Moss2017-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Small grammar fixesJon Moss2017-04-161-2/+2
| |/ / / / |/| | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #28773 from kamipo/support_descending_indexesMatthew Draper2017-04-178-71/+128
|\ \ \ \ \ | | | | | | | | | | | | Support Descending Indexes for MySQL
| * | | | | Support Descending Indexes for MySQLRyuta Kamizono2017-04-164-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored. See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
| * | | | | Refactor `indexes` things in connection adaptersRyuta Kamizono2017-04-166-67/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use keyword arguments in `IndexDefinition` to ease to ignore unused options and to avoid to initialize incorrect empty value. * Place it in `SchemaStatements` for consistency. * And tiny tweaks.
* | | | | | Bump the bundled GlobalID version.Kasper Timm Hansen2017-04-161-5/+5
| | | | | |
* | | | | | Let run_secrets_generator handle chdir.Kasper Timm Hansen2017-04-161-3/+1
| | | | | |
* | | | | | Merge pull request #28631 from y-yagi/fix_28618Kasper Timm Hansen2017-04-164-18/+31
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Use the config value directly when call `secrets`
| * | | | | Use the config value directly when call `secrets`yuuji.yaginuma2017-04-164-18/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `read_encrypted_secrets` is set with initializer. Therefore if refer to `secrets` in config, `read_encrypted_secrets` is false, so can not get the value of `secrets.yml.enc`. In order to be able to refer to secrets in config, modified to refer to `config.read_encrypted_secrets` when calling `secrets`. Fixes #28618.
* | | | | | Revert parts of cad58fbJon Moss2017-04-151-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changelog links at the top of the components, and lowercased the 'c' in notable changes. Personally, the styling isn't super important to me, but it's what we always done in previous guides, so I figured it's better to keep with what we've always done. [ci skip]
* | | | | | Merge pull request #28638 from bogdanvlviv/prepend_and_append_in_rubyKasper Timm Hansen2017-04-151-2/+2
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Prevent aliases Array#append and Array#prepend
| * | | | | Prevent aliases Array#append and Array#prependbogdanvlviv2017-04-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | https://github.com/ruby/ruby/commit/f57d515d69b7a35477b9ba5d08fe117df1f1e275
* | | | | | Merge pull request #28709 from prathamesh-sonpatki/release-notes-1Kasper Timm Hansen2017-04-151-22/+72
|\ \ \ \ \ \ | | | | | | | | | | | | | | Started adding release notes for Rails 5.1 [ci skip]
| * | | | | | Started adding release notes for Rails 5.1 [ci skip]Prathamesh Sonpatki2017-04-091-22/+72
| | | | | | |
* | | | | | | Merge pull request #28767 from kamipo/rename_to_association_query_valueAndrew White2017-04-153-8/+9
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Rename `association_query_handler.rb` to `association_query_value.rb`
| * | | | | | | Rename `association_query_handler.rb` to `association_query_value.rb`Ryuta Kamizono2017-04-153-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since `AssociationQueryHandler` and `PolymorphicArrayHandler` has removed in #28715, only exists `AssociationQueryValue` and `PolymorphicArrayValue` in these files.
* | | | | | | | Merge pull request #28768 from kamipo/early_return_array_handlerKasper Timm Hansen2017-04-151-4/+3
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Early return in `PredicateBuilder::ArrayHandler`
| * | | | | | | Early return in `PredicateBuilder::ArrayHandler`Ryuta Kamizono2017-04-151-4/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Partitioning to `values` and `nils` is unneeded before early return.
* | | | | | | Merge pull request #28765 from y-yagi/fix_module_name_typoRyuta Kamizono2017-04-151-10/+10
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Fix module name [ci skip]
| * | | | | | Fix module name [ci skip]yuuji.yaginuma2017-04-151-10/+10
|/ / / / / / | | | | | | | | | | | | | | | | | | Replace `FormOptionHelper` to `FormOptionsHelper`.
* | | | | | Merge pull request #28760 from rails/fix-attributes_nameAaron Patterson2017-04-144-12/+30
|\ \ \ \ \ \ | | | | | | | | | | | | | | Move around AR::Dirty and fix _attribute method
| * | | | | | Move around AR::Dirty and fix _attribute methodAaron Patterson2017-04-144-12/+30
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already have a _read_attribute method that can get the value we need from the model. Lets define that method in AM::Dirty and use the existing one from AR::Dirty rather than introducing a new method.
* | | | | | Merge pull request #28661 from ↵Aaron Patterson2017-04-144-4/+35
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | bogdanvlviv/fix-dirty-attributes-if-override-attr_accessor Fix inconsistency with changed attributes when overriding AR attribute reader
| * | | | | | Fix inconsistency with changed attributes when overriding AR attribute readerbogdanvlviv2017-04-124-4/+35
| | | | | | |
* | | | | | | Add additional options to time `change` methodsAndrew White2017-04-146-15/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support `:offset` in `Time#change` and `:zone` or `:offset` in `ActiveSupport::TimeWithZone#change`. Fixes #28723.
* | | | | | | Merge pull request #28715 from ↵Andrew White2017-04-144-60/+32
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/convert_association_queries_to_poro_queries Convert association queries to PORO queries
| * | | | | | | `AssociationQueryValue#queries` returns an array for more concise ↵Ryuta Kamizono2017-04-112-14/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | association handling
| * | | | | | | Convert `PolymorphicArrayValue` to PORO queriesRyuta Kamizono2017-04-093-28/+19
| | | | | | | |
| * | | | | | | Convert `AssociationQueryValue` to PORO queriesRyuta Kamizono2017-04-092-35/+23
| | | | | | | |
* | | | | | | | Merge pull request #28743 from kamipo/add_test_case_for_20802Andrew White2017-04-142-0/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add a test case for #20802
| * | | | | | | | Add a test case for #20802Ryuta Kamizono2017-04-132-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue #20802 has been fixed in cc0b566. Closes #20802.
* | | | | | | | | Merge pull request #28748 from DmytroVasin/rails-ujs-fix-ajax-response-parsingRafael França2017-04-132-3/+31
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | | Fix mistake in JS response parser
| * | | | | | | | Fix mistake in JS response parser:Dmytro Vasin2017-04-132-3/+31
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Restore ability to accept ecmascript JS response should not modify DOM.
* | | | | | | | Merge pull request #28744 from ↵Rafael França2017-04-131-1/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | y-yagi/make_code_statistics_task_handle_system_tests_properly Make code statistics task handle system tests properly
| * | | | | | | | Make code statistics task handle system tests properlyyuuji.yaginuma2017-04-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If it is not added to `TEST_TYPES`, it is not regarded as a test when counting the total count.
* | | | | | | | | Merge pull request #28750 from alexmuller/patch-1Rafael França2017-04-131-2/+2
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | Close form_for tag in FormHelper API docs
| * | | | | | | | Close form_for tag in FormHelper API docsAlex Muller2017-04-131-2/+2
|/ / / / / / / /
* / / / / / / / :scissors:Ryuta Kamizono2017-04-137-7/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Merge pull request #28726 from matthewd/transaction-lockingMatthew Draper2017-04-133-52/+70
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add comprehensive locking around DB transactions
| * | | | | | | Add comprehensive locking around DB transactionsMatthew Draper2017-04-113-52/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Transactional-fixture using tests with racing threads and inter-thread synchronisation inside transaction blocks will now deadlock... but without this, they would just crash. In 5.0, the threads didn't share a connection at all, so it would've worked... but with the main thread inside the fixture transaction, they wouldn't've been able to see each other. So: as far as I can tell, the set of operations this "breaks" never had a compelling use case. Meanwhile, it provides an increased level of coherency to the operational feel of transactional fixtures. If this does cause anyone problems, they're probably best off disabling transactional fixtures on the affected tests, and managing transactions themselves.
* | | | | | | | Merge pull request #28712 from kamipo/tweaks_28678Andrew White2017-04-121-4/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Tweaks #28678
| * | | | | | | | Tweaks #28678Ryuta Kamizono2017-04-091-4/+5
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix the comment on `formatted_version` * Extract `define_params` * Remove duplicated guard clause for `@version`
* | | | | | | | Merge pull request #28740 from matthewd/old-postgresMatthew Draper2017-04-136-22/+33
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | Use a query that's compatible with PostgreSQL 9.2
| * | | | | | | Use a query that's compatible with PostgreSQL 9.2Matthew Draper2017-04-126-22/+33
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, explicitly apply the order: generate_subscripts is unlikely to start returning values out of order, but we should still be clear about what we want.
* | | | | | | Move CHANGELOG.md entry from Active Support to Action PackJon Moss2017-04-112-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Was looking through #28402, and realized the CHANGELOG.md entry is in the wrong place. Sorry we didn't catch this during code review :cry: [ci skip]
* | | | | | | :scissors:Rafael Mendonça França2017-04-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Merge pull request #28731 from y-yagi/fix_rubocop_violationsRafael França2017-04-112-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix rubocop violations
| * | | | | | | Fix rubocop violationsyuuji.yaginuma2017-04-122-2/+2
|/ / / / / / /
* | | | | | | Merge pull request #28402 from jules2689/action-controller-api-base-hooksRafael França2017-04-114-1/+127
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add `action_controller_base` and `action_controller_api` hooks to mitigate differences between them. Also document Active Support on_load hooks
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 08:53:13 +0000