rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \| \| \| \|	This is also a model	Rafael Mendonça França	2014-05-12	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	This model is a model so it should behaves like one	Rafael Mendonça França	2014-05-12	1	-7/+3
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	Merge pull request #15080 from ↵	Rafael Mendonça França	2014-05-12	1	-3/+3
\|\ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	eileencodes/flip-unless-else-conditional-in-halting-method flip conditional to use if/else instead of unless/else
\| * \| \| \| \| \| \| \| \| \| \|	flip conditional to use if/else instead of unless/else	eileencodes	2014-05-12	1	-3/+3
\|/ / / / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use if/else instead of unless/else so conditional reads better.
* \| \| \| \| \| \| \| \| \| \|	Revert "reduce conditionals in url_for"	Aaron Patterson	2014-05-12	1	-6/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This reverts commit 9df60693d77813b362fb528fc62381ac8f1eec12.
* \| \| \| \| \| \| \| \| \| \|	:cry::gun: use an empty hash for magical speed.	Aaron Patterson	2014-05-12	1	-1/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	For some reason, if the hash is empty, we choose "optimized" routes. I am not sure how or why optimized routes differ from regular routes. But, if we make sure the hash is empty, we get a nice speed improvement.
* \| \| \| \| \| \| \| \| \| \|	this class is a model, so it should act like one	Aaron Patterson	2014-05-12	1	-0/+3
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	use the helper method builder to construct helper methods	Aaron Patterson	2014-05-12	3	-59/+118
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	probably should not check in a raise	Aaron Patterson	2014-05-12	1	-1/+0
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	undo optimized calls until the builder object is finished	Aaron Patterson	2014-05-12	3	-41/+23
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	remove suffix from the handler methods	Aaron Patterson	2014-05-12	1	-20/+19
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	push list handling to the builder object	Aaron Patterson	2014-05-12	1	-30/+30
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	push string handling to the builder object	Aaron Patterson	2014-05-12	1	-10/+8
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	push model and class handling to a helper builder object	Aaron Patterson	2014-05-12	1	-36/+48
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	adding a method to handle strings using the same api	Aaron Patterson	2014-05-12	1	-22/+32
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	fix url_for with classes	Aaron Patterson	2014-05-12	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	break each polymorphic type to it's own method	Aaron Patterson	2014-05-12	2	-25/+86
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	remove dead code	Aaron Patterson	2014-05-12	1	-12/+0
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	only test `persisted?` on the record once	Aaron Patterson	2014-05-12	1	-3/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	also avoid the case of calling `persisted?` on something that doesn't respond to it
* \| \| \| \| \| \| \| \| \| \|	only send options if there are any options	Aaron Patterson	2014-05-12	1	-5/+7
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	add a test for the parameters sent to the url helper for new records	Aaron Patterson	2014-05-12	1	-0/+15
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	remove should_pop variable	Aaron Patterson	2014-05-12	1	-4/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	only pop records when we get an array	Aaron Patterson	2014-05-12	1	-6/+7
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	remove unnecessary array allocations	Coraline Ada Ehmke + Aaron Patterson	2014-05-12	1	-5/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	simplified route method name generation	Coraline Ada Ehmke + Aaron Patterson	2014-05-12	2	-27/+19
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	small refactoring	Coraline Ada Ehmke + Aaron Patterson	2014-05-12	1	-6/+2
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	pulling helpermethods up before refactoring	Coraline Ada Ehmke + Aaron Patterson	2014-05-12	1	-20/+46
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	push all is_a tests up, always pass options to the named route	Aaron Patterson	2014-05-12	1	-28/+27
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	pull nil checks up	Aaron Patterson	2014-05-12	1	-3/+5
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	skip another Array is_a check	Aaron Patterson	2014-05-12	1	-4/+6
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	only do the Array is_a check once	Aaron Patterson	2014-05-12	1	-4/+3
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	we always convert this variable to a list, so we can remove the unconversion	Aaron Patterson	2014-05-12	1	-1/+0
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	record as a hash is not possible, so rm branch	Aaron Patterson	2014-05-12	1	-2/+0
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	stop popping in build_named_route_call	Aaron Patterson	2014-05-12	1	-4/+3
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	remove extract_record since we have extracted the list	Aaron Patterson	2014-05-12	1	-12/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	always pass a list to build_named_route_call	Aaron Patterson	2014-05-12	1	-10/+19
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	add a test with three objects	Aaron Patterson	2014-05-12	1	-2/+13
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	add a test for passing two models to the polymorphic_url method	Aaron Patterson	2014-05-12	2	-1/+9
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	typo: resulution -> resolution [ci skip]	Godfrey Chan	2014-05-12	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	reduce conditionals in url_for	Aaron Patterson	2014-05-12	1	-3/+6
\| \|_\|_\|_\|/ / / / / / \|/\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	extract route key translation to a method and reuse it	Aaron Patterson	2014-05-12	1	-17/+14
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	make the module version quack the same as the instance	Aaron Patterson	2014-05-12	1	-3/+10
\| \|_\|_\|_\|_\|/ / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	this way we can stop checking respond_to on every call.
* \| \| \| \| \| \| \| \|	Hash#except is expensive and this is a hotspot, so use a dup + delete	Aaron Patterson	2014-05-12	1	-1/+2
\| \|_\|/ / / / / / \|/\| \| \| \| \| \| \|
* \| \| \| \| \| \| \|	test, use `columns_hash[]` in place of `columns.find {}`.	Yves Senn	2014-05-12	8	-12/+12
\| \|_\|/ / / / / \|/\| \| \| \| \| \|
* \| \| \| \| \| \|	pg, `change_column_default` accepts `[]`. Closes #11586.	Yves Senn	2014-05-12	4	-3/+18
\| \|/ / / / / \|/\| \| \| \| \|
* \| \| \| \| \|	pg, map `char` and `name` types as string. [dark-panda & Yves Senn]	Yves Senn	2014-05-12	3	-0/+33
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Closes #10802.
* \| \| \| \| \|	Merge pull request #13334 from gregolsen/postgresql_infinity	Yves Senn	2014-05-12	3	-3/+30
\|\ \ \ \ \ \ \| \|_\|_\|_\|/ / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	pg, fix Infinity and NaN values conversion. Closes #13334. * rebased * removed guard * inlined guard into case statement
\| * \| \| \| \|	pg, fix Infinity and NaN values conversion.	Innokenty Mihailov	2014-05-12	3	-3/+30
\|/ / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* \| \| \| \|	Merge pull request #10505 from patricksrobertson/bigserial_id_not_identifying_pk	Yves Senn	2014-05-12	3	-1/+33
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Handle other pk types in PostgreSQL gracefully. Closes #10505. - rebased - test slightly modified
\| * \| \| \| \|	Handle other pk types in PostgreSQL gracefully.	Patrick Robertson	2014-05-12	3	-1/+33
\|/ / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.