aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix constant in void context warningsAndrew White2015-05-051-2/+2
|
* Fix URI.escape is obsolete warningsAndrew White2015-05-051-1/+1
|
* Put the assertion arguments in the right orderMatthew Draper2015-05-051-1/+1
|
* Merge pull request #20014 from vngrs/hash_deep_dup_bugMatthew Draper2015-05-052-0/+7
|\ | | | | deep_dup method, remove old key from duplicated hash
| * deep_dup method, remove old key from duplicated hash to avoid unnecessary pairsMehmet Emin İNAÇ2015-05-042-0/+7
| |
* | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-053-4/+24
|\ \ | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-043-4/+24
| | | | | | | | | | | | missing. Fixes #19967
* | | Document inline image mailer preview interceptorAndrew White2015-05-045-56/+83
| | | | | | | | | | | | Explain what the interceptor is used for and how to remove it.
* | | Merge pull request #17632 from eugeneius/schema_cache_dump_connection_poolAaron Patterson2015-05-044-2/+28
|\ \ \ | |_|/ |/| | Apply schema cache dump when creating connections
| * | Apply schema cache dump when creating connectionsEugene Kenny2015-04-294-2/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `db:schema:cache:dump` rake task dumps the database schema structure to `db/schema_cache.dump`. If this file is present, the schema details are loaded into the currently checked out connection by a railtie while Rails is booting, to avoid having to query the database for its schema. The schema cache dump is only applied to the initial connection used to boot the application though; other connections from the same pool are created with an empty schema cache, and still have to load the structure of each table directly from the database. With this change, a copy of the schema cache is associated with the connection pool and applied to connections as they are created.
* | | Merge pull request #20006 from vngrs/refactor_test_order_methodRafael Mendonça França2015-05-041-8/+1
|\ \ \ | | | | | | | | refactor ActiveSupport::TestCase.test_order method with memoization
| * | | refactor ActiveSupport::TestCase.test_order method with memoizationMehmet Emin İNAÇ2015-05-041-8/+1
| | | |
* | | | Merge pull request #20010 from sikachu/silence-ambiguous-first-argumentMatthew Draper2015-05-041-1/+1
|\ \ \ \ | | | | | | | | | | Silence ambiguous first argument warning
| * | | | Silence ambiguous first argument warningPrem Sichanugrist2015-05-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator
* | | | | Enhance the "Passing Variables to Translations" partEvan Prothro2015-05-041-19/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add more information about passing variables to translation definitions and also merge this part with the "Interpolation" one as the latter didn't bring any new information. Moreover, each one was referring to the other for further information. [ci skip]
* | | | | Updates various prose to the i18n guideEvan Prothro2015-05-041-49/+57
|/ / / / | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #20007 from zamith/validation-custom-messagesRafael Mendonça França2015-05-042-1/+7
|\ \ \ \ | | | | | | | | | | Adds/Corrects use case for adding an error message
| * | | | Adds/Corrects use case for adding an error messageZamith2015-05-042-1/+7
| |/ / / | | | | | | | | | | | | | | | | I believe this is a use case that was supposed to be supported, and it's a small fix.
* / / / Tiny documentation edits [ci skip]Robin Dupret2015-05-043-17/+20
|/ / / | | | | | | | | | | | | | | | * Fix a few typos * Wrap lines to 80 chars * Use `+` instead of `<tt>`
* | | Fix railties configuration testAndrew White2015-05-041-2/+2
| | |
* | | Add support for inline images to mailer previewsAndrew White2015-05-044-9/+64
| | | | | | | | | | | | | | | Use a preview interceptor to search for inline cid: urls in src attributes and convert them to data urls.
* | | Improve display of attachment names in mailer previewsAndrew White2015-05-041-1/+1
| | | | | | | | | | | | | | | Display attachment filenames as a comma separated list rather than showing the inspect output for the array.
* | | Fix mailer previews with attachmentsAndrew White2015-05-044-7/+206
| | | | | | | | | | | | | | | | | | Use the mail gem's own API to locate the correct part. Fixes #14435.
* | | Merge pull request #19981 from kbrock/custom_auth_htmlRafael Mendonça França2015-05-033-20/+22
|\ \ \ | | | | | | | | Give authentication methods the ability to customize response message.
| * | | Give authentication methods the ability to customize response message.Keenan Brock2015-05-033-20/+22
| | | | | | | | | | | | | | | | Digest allowed the messages. Add the same feature to basic and token
* | | | Merge pull request #18561 from nerdcave/serialization-methods-optionRafael Mendonça França2015-05-033-10/+22
|\ \ \ \ | |/ / / |/| | | method_missing fallback for ActiveModel::Serialization methods option
| * | | ensure `method_missing` called for non-existing methods passed toJay Elaraj2015-04-283-10/+22
| | | | | | | | | | | | | | | | `ActiveModel::Serialization#serializable_hash`
* | | | Fix generator testsRafael Mendonça França2015-05-031-1/+1
| | | | | | | | | | | | | | | | In my machine the output is different
* | | | Remove unneeded base fileRafael Mendonça França2015-05-032-57/+53
| | | | | | | | | | | | | | | | We are only using for one test class
* | | | Remove unused private classesRafael Mendonça França2015-05-032-186/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The usage of these classes where removed at 8017e6af31caa58a58787274ff0ca01397219e49. cc @arthurnn @senny
* | | | Merge pull request #20002 from kamipo/more_exercise_create_index_sql_testsRafael Mendonça França2015-05-034-8/+83
|\ \ \ \ | | | | | | | | | | More exercise the create index sql tests
| * | | | More exercise the create index sql testsRyuta Kamizono2015-05-044-4/+79
| | | | |
| * | | | Do not use options that does not supportRyuta Kamizono2015-05-041-4/+4
|/ / / / | | | | | | | | | | | | | | | | MySQL does not support partial index. And, the create index algorithm in create table can not be specified.
* | | | Merge pull request #19093 from ↵Rafael Mendonça França2015-05-034-3/+38
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | remomueller/fix-actionmailer-preview-links-on-subdirectories Mailer preview now uses `url_for` to fix links to emails for apps runnin...
| * | | | Mailer preview now uses `url_for` to fix links to emails for apps running on ↵Remo Mueller2015-04-304-3/+38
| | | | | | | | | | | | | | | | | | | | a subdirectory, closes #19092.
* | | | | Merge pull request #19976 from prathamesh-sonpatki/rm-assignsRafael Mendonça França2015-05-032-5/+4
|\ \ \ \ \ | | | | | | | | | | | | Removed `assigns` from functional_test templates
| * | | | | Removed `assigns` from functional_test templatesPrathamesh Sonpatki2015-05-022-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Based on DHH's suggestion about deprecating `assigns` in https://github.com/rails/rails/pull/18305#issuecomment-68605166.
* | | | | | Merge pull request #19994 from kamipo/dump_indexes_in_create_tableRafael Mendonça França2015-05-033-16/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Dump indexes in `create_table` instead of `add_index`
| * | | | | | Dump indexes in `create_table` instead of `add_index`Ryuta Kamizono2015-05-033-16/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the adapter supports indexes in create table, generated SQL is slightly more efficient.
* | | | | | | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-032-0/+15
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Actionview image tag size option override
| * | | | | | | image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-242-0/+15
| | | | | | | |
* | | | | | | | Merge pull request #17824 from ↵Rafael Mendonça França2015-05-034-5/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | yuki24/change-record-not-saved-and-not-destroyed-to-include-error-msg AR::RecordNotSaved & RecordNotDestroyed from save!/destroy! should include an error message
| * | | | | | | | AR::RecordNotSaved & RecordNotDestroyed should include an error messageYuki Nishijima2015-05-014-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `AR::Base.save!` or `AR::Base.destroy!` is called and an exception is raised, the exception doesn't have any error message or has a weird message like `#<FailedBulb:0x0000000907b4b8>`. Give a better message so we can easily understand why it's failing to save/destroy.
* | | | | | | | | Merge pull request #17569 from kamipo/dump_table_optionsRafael Mendonça França2015-05-036-0/+106
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Correctly dump `:options` on `create_table` for MySQL
| * | | | | | | | | Correctly dump `:options` on `create_table` for MySQLRyuta Kamizono2015-05-036-0/+106
| | | | | | | | | |
* | | | | | | | | | Merge pull request #19987 from kamipo/move_postgresql_specific_schemaRafael Mendonça França2015-05-032-14/+11
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Move PostgreSQL specific schema to postgresql_specific_schema.rb
| * | | | | | | | | | Move PostgreSQL specific schema to postgresql_specific_schema.rbRyuta Kamizono2015-05-032-14/+11
| | |_|_|/ / / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #19978 from kamipo/collation_option_support_for_postgresqlRafael Mendonça França2015-05-0310-32/+116
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | PostgreSQL: `:collation` support for string and text columns
| * | | | | | | | | | PostgreSQL: `:collation` support for string and text columnsRyuta Kamizono2015-05-044-3/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :foos do |t| t.string :string_en, collation: 'en_US.UTF-8' t.text :text_ja, collation: 'ja_JP.UTF-8' end
| * | | | | | | | | | Move the collation handling code from the MySQL adapter to common classesRyuta Kamizono2015-05-047-29/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some databases like MySQL allow defining collation charset for specific columns.