aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Removed dom_assertion method since it created bugs.Timm2014-06-161-8/+6
|
* Fixed uninitialized constant ActionView::HTML error entered after recent git ↵Timm2014-06-161-1/+0
| | | | rebase.
* Removed a bunch of duplicated tests in SanitizeHelperTest.Timm2014-06-161-37/+0
|
* Removed unnecessary documentation in DomAssertions.Timm2014-06-161-7/+0
|
* Removed case statement in equal_children? used child.element? instead.Timm2014-06-161-2/+1
|
* Reworked some internal documentation for equal_attribute_nodes?.Timm2014-06-161-3/+2
|
* Changed attributes_are_equal? to equal_attribute_nodes? which takes ↵Timm2014-06-161-7/+8
| | | | attribute_nodes instead of nodes.
* Removed html_strings variable, no splat operator needed.Timm2014-06-161-4/+4
|
* Changed back to =~ or == comparison in HTMLSelector filter.Timm2014-06-161-2/+2
|
* Simplified the removal of xpaths in remove_xpaths. Added more tests for ↵Timm2014-06-162-9/+12
| | | | remove_xpaths.
* Fixed: added apostrophe to possessive noun.Timm2014-06-161-1/+1
|
* Extracted: create Regexp from match_with and use =~ to compare instead of ↵Timm2014-06-161-1/+2
| | | | checking .is_a? Regexp every time through the loop.
* Changed conditional check in filter. Removed weird comments.Timm2014-06-161-7/+3
|
* Moved: initial assignment of @selector_is_second_argument is now in initialize.Timm2014-06-161-1/+1
|
* Changed: using duck typing instead of requiring subclasses of Node and NodeSet.Timm2014-06-161-4/+1
|
* Renamed: HTMLSelector css_selector to selector.Timm2014-06-161-7/+7
|
* Removed unnecessary lines from HTMLSelector initialize.Timm2014-06-161-3/+1
|
* Changed: put selector extraction into selector_from, which is renamed to ↵Timm2014-06-161-4/+4
| | | | extract_selector.
* Changed: HTMLSelector comparisons renamed to equality_tests.Timm2014-06-161-9/+6
|
* Changed: removed @selected and @page variables from HTMLSelector since one ↵Timm2014-06-161-10/+8
| | | | method used them. Passed the values directly to there instead.
* Changed: return early from compare_doms if the two doms don't have the same ↵Timm2014-06-161-0/+2
| | | | number of children.
* Renamed: remove_xpaths tests no longer prefixed with sanitizer.Timm2014-06-161-6/+6
|
* Changed: remove_xpaths called with String returns String, while called with ↵Timm2014-06-162-2/+13
| | | | Loofah fragment returns Loofah fragment. Added tests for this.
* Fixed: spelling mistake in SanitizeHelperTest.Timm2014-06-161-3/+3
|
* Removed duplication in assert_dom_equal and assert_dom_not_equal.Timm2014-06-161-9/+6
|
* Changed wording of missing selector argument exception message in css_select.Timm2014-06-161-1/+1
|
* Reworked root and selector conditional assignment in css_select.Timm2014-06-161-5/+2
|
* Added related Nokogiri issue link to tests that fail with unknown encoding ↵Timm2014-06-162-6/+6
| | | | ASCII-8BIT.
* Moved Action Pack changelog message to Action View. Clarified Dom and ↵Timm2014-06-161-0/+14
| | | | Selector assertions changes in there.
* Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions.Timm2014-06-161-1/+1
|
* Removed :nodoc: from PermitScrubber.Timm2014-06-161-1/+0
|
* Reworked documentation for PermitScrubber and TargetScrubber.Timm2014-06-161-2/+33
|
* Fixed: spelling error.Timm2014-06-161-1/+1
|
* Initialized tags and attributes to nil.Timm2014-06-161-0/+4
|
* Refactored scrub to keep_node? instead of scrub_node calling it. Also added ↵Timm2014-06-161-6/+5
| | | | ability to stop traversing by returning STOP from scrub_node.
* Changed PermitScrubber to be even more extensible. Updated TargetScrubber to ↵Timm2014-06-161-39/+40
| | | | be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
* Changed PermitScrubbers documentation to list override points for ↵Timm2014-06-161-12/+15
| | | | subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
* Already killed off LinkScrubber. Changed it instead to be TargetScrubber, ↵Timm2014-06-162-9/+20
| | | | which is more general, while still allowing maximum code reuse.
* Added LinkScrubber to remove duplication in LinkSanitizer. As such made ↵Timm2014-06-162-11/+22
| | | | PermitScrubber easier to subclass.
* Changed FullSanitizer sanitize to use tap method instead of temporary variable.Timm2014-06-161-3/+3
|
* Extracted the common xpaths to remove into XPATHS_TO_REMOVE.Timm2014-06-161-2/+4
|
* Refactored remove_xpaths to use duck typing and read better.Timm2014-06-161-4/+5
|
* Changed explanation for no duck typing of custom scrubbers.Timm2014-06-161-1/+2
|
* Added correct requires in html-scanner tests. Sanitizers are not based on ↵Timm2014-06-167-330/+6
| | | | html-scanner anymore, so sanitizer_test.rb is removed.
* Require ActionView::Assertions in ActionController test_case.rb.Timm2014-06-161-0/+1
|
* Marked test_feed_xhtml as pending. See description in the test.Timm2014-06-161-0/+1
|
* Removed copyright notice since we aren't relying on html-scanner anymore.Timm2014-06-161-5/+0
|
* Removed require for active_support/core_ext/object/inclusion since in? isn't ↵Timm2014-06-161-2/+0
| | | | used anywhere.
* Moved Dom and Selector assertions from ActionDispatch to ActionView.Timm2014-06-1611-545/+557
|
* Fixed: assert_select_encoded finds the right content. No longer uses a ↵Timm2014-06-162-14/+11
| | | | <encoded> wrapper. Updated tests to reflect this.