Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | Constrained to 80 chars per line | Jason Noble | 2011-12-03 | 1 | -173/+367 | |
| | | | | | | ||||||
| * | | | | | Update layouts and rendering guide javascript_include_tag to bring it in ↵ | Ryan Bigg | 2011-12-04 | 1 | -5/+42 | |
| |/ / / / | | | | | | | | | | | | | | | | line with Rails 3.1 | |||||
* | | | | | Merge pull request #3850 from carlosantoniodasilva/readonly-attributes | José Valim | 2011-12-04 | 1 | -1/+2 | |
|\ \ \ \ \ | |_|_|/ / |/| | | | | Refactor readonly attributes conditional | |||||
| * | | | | Refactor readonly attributes conditional | Carlos Antonio da Silva | 2011-12-04 | 1 | -1/+2 | |
|/ / / / | ||||||
* | | | | Merge pull request #3848 from arunagw/sqlite3_bump | Xavier Noria | 2011-12-04 | 2 | -2/+2 | |
|\ \ \ \ | |_|/ / |/| | | | SQlite3 Bump | |||||
| * | | | SQlite3 Bump | Arun Agrawal | 2011-12-04 | 2 | -2/+2 | |
|/ / / | ||||||
* | | | Add missing require | Jon Leighton | 2011-12-03 | 1 | -0/+2 | |
| | | | ||||||
* | | | Enable postgres on the CI :heart: :beer: :sparkles: | Jon Leighton | 2011-12-03 | 2 | -1/+2 | |
| | | | ||||||
* | | | Avoid postgres 9.X syntax | Jon Leighton | 2011-12-03 | 1 | -1/+5 | |
| | | | ||||||
* | | | Fix #3837. | Jon Leighton | 2011-12-03 | 2 | -11/+17 | |
| | | | | | | | | | | | | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access. | |||||
* | | | removes the convenience instance version of AR::Base.silence_auto_explain | Xavier Noria | 2011-12-03 | 5 | -99/+85 | |
| | | | | | | | | | | | | | | | | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled. | |||||
* | | | Merge pull request #3820 from jaylevitt/nested_loading_through_assoc | Jon Leighton | 2011-12-03 | 2 | -1/+36 | |
|\ \ \ | | | | | | | | | reintroduce patch from #726 to handle nested eager loading via associations | |||||
| * | | | reintroduce patch from #726 to handle nested eager loading via associations | Jay Levitt | 2011-11-30 | 2 | -1/+36 | |
| | | | | ||||||
* | | | | Merge pull request #3833 from kennyj/fix_3678-3 | Jon Leighton | 2011-12-03 | 1 | -3/+8 | |
|\ \ \ \ | | | | | | | | | | | Use show create table (fix 3678: third time). | |||||
| * | | | | Use show create table. | kennyj | 2011-12-03 | 1 | -3/+8 | |
| | | | | | ||||||
* | | | | | Merge pull request #3842 from arunagw/app_gen_test | José Valim | 2011-12-03 | 1 | -3/+3 | |
|\ \ \ \ \ | | | | | | | | | | | | | App Generator test | |||||
| * | | | | | Simplifying test in app/generator | Arun Agrawal | 2011-12-03 | 1 | -3/+3 | |
| | | | | | | ||||||
* | | | | | | Fix failing cascade exception. | José Valim | 2011-12-03 | 3 | -2/+12 | |
|/ / / / / | ||||||
* | | | | | Restore performance of ERB::Util.html_escape | Jon Jensen | 2011-12-03 | 2 | -7/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert html_escape to do a single gsub again, but add the "n" flag (no language, i.e. not multi-byte) to protect against XSS via invalid utf8 Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | | | | fix a typo in query guide | Vijay Dev | 2011-12-03 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | yield > block.call | Xavier Noria | 2011-12-02 | 1 | -3/+3 | |
| | | | | | ||||||
* | | | | | two small details from the previous patch | Xavier Noria | 2011-12-02 | 2 | -2/+2 | |
| | | | | | ||||||
* | | | | | implements AR::Base(.|#)silence_auto_explain | Xavier Noria | 2011-12-02 | 5 | -61/+142 | |
| | | | | | ||||||
* | | | | | fix typo in railties changelog | Vijay Dev | 2011-12-03 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | revises Enumerable#pluck in AS guide | Vijay Dev | 2011-12-02 | 1 | -1/+1 | |
| |_|/ / |/| | | | ||||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-12-02 | 5 | -11/+14 | |
|\ \ \ \ | ||||||
| * | | | | Added doc about pluck for active_support core ext | Arun Agrawal | 2011-12-02 | 1 | -0/+10 | |
| | | | | | ||||||
| * | | | | [Docs] Information about ActionDispatch::DebugExceptions in rake task | Arun Agrawal | 2011-12-02 | 1 | -0/+1 | |
| | | | | | ||||||
| * | | | | Adding information about ActionDispatch::DebugExceptions | Arun Agrawal | 2011-12-02 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | [docs] removed last-modifed line from examples | Richard Hulse | 2011-12-02 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is no longer best-practice. ref: http://stackoverflow.com/questions/8344186/rails-3-1-on-apache-pagespeed-says-specify-cache-validator-when-using-asset-p/8348385#8348385 | |||||
| * | | | | fixed finger-dyslexia in active_support core extensions guide | Tim Sjoberg | 2011-12-01 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | typo in the performance testing rails guide | Leandro Santos | 2011-11-30 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | rephrase doc on explain threshold | Vijay Dev | 2011-12-02 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #3832 from arunagw/indentation | Xavier Noria | 2011-12-02 | 1 | -1/+1 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | indentation fix warning | |||||
| * | | | | indentation fix warning | Arun Agrawal | 2011-12-02 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | revises some details in the previous explain patch | Xavier Noria | 2011-12-02 | 3 | -4/+4 | |
| | | | | ||||||
* | | | | Revert "Roflscaling!" (for now) | Jon Leighton | 2011-12-02 | 2 | -8/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.) | |||||
* | | | | implements automatic EXPLAIN logging for slow queries | Xavier Noria | 2011-12-02 | 18 | -96/+354 | |
| | | | | ||||||
* | | | | Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH* | David Heinemeier Hansson | 2011-12-02 | 3 | -3/+19 | |
| | | | | ||||||
* | | | | Try to play nice with plugins doing monkey patches. | José Valim | 2011-12-02 | 1 | -0/+5 | |
| | | | | ||||||
* | | | | Fewer string allocations in attribute method | Jon Leighton | 2011-12-01 | 1 | -4/+4 | |
| | | | | ||||||
* | | | | Roflscaling! | Jon Leighton | 2011-12-01 | 2 | -11/+8 | |
| | | | | | | | | | | | | | | | | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster. | |||||
* | | | | Create method with known identifier then alias into place. | Jon Leighton | 2011-12-01 | 2 | -25/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.) | |||||
* | | | | Remove some unnecessary code etc | Jon Leighton | 2011-12-01 | 2 | -26/+11 | |
| | | | | ||||||
* | | | | Add test for read_attribute(:id) with non-standard PK. | Jon Leighton | 2011-12-01 | 3 | -4/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go. | |||||
* | | | | Remove the need for type_cast_attribute. | Jon Leighton | 2011-12-01 | 5 | -43/+52 | |
| | | | | | | | | | | | | | | | | This is good because it reduces duplication. | |||||
* | | | | Fix up test altering global state that was causing me grief | Jon Leighton | 2011-12-01 | 1 | -2/+4 | |
| | | | | ||||||
* | | | | Get rid of the underscore versions of attribute methods! | Jon Leighton | 2011-12-01 | 6 | -6/+40 | |
| | | | | | | | | | | | | | | | | This makes me happy! | |||||
* | | | | Don't rely on underscore-prefixed attribute methods. | Jon Leighton | 2011-12-01 | 3 | -48/+80 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o | |||||
* | | | | Remove unnecessary *args | Jon Leighton | 2011-12-01 | 1 | -2/+2 | |
| | | | |