| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Similar to the channel streaming side, these values must be strings for
ActionCable to behave as expected. The conversion will allow users to
send string-convertible values and get the expected behavior.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActionCable does some things behind the scenes that expects these
"broadcasting"s or "channel"s to be strings. However it's not
immediately obvious that the value must be a string. So adding this
conversion ensures things work as expected.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
use `app:update` instead of deprecated `rails:update` [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
`rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Add small Action Cable documentation fixes
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
* Fix typos/grammar errors
* Make capitalization/naming consistent
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This guides were pointing to this command `rails app:update`, which I
tried to run, but it didnt worked. I think the right command is `rails
rails:update` instead. Also thats the name of the rake task.
Also I removed the `Rake` word from the title, as we run it using
`rails` bin now.
cc @kaspth
[skip ci]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
remove rack cors initializer when updating
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use app namespace for framework tasks
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
(e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip]Add info for specifying logger in different envrionments.
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
refer 2dc3e81aea8dbc, 56ca2061df83a3
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Create tmp folder if not present
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
All Apps may not have a tmp folder
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Specify plaform: :mri for byebug
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.
Close #23717
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
we have started to render something, at the very beginning.
This helps to easily identify queries from controller vs views
Fixes #23710
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
lifo/same-redis-connection-for-subscription-and-broadcast
Always use redis_connector to create redis connections
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
broadcasts
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
[close #23681] Use puma 3.0.0+
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Changed debugging rails app doc.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Changed location for specifying logger.
[Prajakta, thiagoaugusto]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
fix typo in pull_request_template [ci skip]
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | | |
[skip ci]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If we're deferring one, we should defer the other too.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add `issue_template.md`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This appears to be a new feature of GitHub.
See these links for more details:
- https://github.com/dear-github/dear-github/issues/125
- https://github.com/owncloud/core/issues/new
- https://github.com/blog/2111-issue-and-pull-request-templates
[ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Enable HSTS with IncludeSubdomains header by default for new apps
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- For old apps which are not setting any value for hsts[:subdomains],
a deprecation warning will be shown saying that hsts[:subdomains] will
be turned on by default in Rails 5.1. Currently it will be set to
false for backward compatibility.
- Adjusted tests to reflect this change.
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- We will remove the initializer for old apps which are migrated to
Rails 5 so that they are not affected by this breaking change.
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
subdomains
- We will reuse config.ssl_options for setting the HSTS settings.
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases
2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing.
That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted.
Yes, many developers forget to add subdomains=true by default, believe me :)
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
y-yagi/correctly_check_ApplicationRecord_in_mountable_engine
correctly check `ApplicationRecord` is exist in moutable engine
|
| | |_|_|_|_|_|_|/
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | | |
Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
jrafanie/fix_uniqueness_validation_on_after_create
Fix uniqueness validation with an after_create hook.
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
record.id_was is nil in after_create/after_save, so we should use
id in these cases.
While this logic feels incomplete, the existing update_record uses the same
logic:
https://github.com/rails/rails/blob/2fda4e0874a97a76107ab9e88305169f2c625933/activerecord/lib/active_record/relation.rb#L83
This logic was originally added for a similar problem:
updates not working with after_create hook.
See: 482f8c15b1d699c95bfbc3d836f674a09c0d9031
Followup to #23581
Fixes #23844
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
This reverts commit 22db455dbe9c26fe6d723cac0758705d9943ea4b, reversing
changes made to 40be61dfda1e04c3f306022a40370862e3a2ce39.
This finishes off what I meant to do in 6216a092ccfe6422f113db906a52fe8ffdafdbe6.
|