Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | `index_exists?` with `:name` checks specified columns. | Yves Senn | 2014-08-13 | 3 | -7/+30 | |
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper] The column check was embodied in the defaul index name. If the :name option was used, the specified columns were not verified at all. Given: ``` assert connection.index_exists?(table_name, :foo_id, :name => :index_testings_on_yo_momma) ``` That index could have been defined on any field, not necessarily on `:foo_id`. | |||||
* | | | | | :bomb: | Rafael Mendonça França | 2014-08-12 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #16476 from akshay-vishnoi/doc-changes | Rafael Mendonça França | 2014-08-12 | 2 | -2/+2 | |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] use "based on" or "based off of" | |||||
| * | | | | | use 'based on' instead of 'based off' [ci skip] | Akshay Vishnoi | 2014-08-12 | 2 | -2/+2 | |
| |/ / / / | ||||||
* / / / / | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 9 | -8/+12 | |
|/ / / / | ||||||
* | | | | CHANGELOG entry for TestCase.i_suck_and_my_tests_are_order_dependent! fix | Akira Matsuda | 2014-08-12 | 1 | -0/+6 | |
| | | | | ||||||
* | | | | Remove old setup from AS test case | Carlos Antonio da Silva | 2014-08-12 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | | | | | | | This was added back in Rails 3 on c4a6109286909c394e8c5bfc471a1eb9de245d2b, and is not being used anymore. | |||||
* | | | | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 8 | -4/+34 | |
| | | | | | | | | | | | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | |||||
* | | | | Merge pull request #16472 from y-yagi/patch-1 | Carlos Antonio da Silva | 2014-08-12 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | [ci skip] Fix broken url in plugins guide | |||||
| * | | | | [ci skip] Fix broken url in plugins guide | yuuji.yaginuma | 2014-08-12 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | Merge pull request #16456 from ↵ | Santiago Pastorino | 2014-08-11 | 2 | -1/+8 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | lsylvester/improve-active-record-error-message-on-update_columns-for-destroyed-records Change error message in update_columns for destroyed objects | |||||
| * | | | | update error message to reflect that the record could have been destroyed | lsylvester | 2014-08-11 | 2 | -1/+8 | |
|/ / / / | ||||||
* | | | | Merge pull request #16300 from ↵ | Godfrey Chan | 2014-08-10 | 1 | -1/+5 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | vast/mention-changes-to-nil-serialization-in-upgrading-from-3.2 Mention changes to `nil` handling in serialized attributes | |||||
| * | | | | [ci skip] Clarify the "Serialized Attributes" section | Vasily Polovnyov | 2014-07-26 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Mention that the change in nil handling for serialized attributes affects custom coders. | |||||
| * | | | | [ci skip] Mention the change in nil handling for serialized attributes | Vasily Polovnyov | 2014-07-26 | 1 | -0/+3 | |
| | | | | | | | | | | | | | | | | | | | | in "Upgrading from Rails 3.2 to Rails 4.0" | |||||
* | | | | | Merge pull request #16453 from reshleman/re-cleanup-guides-guidelines | Zachary Scott | 2014-08-10 | 1 | -12/+10 | |
|\ \ \ \ \ | | | | | | | | | | | | | Cleanup Guides Guidelines [ci skip] | |||||
| * | | | | | Cleanup Guides Guidelines [ci skip] | Robert Eshleman | 2014-08-10 | 1 | -12/+10 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | * Copy editing for clarity in several locations * Rename "Titles" section to "Headings" * Fix incorrect anchor in link to API Documentation Guidelines for filenames | |||||
* | | | | | Merge pull request #16451 from y-yagi/patch-2 | Zachary Scott | 2014-08-10 | 1 | -2/+2 | |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] Fix sample code in engines guide | |||||
| * | | | | | [ci skip] Fix sample code in engines guide | yuuji.yaginuma | 2014-08-10 | 1 | -2/+2 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #16441 from ↵ | Santiago Pastorino | 2014-08-09 | 1 | -4/+4 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | tomkadwill/activerecord_associations_options_param [ci skip] Changed options to +options+ for rdoc | |||||
| * | | | | | [ci skip] Changed options to +options+ for rdoc | Tom Kadwill | 2014-08-09 | 1 | -4/+4 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #16440 from tgxworld/pass_log_in_block | Santiago Pastorino | 2014-08-09 | 1 | -4/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Pass block for logging. | |||||
| * | | | | | | Pass block for logging. | Guo Xiang Tan | 2014-08-09 | 1 | -4/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance. | |||||
* | | | | | | | Merge pull request #16439 from voxxit/patch-1 | Santiago Pastorino | 2014-08-09 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Using delegated connection method | |||||
| * | | | | | | | Using delegated connection method | Joshua Delsman | 2014-08-08 | 1 | -1/+1 | |
| | |/ / / / / | |/| | | | | | ||||||
* | | | | | | | Merge pull request #16443 from duccioarmenise/patch-1 | Vijay Dev | 2014-08-09 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Rails Tutorial link updated | |||||
| * | | | | | | Update README.md | Duccio Armenise | 2014-08-09 | 1 | -1/+1 | |
|/ / / / / / | | | | | | | | | | | | | Ruby on Rails Tutorial link updated. | |||||
* | | | | | | Merge pull request #16437 from mscoutermarsh/master | Richard Schneeman | 2014-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Docs: grammar fix for fetch. [ci skip] | |||||
| * | | | | | | Docs: grammar fix for fetch. [ci skip] | Mike Coutermarsh | 2014-08-08 | 1 | -1/+1 | |
|/ / / / / / | ||||||
* | | | | | | Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option" | Santiago Pastorino | 2014-08-08 | 5 | -38/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!! | |||||
* | | | | | | Merge pull request #16434 from strzalek/cookies-digest-config-option | Santiago Pastorino | 2014-08-08 | 5 | -3/+38 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Add digest config option for SignedCookiesJar | |||||
| * | | | | | | Return preconfigured AS::MessageVerifier | Łukasz Strzałkowski | 2014-08-08 | 2 | -1/+7 | |
| | | | | | | | ||||||
| * | | | | | | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-08 | 4 | -2/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256' | |||||
* | | | | | | | save a hash allocation per request. | Aaron Patterson | 2014-08-08 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | add a test for prepending SCRIPT_NAME to generated urls | Aaron Patterson | 2014-08-08 | 1 | -0/+88 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #16429 from arunagw/aa-build-fix-gemfile-spring | Santiago Pastorino | 2014-08-08 | 3 | -8/+13 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Fixes test for Gemfile entry changes | |||||
| * | | | | | | Fixes test for Gemfile entry changes | Arun Agrawal | 2014-08-08 | 3 | -8/+13 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | Broken by fbe38c9e9d4fe9f82518e8ffc1d757459b0c5f1c | |||||
* | | | | | | Merge pull request #16427 from ryandao/full_stack_source_extract | Guillermo Iguaran | 2014-08-08 | 9 | -69/+114 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Full stack source extract | |||||
| * | | | | | | Update actionpack CHANGELOG | Ryan Dao | 2014-08-08 | 1 | -0/+5 | |
| | | | | | | | ||||||
| * | | | | | | Retrieve source code for the entire stack trace | Ryan Dao | 2014-08-08 | 8 | -69/+109 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors. | |||||
* | | | | | | Merge pull request #16426 from tgxworld/fix_false_positive | Santiago Pastorino | 2014-08-08 | 1 | -4/+5 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fixes to TestCaseTest. | |||||
| * | | | | | | Fixes to TestCaseTest. | Guo Xiang Tan | 2014-08-08 | 1 | -4/+5 | |
| |/ / / / / | ||||||
* | | | | | | Fix the #const_regexp's documentation [ci skip] | Robin Dupret | 2014-08-08 | 1 | -3/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally introduced in f9086d63, the documentation of this method is wrong as #const_regexp returns a string to easy the interpolation inside regular expressions. | |||||
* | | | | | | Merge pull request #16430 from guillermo/patch-1 | Rafael Mendonça França | 2014-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix typo in plugins doc | |||||
| * | | | | | | Fix typo in plugins doc | Guillermo Álvarez Fernández | 2014-08-08 | 1 | -1/+1 | |
|/ / / / / / | ||||||
* | | | | | | Merge pull request #16428 from tomkadwill/activerecord_associations_name_param | Carlos Antonio da Silva | 2014-08-08 | 1 | -4/+4 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | [ci skip] Changed 'first argument' to '+name+ argument' | |||||
| * | | | | | [ci skip] Changed 'first argument' to '+name+ argument' | Tom Kadwill | 2014-08-08 | 1 | -4/+4 | |
|/ / / / / | ||||||
* | | | | | Rephrase how we explain RecordInvalid exception in the context of | Zachary Scott | 2014-08-07 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `#create!` regarding validations in contrast to the behavior of `#create`. Also describe creating multiple objects using an array of hashes as the +attributes+ parameter. [ci skip] /cc #16384 | |||||
* | | | | | Merge pull request #16384 from tomkadwill/improved_create_documentation | Zachary Scott | 2014-08-07 | 1 | -2/+5 | |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] Added +object+ and +attributes+ to create! description for rdoc | |||||
| * | | | | | [ci skip] Updated create! documentation description and added +attributes+ ↵ | Tom Kadwill | 2014-08-07 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | for rdoc |