aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* We don't need that initializer in testsPiotr Sarnacki2010-09-031-4/+0
|
* Ensure that url_helpers included after application's ones have higher priorityPiotr Sarnacki2010-09-031-0/+15
|
* Add mounted_helpers to routesPiotr Sarnacki2010-09-039-98/+192
| | | | | | | | | | | | | | | | mounted_helpers are a bit similar to url_helpers. They're automatically included in controllers for Rails.application and each of mounted Engines. Mounted helper allows to call url_for and named helpers for given application. Given Blog::Engine mounted as blog_engine, there are 2 helpers defined: app and blog_engine. You can call routes for app and engine using those helpers: app.root_url app.url_for(:controller => "foo") blog_engine.posts_path blog_engine.url_for(@post)
* Routes refactoring:Piotr Sarnacki2010-09-035-60/+83
| | | | | | | * added more tests for prefix generation * fixed bug with generating host for both prefix and url * refactored url_for method * organized tests for prefix generation
* Use new url_for API instead of including routes.url_helpersPiotr Sarnacki2010-09-032-9/+4
|
* Ensure that env is always available in controllersPiotr Sarnacki2010-09-032-2/+6
|
* Extended url_for to handle specifying which router should be used.Piotr Sarnacki2010-09-037-80/+136
| | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index"
* Added some more tests for url generation between Engine and ApplicationPiotr Sarnacki2010-09-033-18/+59
|
* Get rid of :skip_prefix options in routesPiotr Sarnacki2010-09-033-15/+8
|
* Refactored tests for prefix generation and added test for url generation in ↵Piotr Sarnacki2010-09-031-11/+32
| | | | regular class with default_url_options[:script_name] set
* New way of generating urls for Application from Engine.Piotr Sarnacki2010-09-037-15/+30
| | | | | | | | | It's based specifying application's script_name with: Rails.application.default_url_options = {:script_name => "/foo"} default_url_options method is delegated to routes. If router used to generate url differs from the router passed via env it always overwrites :script_name with this value.
* Fix url generation for mounted EnginePiotr Sarnacki2010-09-033-9/+117
| | | | | | | | | I added integration tests for generating urls in Engine and application and tweaked Engines to fully cooparate with new router's behavior: * Rails.application now sets ORIGINAL_SCRIPT_NAME * Rails.application also sets its routes as env['action_dispatch.parent_routes'] * Engine implements responds_to? class method to respond to all the instance methods, like #routes
* Allow to generate Application routes inside EnginePiotr Sarnacki2010-09-033-7/+26
| | | | | | This requires knowledge about original SCRIPT_NAME and the parent router. It should be pass through the env as ORIGIAL_SCRIPT_NAME and action_dispatch.parent_routes
* Pass routes via env['action_dispatch.routes'], it's needed by routes to ↵Piotr Sarnacki2010-09-033-3/+31
| | | | determine if it should generate prefix for mounted apps
* Use env['action_dispatch.routes'] to determine if we should generate prefix ↵Piotr Sarnacki2010-09-035-8/+151
| | | | | | | | | | or not. This technique is here to allow using routes from Engine in Application and vice versa. When using Engine routes inside Application it should generate prefix based on mount point. When using Engine routes inside Engine it should use env['SCRIPT_NAME']. In any other case it should generate prefix as env should not be even available.
* Move singleton pattern to Railtie and remove Engine::Configurable and ↵Piotr Sarnacki2010-09-039-107/+62
| | | | Application::Configurable in favor of unified Railtie::Configurable
* Removed most of deprecated stuff from Application and EnginePiotr Sarnacki2010-09-036-123/+0
|
* Allow Engines loading its own environment file from config/environmentsPiotr Sarnacki2010-09-037-18/+50
|
* Ensure that plugins are not loaded twicePiotr Sarnacki2010-09-032-0/+47
|
* We don't need to add railties initlaizers in Application as there is already ↵Piotr Sarnacki2010-09-031-1/+0
| | | | done in Engine and it's called with super
* Removed ActionDispatch::Static, but left empty MiddlewareStack to unify app ↵Piotr Sarnacki2010-09-036-45/+10
| | | | method between Engine and Application
* We don't need to overwrite default paths in testsPiotr Sarnacki2010-09-031-5/+3
|
* Ensure that init.rb is evaled in context of EnginePiotr Sarnacki2010-09-031-1/+1
|
* Engine can now serve files with ActionDispatch::StaticPiotr Sarnacki2010-09-035-5/+41
|
* Engine sets routes as default rack endpoint if no endpoint was givenPiotr Sarnacki2010-09-033-7/+30
|
* Delegate non existing class methods to instance for EnginePiotr Sarnacki2010-09-032-5/+6
|
* Added TODO for evaling init.rb in context of EnginePiotr Sarnacki2010-09-031-0/+2
|
* Gather initializers from railties in engines to get rid of additional ↵Piotr Sarnacki2010-09-032-10/+7
| | | | looping through initializers
* Engine can now load its own pluginsPiotr Sarnacki2010-09-036-16/+62
|
* Made Engine valid rack app with its own middleware stackPiotr Sarnacki2010-09-036-4/+65
|
* require 'active_support/dependencies' in action_dispatch/middleware/stackPiotr Sarnacki2010-09-031-0/+1
|
* too many people are looking for the 2.3 guides, put by now a link at the top ↵Xavier Noria2010-09-031-2/+6
| | | | of the home, and add the Rails version in the main header
* Merge remote branch 'docrails/master'Xavier Noria2010-09-037-24/+30
|\
| * Add missing lookup keys for error messagesAndrew White2010-09-011-0/+6
| |
| * Use new finders syntax in docs.Emilio Tagua2010-09-015-23/+23
| |
| * fix typo(?)Akira Matsuda2010-09-011-1/+1
| |
* | A few schema changes for the SQL Server adapter.Ken Collins2010-09-031-3/+3
| | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* | Revert "Setup explicit requires for files with exceptions. Removed them from ↵José Valim2010-09-0227-32/+16
| | | | | | | | | | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
* | Add two integration tests for GeneratedAttribute missing type error. [#5461 ↵rohit2010-09-022-0/+12
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | Output a friendly message when no type given for GeneratedAttribute [#5461 ↵rohit2010-09-021-0/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | Failing test for GeneratedAttribute [#5461 state:open]rohit2010-09-021-0/+12
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | ActiveModel#to_xml fix (renamed parameter).Andreas Garnæs2010-09-022-1/+7
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | Remove deprecated dispatch test.José Valim2010-09-021-7/+0
| |
* | Ensure routes are loaded only after the initialization process finishes, ↵José Valim2010-09-023-5/+24
| | | | | | | | ensuring all configuration options were applied.
* | Setup explicit requires for files with exceptions. Removed them from ↵Łukasz Strzałkowski2010-09-0227-16/+32
| | | | | | | | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com>
* | Cleaned up autoload definitions.Łukasz Strzałkowski2010-09-021-15/+20
| | | | | | | | | | | | Now it's more transparent, and readable Signed-off-by: José Valim <jose.valim@gmail.com>
* | Removing RJS hackThiago Pradi2010-09-022-6/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | Removing unnecessary code from render_testThiago Pradi2010-09-021-2/+0
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | Removing unnecessary codeThiago Pradi2010-09-021-7/+0
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | remove use of echo [#4410 state:resolved]Greg Hazel2010-09-021-2/+2
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>