aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #7571 from arunagw/warning_removed_shadowingRafael Mendonça França2012-09-091-1/+1
|\ \ \ \ | |/ / / |/| | | removed warning: shadowing outer local variable
| * | | removed warning: shadowing outer local variableArun Agrawal2012-09-091-1/+1
| | |/ | |/|
* | | Merge pull request #7548 from ernie/missing-attributes-query-fixCarlos Antonio da Silva2012-09-083-1/+8
|\ \ \ | | | | | | | | Raise MissingAttributeError on query methods
| * | | Raise MissingAttributeError on query methodsErnie Miller2012-09-083-1/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
* | | Merge pull request #7577 from frodsan/fix_ap_responseRafael Mendonça França2012-09-081-25/+32
|\ \ \ | | | | | | | | set default_headers to nil after use it to avoid order dependent tests
| * | | set default_headers to nil after use it to avoid order dependent testsFrancesco Rodriguez2012-09-081-25/+32
| | | |
* | | | Merge pull request #7576 from ↵Rafael Mendonça França2012-09-081-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | prijutme4ty/fix_require_necessary_for_generating_guides Fixed missing require
| * | | | Fixed missing requireIlya Vorontsov2012-09-081-0/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Missing require caused fail of guide generation (in action_dispatch/http/mime_type, line 295, undefined method `ends_with` for "to_ary":String) With this fix guides were normally generated
* | | | Merge pull request #7574 from frodsan/chlog_arRafael Mendonça França2012-09-081-8/+9
|\ \ \ \ | |/ / / |/| | | improve AR CHANGELOG [ci skip]
| * | | improve AR CHANGELOG [ci skip]Francesco Rodriguez2012-09-081-8/+9
|/ / /
* | | Tidy up excerpt separator logic a bitCarlos Antonio da Silva2012-09-081-17/+11
| | |
* | | Improve latest AR and AP changelog entriesCarlos Antonio da Silva2012-09-082-2/+10
| | |
* | | Refactor some date helpers to use merge!Carlos Antonio da Silva2012-09-081-5/+9
| | | | | | | | | | | | Also just set the hash value instead of merging when it's only one key.
* | | Refactor nested attributes limit logic to lookup :limit option only onceCarlos Antonio da Silva2012-09-081-11/+12
| | |
* | | Merge pull request #7189 from GCorbel/excerpt_with_separationCarlos Antonio da Silva2012-09-083-11/+64
|\ \ \ | | | | | | | | Add a separator option for the excerpt function.
| * | | Add a separation option for the excerpt functionGuirec Corbel2012-09-083-11/+64
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | The separation option enable to keep entire words, lines or anything. To split by line, like github, we can set the separation option as \n. To split by word, like google, we can set the separation option as " ". The radius option represent the number of lines or words we want to have in the result. The default behaviour is the same. If we don't set the separation option, it split the text any where.
* | | Merge pull request #7566 from etehtsea/schema-new-hashCarlos Antonio da Silva2012-09-085-61/+63
|\ \ \ | | | | | | | | Dump schema using new style hash
| * | | Dump schema using new style hashKonstantin Shabanov2012-09-085-61/+63
| |/ /
* | | Merge pull request #7568 from alup/masterCarlos Antonio da Silva2012-09-082-0/+29
|\ \ \ | |/ / |/| | Tests for session handling
| * | Add integration tests for reset_session in cookie storeAndreas Loupasakis2012-09-081-0/+20
| | |
| * | Add test for clear in ActionDispatch::Request::SessionAndreas Loupasakis2012-09-081-0/+9
|/ /
* | Add changelog entry for #7545: map interval with precision to stringCarlos Antonio da Silva2012-09-071-0/+2
| | | | | | | | | | Merged in f41dba27a411fe3e2ddeb8d9ab6856dbb23acd02 [ci skip]
* | Merge pull request #7545 from senny/7518_postgres_type_detectionAaron Patterson2012-09-073-3/+6
|\ \ | | | | | | postgres, map scaled intervals to string datatype
| * | postgres, map scaled intervals to string datatype (#7518)Yves Senn2012-09-063-3/+6
| | |
* | | Minor refactor in ActiveRecord#initialize_dupCarlos Antonio da Silva2012-09-073-12/+4
| | | | | | | | | | | | | | | | | | * There is no need to delete the primary key from cloned attributes, since it sets the same pk to nil afterwards. * Check for empty? instead of any? to run initialize callbacks.
* | | Merge pull request #7565 from guilleiguaran/dalli-session-storeCarlos Antonio da Silva2012-09-071-2/+6
|\ \ \ | | | | | | | | Improve error message for memcache session store when dalli isn't loaded
| * | | Improve error message for memcache session store when dalli isn't loaded in appGuillermo Iguaran2012-09-071-2/+6
| | | |
* | | | create a transaction object and point AR objects at that object during aAaron Patterson2012-09-074-12/+55
| | | | | | | | | | | | | | | | transaction.
* | | | Fix AS tests due to builder change with nil values / empty stringsCarlos Antonio da Silva2012-09-071-2/+2
| | | | | | | | | | | | | | | | | | | | Check 0180e090ab6cbe66f7b521a0c03e278a0463accd for more reasoning about that.
* | | | Fix AR tests due to builder change with nil values / empty stringsCarlos Antonio da Silva2012-09-071-6/+6
| | | | | | | | | | | | | | | | | | | | Check 0180e090ab6cbe66f7b521a0c03e278a0463accd for more reasoning about that.
* | | | Bump builder dependencies in Active Model and Action PackCarlos Antonio da Silva2012-09-072-2/+2
| | | |
* | | | Update Active Model xml serialization test to reflect a change in builderCarlos Antonio da Silva2012-09-072-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to a change in builder, nil values and empty strings now generates closed tags, so instead of this: <pseudonyms nil=\"true\"></pseudonyms> It generates this: <pseudonyms nil=\"true\"/> Document this change in Rails so that people can track it down easily if necessary.
* | | | Use merge! to merge additional options onto default optionsCarlos Antonio da Silva2012-09-071-4/+3
| | | |
* | | | Fix Active Support changelog formatting [ci skip]Carlos Antonio da Silva2012-09-071-2/+2
| | | |
* | | | Remove 3.2.x entries from Active Record changelog [ci skip]Carlos Antonio da Silva2012-09-071-100/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since 810a50dacf9ddddc1d59c1cb350e8ce785c8bf85, the new policy is to keep old changelogs in their own branches, to avoid manual syncing across different branches. Please check that commit for more reasoning about the new policy.
* | | | Add Changelog entry for #4976: fix eager load associations without pks [ci skip]Carlos Antonio da Silva2012-09-071-0/+2
| | | |
* | | | Add Changelog entry for #7560: deprecate #filter in AS::Callbacks [ci skip]Carlos Antonio da Silva2012-09-071-0/+22
| | | |
* | | | Merge pull request #7552 from guilleiguaran/dalli-session-storeSantiago Pastorino2012-09-073-13/+8
|\| | | | | | | | | | | Use Dalli for memcache session store
| * | | Dalli doesn't support autoloading of unloaded classesGuillermo Iguaran2012-09-061-5/+0
| | | |
| * | | Use dalli 2.2.1 or prior to fix failing tests in memcache session storeGuillermo Iguaran2012-09-061-1/+1
| | | |
| * | | More fixes for action pack tests with Dalli.Arun Agrawal2012-09-061-3/+3
| | | |
| * | | Let's run action pack tests with DalliArun Agrawal2012-09-061-4/+4
| | | | | | | | | | | | | | | | There is no memcache gem left in repo.
* | | | Merge pull request #7560 from bogdan/deprecate_callbacks_monkeypatchJosé Valim2012-09-073-8/+9
|\ \ \ \ | | | | | | | | | | AS::Callbacks: deprecate monkey patch of object callbacks
| * | | | AS::Callbacks: deprecate monkey patch of object callbacksBogdan Gusiev2012-09-073-8/+9
|/ / / /
* | | | Merge pull request #4976 from kreynolds/fix_eager_without_pkeyJon Leighton2012-09-072-1/+9
|\ \ \ \ | | | | | | | | | | Fix eagerly loading associations without primary keys
| * | | | Change JoinPart test from an integration to a unit testKelley Reynolds2012-07-052-13/+8
| | | | |
| * | | | Fix eagerly loading associations without primary keysKelley Reynolds2012-02-092-1/+14
| | | | |
* | | | | fix tests on Ruby 2.0.0Aaron Patterson2012-09-061-1/+1
| |/ / / |/| | |
* | | | Merge pull request #7549 from asanghi/masterCarlos Antonio da Silva2012-09-061-1/+1
|\ \ \ \ | | | | | | | | | | Fix Changelog example in Action Mailer [ci skip]
| * | | | fix bad changelog exampleAditya Sanghi2012-09-071-1/+1
| | | | |