| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
fix bad test by making number that fits for integer
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
PR https://github.com/rails/rails/pull/10566 had to be reverted
because after applying the fix test
"test_raise_record_not_found_error_when_invalid_ids_are_passed"
started failing.
In this test invalid_id is being assigned a really large number
which was causing following failure when PR #10566 was applied.
```
RangeError: bignum too big to convert into `long long'
SELECT `interests`.* FROM `interests`
WHERE `interests`.`man_id` = ? AND `interests`.`id` = ?
LIMIT 1 [["man_id", 970345987], ["id", 2394823094892348920348523452345]]
```
This test is not failing in master because when test code
`man.interests.find(invalid_id)` is executed then interests
are fully loaded in memory and no database query is executed.
After PR #10566 was merged then test code
`man.interests.find(invalid_id)` started executing sql query
and hence the error.
In case someone is wondering why the second part of query is not
failing, then that's because the actual query does not require
any variable substituation where the number is large. In that
case the sql generate is following.
```
SELECT `interests`.* FROM `interests`
WHERE `interests`.`man_id` = ? AND `interests`.`id`
IN (8432342, 2390102913, 2453245234523452) [["man_id", 970345987]]
```
|
| |\ \
| | |
| | |
| | |
| | | |
jetthoughts/10428_bug_with_config_assets_precompile
#10428: Added tests for config.assets.precompile
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Tests for bug in sprocket-rails:
do not use value of configuration options
which changed after environment loaded
|
| |\ \ \
| | | |
| | | | |
Fix documents for create_join_table [ci skip]
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Saying gemcutter => rubygems [ci skip]
|
| | | |_|/
| |/| | |
|
| |\ \ \ \
| |/ / /
|/| | | |
fix the path of action view from actionpack/lib/action_view => actionvie...
|
| |/ / /
| | |
| | |
| | | |
actionview/lib/action_view
|
| |\ \ \
| |/ /
|/| | |
Backport #11033 to master
|
| |/ /
| |
| |
| |
| |
| | |
Since docrails as moved from lifo/docrails to rails/docrails we have
to ask for commit rights or submit patches directly to the rails
repository
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously when app was mounted as following:
class Foo
def call(env)
[200, {}, [env['PATH_INFO']]]
end
end
RackMountRailsBug::Application.routes.draw do
mount RackTest.new => "/foo"
end
trailing slash was removed from PATH_INFO. For example requesting
GET /foo/bar/
on routes defined above would result in a response containing "/foo/bar"
instead of "/foo/bar/".
This commit fixes the issue.
(closes #3215)
|
| |\ \
| | |
| | |
| | |
| | | |
senny/10936_inspect_does_not_crash_without_connection
`inspect` for AR model classes does not initiate a new connection.
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
mjtko/fix/backtrace-silencer-noise-with-multiple-silencers
Fix BacktraceSilencer#noise when multiple silencers are configured
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous implementation of BacktraceSilencer#noise did not
work correctly if more than one silencer was configured --
specifically, it would only return noise which was matched by all
silencers.
The new implementation is such that anything that has been matched by
silencers is removed from the backtrace using Array#- (array
difference), ie. we now return all elements within a backtrace that
have been matched by any silencer (and are thus removed by #silence).
Fixes #11030.
|
| |\ \ \
| |/ /
|/| | |
Extract ActionView to separate directory
|
| | | |
| | |
| | |
| | | |
Now if somebody by mistake will remove malformed files test will raise error.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
They were moved to actionview/ and are not used in actionpack
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
ActionView still relies on ActionPack in some of the tests.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ /
| |
| |
| |
| | |
This commit creates structure for Action View gem and is first of a
series of commits extracting Action View from Action Pack.
|
| |\ \
| | |
| | | |
ActiveModel::Model inclusion chain backward compatibility
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
Fix 3 typos in Configuration guide
|
| |/ / |
|
| |\ \
| |/
|/| |
Fix name of nested attributes option include_id
|
| |/
|
| |
The option to disable including a hidden ID field on a `fields_for` nested association was incorrectly documented as `hidden_field_id` instead of `include_id`
|
| | |
|
| |\
| |
| | |
Handle single quotes in PostgreSQL default column values
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
PostgreSQL escapes single quotes by using an additional single quote.
When Rails queries the column information, PostgreSQL returns the
default values with the escaped single quotes.
#extract_value_from_default now converts these to one single quote each.
Fixes #10881.
|
| | |
| |
| |
| | |
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 2b817a5e89ac0e7aeb894a40ae7151a0cf3cef16, reversing
changes made to 353a398bee68c5ea99d76ac7601de0a5fef6f4a5.
Conflicts:
activerecord/CHANGELOG.md
Reason: the build broke
|
