| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
|\ \
| | |
| | | |
log the sql that is actually sent to the database
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If I have a query that produces sql
`WHERE "users"."name" = 'a b'` then in the log all the
whitespace is being squeezed. So the sql that is printed in the
log is `WHERE "users"."name" = 'a b'`.
This can be confusing. This commit fixes it by ensuring that
whitespace is not squeezed.
fixes #10982
|
| | |
|
|\ \
| | |
| | | |
Remove duplicate letter 'a'. [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Fixed ActiveModel::Model's inclusion chain
|
|/ / |
|
|\ \
| | |
| | | |
do not load all child records for inverse case
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
currently `post.comments.find(Comment.first.id)` would load all
comments for the given post to set the inverse association.
This has a huge performance penalty. Because if post has 100k
records and all these 100k records would be loaded in memory
even though the comment id was supplied.
Fix is to use in-memory records only if loaded? is true. Otherwise
load the records using full sql.
Fixes #10509
|
|\ \
| | |
| | | |
Fix some activerecord changelog code to be displayed properly as code [ci skip]
|
| | |
| | |
| | |
| | | |
b483a0d2a75b
|
|/ /
| |
| |
| | |
the changelog.
|
|\ \
| | |
| | | |
Add respond_with location option to docs Edit
|
|/ / |
|
|\ \
| | |
| | | |
`CollectionProxy#include?` returns `true` and `false` as documented.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Removing a repetitive comment and a deprecation warning.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
The comment on the +env_config+ method is repetitive, likely to get
outdated, and provides no useful information which cannot be gleamed
from the code. I'm therefore removing it. I'm also refactoring the check
for the presence of a secret_token in the configuration.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 7098d6c9ab28931acc9562a00037567609f9e529, reversing
changes made to 9ec2e2ee91568af24e09760a6de2890b89c33f56.
This make some tests fail /cc @wangjohn
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Creating a class to build the default middleware stack.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
A lot of logic for building the default middleware stack is currently
kept in Application class, but this can be encapsulated and made more
modular by being moved to its own class. Also refactored a couple of the
helper methods.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Removing a repetitive comment and refactoring the Application class in Railties
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Railties.
The comment on the +env_config+ method is repetitive, likely to get
outdated, and provides no useful information which cannot be gleamed
from the code. I'm therefore removing it. I'm also refactoring the check
for the presence of a secret_token in the configuration.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Calls to the application constant have been refactored
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Rails.application when drawing routes and creating other configurations
on the application.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* master: (142 commits)
Use Colspan in th Tags
Added test for link_to_unless to make sure the result consistency.
Escape the string even when the condition of link_to_unless is not satisfied.
Add CHANGELOG entry for #10969
Use a case insensitive URI Regexp for #asset_path
collection tags accept html attributes as the last element of collection
Rewind StringIO instances before be parsed again
Use xml instead already parsed xml
Updated the doc for const_regexp [ci skip]
Make test name descriptive and add reference to original regression commit
fixture setup does not rely on `AR::Base.configurations`.
regression test + mysql2 adapter raises correct error if conn is closed.
cleanup, remove trailing whitespace from AR changelog
'json' gem is no more required under JRuby
fix typos
Fix AS changelog [ci skip]
Update the HTML boolean attributes per the HTML 5.1 spec
Changing const_regexp to check for constant name.
valid_app_const? -> valid_const?
Add CHANGELOG entry for #10740
...
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Use Colspan in th Tags
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it?
Change repetitive th tags to use colspan attribute
Update CHANGELOG.md
Update CHANGELOG.md
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
Always escape the result of link_to_unless method
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
correct documentation about active_record.default_timezone
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| |\ \ \ \ \ \ \
| | |_|_|/ / / /
| |/| | | | | | |
Use a case insensitive URI Regexp for #asset_path
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Context: https://gist.github.com/radar/5793814
The `URI_REGEXP` that various AssetUrl helpers use is currently case
sensitive when checking for a URI scheme. This means if you try to pass
a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with
a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`.
URLs are case insensitive, so this regexp should be as well.
Signed-off-by: David Celis <me@davidcel.is>
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
collection tags accept html attributes as the last element of collection
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | |_|_|/ / /
| |/| | | | | |
Fix build after #10727
|
| | | | | | | |
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Fix XmlMini different backends tests
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Updated the doc for const_regexp [ci skip]
|
| |/ / / / / / |
|