aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | `#not_in` with a range should respect proper precedenceSean Griffin2014-10-242-7/+7
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, doing ```ruby relation[:id].not_eq(4).and(relation[:id].not_in(1..3)) ``` will generate ```sql "id" != 4 AND "id" < 1 OR "id" > 3 ``` Which would incorrectly include records with an id of 4, as the OR statement has higher precidence than the AND statement. The `or` method on `Node` properly groups the statement in parenthesis.
* | Merge pull request #332 from sgrif/sg-include-in-test-coverageSean Griffin2014-10-241-8/+201
|\ \ | | | | | | Improve test coverage for `#in` and `#not_in`
| * | Improve test coverage for `#in` and `#not_in`Sean Griffin2014-10-241-8/+201
| |/ | | | | | | | | | | These methods are going to go through some heavy refactoring, and moving logic around. This adds missing tests for each of the branches on the predicate.
* | Merge pull request #330 from sgrif/sg-binary-node-hash-equalitySean Griffin2014-10-242-1/+27
|\ \ | |/ |/| Binary nodes should not generate the same hash as nodes of other classes
| * Binary nodes should not generate the same hash as nodes of other classesSean Griffin2014-10-242-1/+27
|/
* Merge pull request #326 from claudiob/reuse-maybe-visitRafael Mendonça França2014-10-231-3/+3
|\ | | | | Completes 08e6491 in reusing `maybe_visit`
| * Completes 08e6491 in reusing `maybe_visit`claudiob2014-10-231-3/+3
|/ | | | | | | | | :sweat: I don't know why the tests did not fail, but to keep the same syntax as before, `collector =` is required. Maybe `visit` changes `collector` in-place, so the result is the same, but since I'm not sure about the side effects, I think this PR is needed to. Sorry! :sweat:
* Merge pull request #325 from claudiob/reuse-maybe-visit-methodRafael Mendonça França2014-10-232-18/+4
|\ | | | | Reuse `maybe_visit` method
| * Reuse `maybe_visit` methodclaudiob2014-10-232-18/+4
|/ | | | | This commit simply removes duplicated code by reusing the existing `maybe_visit` method.
* Merge pull request #324 from vipulnsward/cteMatthew Draper2014-10-241-1/+1
|\ | | | | `Expresssions` => `Expressions`
| * `Expresssions` => `Expressions` [ci skip]Vipul A M2014-10-241-1/+1
|/
* Merge pull request #318 from tamird/match-escapeMatthew Draper2014-09-266-20/+60
|\ | | | | {Matches,DoesNotMatch} support the ESCAPE clause
| * {Matches,DoesNotMatch} support the ESCAPE clauseTamir Duberstein2014-09-256-20/+60
|/
* move the dispatch table to be per-instanceAaron Patterson2014-09-228-26/+38
| | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future.
* connections should cache these values, so remove the cache in arelAaron Patterson2014-09-221-4/+3
|
* Merge pull request #317 from dimko/patch-2Rafael Mendonça França2014-09-171-1/+1
|\ | | | | Fix set visiting spec
| * Fix set visiting specDimko2014-09-171-1/+1
|/
* Merge pull request #167 from pparidans/informix-v9-supportRafael Mendonça França2014-09-172-7/+7
|\ | | | | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'
| * Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'Pierre Paridans2014-09-162-7/+7
| | | | | | | | Still supported in versions 10+
* | Merge pull request #137 from dimko/visit_setRafael Mendonça França2014-09-175-0/+16
|\ \ | |/ |/| Added a visitor for Set objects
| * added a visitor for Set objectsDimko2012-09-185-0/+16
| |
* | Merge pull request #316 from vipulnsward/remove-aliasMatthew Draper2014-09-171-1/+1
|\ \ | | | | | | Remove unused @alias, being referenced in hashing.
| * | Remove unused @alias, being referenced in hashing.Vipul A M2014-09-161-1/+1
|/ /
* | Build on ruby-headMatthew Draper2014-09-171-1/+3
| |
* | Merge pull request #315 from tamird/129Matthew Draper2014-09-172-1/+11
|\ \ | | | | | | Wrap group_by sql with a subquery for limiting rows in Oracle.
| * | Wrap group_by sql with a subquery for limiting rows in Oracle.Chris Dinger2014-09-162-1/+11
|/ / | | | | | | Fixes #128
* | Merge pull request #311 from tamird/masterRafael Mendonça França2014-09-163-18/+12
|\ \ | | | | | | `Extract#as` should not mutate the receiver
| * | `Extract#as` should not mutate the receiverTamir Duberstein2014-09-133-18/+12
|/ / | | | | | | Fixes https://github.com/rails/rails/issues/16913
* | Merge pull request #306 from mxhold/masterRafael Mendonça França2014-09-122-0/+30
|\ \ | | | | | | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier
| * | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifierMax Holder2014-08-302-0/+30
| | |
* | | Merge pull request #304 from bigxiang/fix_lt_and_lteq_errorRafael Mendonça França2014-09-122-6/+50
|\ \ \ | | | | | | | | Fix lt & lteq don't accept most of values.
| * | | Change specs to cover lt, lteq, gt and gteq.bigxiang2014-08-311-4/+42
| | | |
| * | | Fix lt & lteq don't accept most of values.bigxiang2014-08-232-6/+12
| | | |
* | | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-onceRafael Mendonça França2014-09-122-2/+13
|\ \ \ \ | |_|/ / |/| | | Wrap nested Nodes::Grouping in brackets only once
| * | | Wrap nested Nodes::Grouping in brackets only onceSergey Alekseev2014-05-262-2/+13
| | | |
* | | | Merge pull request #300 from jpcody/masterMatthew Draper2014-08-263-19/+17
|\ \ \ \ | |_|/ / |/| | | Allow for alias omission in aggregate expressions
| * | | Remove default aliases from aggregate functionsJoshua Cody2014-07-314-58/+20
| | | |
| * | | Allow for alias omission in aggregate expressionsJoshua Cody2014-07-262-8/+44
| | | |
* | | | Merge pull request #303 from ksss/typoRafael Mendonça França2014-08-211-1/+1
|\ \ \ \ | | | | | | | | | | Fix typo `gt` means `>`
| * | | | Fix typo `gt` means `>`ksss2014-08-211-1/+1
|/ / / /
* / / / Prepare to 6.0.0.beta1Rafael Mendonça França2014-08-173-13/+13
|/ / /
* | | Merge pull request #291 from vipulnsward/rename-testRafael Mendonça França2014-06-301-52/+53
|\ \ \ | | | | | | | | Cleanup SelectManager Test
| * | | - Stop passing redundant `:engine => Table.engine` to `Table#new`Vipul A M2014-06-151-51/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove redundant `ast` variable creation - Rename similar join tests name to what they actually test - Move "joins itself" test to "joins" describe instead of defining describe block twice - Move update manager statement tests in logical order - Move `project` tests in logical order
| * | | Rename ambiguous test name to what it actually testsVipul A M2014-06-151-1/+1
| | | |
* | | | Merge pull request #163 from atombender/masterAaron Patterson2014-06-265-7/+83
|\ \ \ \ | | | | | | | | | | Support for PARTITION BY in window
| * | | | Add test for window + partition + order.Alexander Staubo2014-06-221-0/+11
| | | | |
| * | | | Windowing: Calling #rows or #range should assign framing only once.Alexander Staubo2014-06-222-2/+12
| | | | |
| * | | | Windowing support for PARTITION BY clause.Alexander Staubo2014-06-205-5/+60
|/ / / /
* | | | Merge pull request #292 from mekishizufu/dot_visitor_apiRafael Mendonça França2014-06-155-21/+30
|\ \ \ \ | | | | | | | | | | Modify Visitors::Dot's API to use collectors
| * | | | Modify Visitors::Dot's API to use collectorsJiri Pospisil2014-06-143-7/+9
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-22 06:16:01 +0000