aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* no need to dup options in send_dataSergey Nartimov2012-04-301-1/+1
| | | | options aren't modified inside send_file_headers!
* allow send_file/send_data to skip disposition header, closes #2973Sergey Nartimov2012-04-302-17/+22
|
* Add note about using 303 See Other for XHR requests other than GET/POSTAndrew White2012-04-301-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IE since version 6 and recently Chrome and Firefox have started following 302 redirects from XHR requests other than GET/POST using the original request method. This can lead to DELETE requests being redirected amongst other things. Although it doesn't directly affect the Rails framework since it doesn't return a 302 redirect to any non-GET/POST request a note has been added to raise awareness of the issue. Some references: Original article from @technoweenie: http://techno-weenie.net/2011/8/19/ie9-deletes-stuff/ Hacker News discussion of the article: http://news.ycombinator.com/item?id=2903493 WebKit bug report: https://bugs.webkit.org/show_bug.cgi?id=46183 Firefox bug report and changeset: https://bugzilla.mozilla.org/show_bug.cgi?id=598304 https://hg.mozilla.org/mozilla-central/rev/9525d7e2d20d Chrome bug report: http://code.google.com/p/chromium/issues/detail?id=56373 HTTPbis bug report and changeset: http://trac.tools.ietf.org/wg/httpbis/trac/ticket/160 http://trac.tools.ietf.org/wg/httpbis/trac/changeset/1428 Roy T. Fielding's history of the issue: http://ftp.ics.uci.edu/pub/ietf/http/hypermail/1997q3/0611.html Automated browser tests for the issue: http://www.mnot.net/javascript/xmlhttprequest/ Fixes #4144
* Merge pull request #5923 from rafaelfranca/remove_javascript_helpersJeremy Kemper2012-04-294-65/+3
|\ | | | | Remove button_to_function and link_to_function helpers
| * Remove `button_to_function` and `link_to_function` helpersRafael Mendonça França2012-04-303-65/+2
| |
| * Add missing require when helpers are used in isolationRafael Mendonça França2012-04-301-0/+1
|/
* Merge pull request #6074 from mark-rushakoff/unused-variablesJeremy Kemper2012-04-299-15/+7
|\ | | | | Remove some unused variable assignments
| * Remove unused assignmentsMark Rushakoff2012-04-294-8/+4
| |
| * Remove unused assignment in actionpack date helper testMark Rushakoff2012-04-291-1/+1
| |
| * Remove unused assignments from activerecord testsMark Rushakoff2012-04-294-6/+2
| |
* | Merge pull request #6075 from arunagw/warning_removed_unused_variableJeremy Kemper2012-04-291-1/+0
|\ \ | | | | | | railties variable is not required here.
| * | railties variable is not required here.Arun Agrawal2012-04-301-1/+0
| | |
* | | Merge pull request #6071 from marcandre/observer_redefJeremy Kemper2012-04-292-3/+14
|\ \ \ | |/ / |/| | Fix Observer by acting on singleton class. Fixes #3505.
| * | Fix Observer by acting on singleton class [#3505]Marc-Andre Lafortune2012-04-292-3/+14
| | | | | | | | | | | | Also [issue #1034] [pull #6068]
* | | Merge pull request #5942 from ↵Aaron Patterson2012-04-297-11/+38
|\ \ \ | | | | | | | | | | | | | | | | bcardarella/confirmation_error_message_on_confirmation_attribute confirmation validation error attribute
| * | | Support i18n attributes for confirmationBrian Cardarella2012-04-243-3/+23
| | | |
| * | | Reordered changelog entryBrian Cardarella2012-04-231-2/+2
| | | |
| * | | Updated CHANGELOGBrian Cardarella2012-04-231-0/+2
| | | |
| * | | confirmation validation error attributeBrian Cardarella2012-04-236-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will render the error message on :#{attribute}_confirmation instead of on attribute itself. When rendering confirmation errors inline on the form with form builders such as SimpleForm and Formtastic it is confusing to the ender user to see the confirmation error message on the attribute element. Instead it makes more sense to have this validation error render on the confirmation field instead. The i18n message has been updated for the confirmation validator error message to include the original attribute name.
* | | | Merge pull request #6067 from Locke23rus/patch-2Aaron Patterson2012-04-291-1/+1
|\ \ \ \ | | | | | | | | | | Fix typo
| * | | | Fix typoKirill Nikitin2012-04-301-1/+1
| | | | |
* | | | | Merge pull request #5999 from bogdan/callbacksJeremy Kemper2012-04-291-7/+7
|\ \ \ \ \ | |/ / / / |/| | | | AS::Callbacks#run_callbacks optimized to reduce backtrace
| * | | | AS::Callbacks optimized to reduce call backtraceBogdan Gusiev2012-04-271-7/+7
| | | | |
* | | | | Merge pull request #6036 from carlosantoniodasilva/routes-reloader-refactorSantiago Pastorino2012-04-294-8/+4
|\ \ \ \ \ | | | | | | | | | | | | Remove some warnings and minor refactor in RoutesReloader
| * | | | | Refactor RoutesReloader a bit to avoid creating extra hash objectsCarlos Antonio da Silva2012-04-281-3/+2
| | | | | |
| * | | | | Remove Declarative module extending, it is already part of AS::TestCaseCarlos Antonio da Silva2012-04-281-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | Removes method redefined warning.
| * | | | | Define only writer method for queue, as reader is declaredCarlos Antonio da Silva2012-04-282-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | Remove deprecation warning of method redefined.
* | | | | | Restore interpolation of path option in redirect routesAndrew White2012-04-292-1/+42
| | | | | |
* | | | | | Merge pull request #6062 from marcandre/tweak_observerAaron Patterson2012-04-292-5/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | Tweak observer
| * | | | | | Generate appropriate error more judiciouslyMarc-Andre Lafortune2012-04-292-2/+18
| | | | | | |
| * | | | | | Fix error message:Marc-Andre Lafortune2012-04-281-3/+3
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | - can pass the class, not the instance - "instance method" is confusing, use "method :instance" instead
* | | | | | Merge pull request #6065 from Locke23rus/patch-1Xavier Noria2012-04-291-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove repeated word
| * | | | | | Remove repeated wordKirill Nikitin2012-04-301-1/+1
|/ / / / / /
* | | | | | Escape interpolated params when redirecting - fixes #5688Andrew White2012-04-292-1/+36
| | | | | |
* | | | | | Merge pull request #6061 from twinturbo/scaffold-markupPiotr Sarnacki2012-04-291-16/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | Close #3886 - Add THEAD and TBODY to scaffold markup
| * | | | | | Close #3886 - Add THEAD and TBODY to scaffold markuptwinturbo2012-04-291-16/+20
|/ / / / / /
* | | | | | Add failing test case for #6053Andrew White2012-04-291-0/+21
| | | | | |
* | | | | | Fix controller_class_name for anonymous controllers.Michael Schuerig2012-04-291-1/+1
| | | | | |
* | | | | | Merge pull request #6059 from rafaelfranca/check_box_invertedJosé Valim2012-04-292-6/+100
|\ \ \ \ \ \ | | | | | | | | | | | | | | Change check_box to work inverting the checked and unchecked value
| * | | | | | Change check_box to work inverting the checked and unchecked valueRafael Mendonça França2012-04-292-6/+100
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes: * Boolean with inverted logic * Integer with inverted logic * BigDecimal with inverted logic Fixes #3995
* | | | | | Merge pull request #6006 from ↵José Valim2012-04-296-16/+49
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | carlosantoniodasilva/partial-layout-collection-item Partial layout collection item
| * | | | | | Add changelog entry and some docs for collection + layoutCarlos Antonio da Silva2012-04-293-3/+20
| | | | | | |
| * | | | | | Move layout logic with collection to be handled only with explicit template ↵Carlos Antonio da Silva2012-04-291-15/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is given Layout is never an available option when rendering with the shortcut `render @collection`.
| * | | | | | Allow access to current object_counter variable from layout when rendering ↵Carlos Antonio da Silva2012-04-293-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | with partial + collection
| * | | | | | Allow layout to access current object being rendered when using render ↵Carlos Antonio da Silva2012-04-292-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | partial + object
| * | | | | | Allow layout rendering to access current object being rendered when using ↵Carlos Antonio da Silva2012-04-293-8/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | partial + collection
* | | | | | | Merge pull request #6017 from larzconwell/remove_sanitize_dom_idJeremy Kemper2012-04-291-6/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Removed the sanitize_dom_id method
| * | | | | | | Removed the sanitize_dom_id method because HTML5 doctype let's us use ↵Larz Conwell2012-04-271-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | anything except nothing and whitespace for id's
* | | | | | | | Merge pull request #6057 from jeremyf/remove-deprecation-warning-due-to-reloadJosé Valim2012-04-291-1/+1
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | Removed extraneous .present? check for AR::Base#reload
| * | | | | | | Removed extraneous .present? check for AR::Base#reloadJeremy Friesen2012-04-291-1/+1
| | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 03:44:51 +0000