Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Correct error in Utils.normalize_path that changed paths improperly | Josh Symonds | 2013-10-23 | 2 | -1/+9 |
| | |||||
* | Merge pull request #12617 from skv-headless/master | Rafael Mendonça França | 2013-10-23 | 1 | -4/+3 |
|\ | | | | | [ci skip] second parameter of asset-url is deprecated | ||||
| * | [ci skip] second parameter of asset-url is depricated | Evgeniy | 2013-10-23 | 1 | -4/+3 |
| | | |||||
* | | Merge pull request #12612 from ↵ | Rafael Mendonça França | 2013-10-23 | 3 | -6/+34 |
|\ \ | |/ |/| | | | | | amatsuda/amo_validates_inclusion_of_time_range_error Let validates_inclusion_of accept Time and DateTime ranges | ||||
| * | Let validates_inclusion_of accept Time and DateTime ranges | Akira Matsuda | 2013-10-23 | 3 | -6/+34 |
|/ | | | | fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85 | ||||
* | Try arel master | Rafael Mendonça França | 2013-10-22 | 1 | -0/+1 |
| | | | | | Conflicts: Gemfile | ||||
* | this should be private, no other instances of Root should call it | Aaron Patterson | 2013-10-22 | 1 | -1/+1 |
| | |||||
* | do not search through the keys array twice | Aaron Patterson | 2013-10-22 | 1 | -2/+3 |
| | |||||
* | use the provided block to filter lists | Aaron Patterson | 2013-10-22 | 1 | -11/+5 |
| | |||||
* | stop using `send` so that method privacy is respected and we get a small | Aaron Patterson | 2013-10-22 | 1 | -7/+7 |
| | | | | perf increase | ||||
* | Fix order dependent tests | Rafael Mendonça França | 2013-10-22 | 1 | -4/+4 |
| | |||||
* | Merge pull request #12606 from robin850/apps-with-spaces | Yves Senn | 2013-10-22 | 4 | -2/+20 |
|\ | | | | | Make the application name snake cased when it contains spaces | ||||
| * | Make the application name snake cased when it contains spaces | Robin Dupret | 2013-10-22 | 4 | -2/+20 |
|/ | | | | | | | | | | | | | The application name is used to fill the `database.yml` and `session_store.rb` files ; previously, if the provided name contained whitespaces, it led to unexpected names in these files. Since Shellwords.escape adds backslashes to escape spaces, the app_name should remove them and replace any space with an underscore (just like periods previously). Also improve the assert_file helper to work with paths containing spaces using String#shellescape. | ||||
* | minor Active Record CHANGELOG cleanup. [ci skip]. | Yves Senn | 2013-10-22 | 1 | -3/+3 |
| | |||||
* | move helper class to the top | Aaron Patterson | 2013-10-21 | 1 | -42/+42 |
| | |||||
* | build the association graph functionally | Aaron Patterson | 2013-10-21 | 3 | -20/+13 |
| | | | | This lets us avoid the constant calls to Array#<< | ||||
* | Merge branch 'master' into joindep | Aaron Patterson | 2013-10-21 | 26 | -244/+418 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (23 commits) Escape the parentheses in the default function regexp Update docs on Tilt::Template in Asset Pipeline guide Fix loading a sql structure file on postgres when the file's path has whitespace in it remove trailing whitespace added with b057765 [ci skip]. Allow unscope to work with `where.not` Raise an exception when model without primary key calls .find_with_ids Process sub-query relation's binding values Instrument the generation of Action Mailer messages Remove extra variable creation and merge. In Relation#empty? use #exists? instead of #count. [ci skip] avoid deprecation warning in sample code Convert Fixnum into String the port number in MySQL Fix some indentation on autosave association Make define_non_cyclic_method simpler Add Sass gobbling info to asset pipeline docs Ensure the state is clean after one failure Fix typo in form_helper.rb add a new local variable to track if digests are being stored, to ensure the cleanup works correctly [ci skip] Fix number of methods added by association. update digestor code based on review ... | ||||
| * | Merge pull request #12588 from jetthoughts/12586_subquery_with_unprepared_sql | Rafael Mendonça França | 2013-10-21 | 4 | -6/+56 |
| |\ | | | | | | | | | | | | | | | | | | | Inline bind values for sub-queries generated for Relation in where Conflicts: activerecord/CHANGELOG.md | ||||
| | * | Process sub-query relation's binding values | Paul Nikitochkin | 2013-10-20 | 4 | -4/+54 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generated sub-query for Relation as array condition for `where` method did not take in account its bind values, in result generates invalid SQL query. Fixed by adding sub-query relation's binding values to base relation Closes: #12586 | ||||
| * | | Escape the parentheses in the default function regexp | Rafael Mendonça França | 2013-10-21 | 2 | -1/+6 |
| | | | | | | | | | | | | | | | | | | | | | This is causing every default value in PostreSQL database to being handled as default function. Fixes #12581 | ||||
| * | | Merge pull request #12567 from GoBoundless/fix_postgres_structure_import | Yves Senn | 2013-10-21 | 3 | -1/+13 |
| |\ \ | | | | | | | | | Fix loading a sql structure file on postgres when the file's path has whitespace in it | ||||
| | * | | Fix loading a sql structure file on postgres when the file's path has ↵ | Kevin Mook | 2013-10-21 | 3 | -1/+13 |
| | | | | | | | | | | | | | | | | whitespace in it | ||||
| * | | | Merge pull request #12603 from dv/fix-tilt-template-in-asset-pipeline-docs | Guillermo Iguaran | 2013-10-21 | 1 | -3/+8 |
| |\ \ \ | | |/ / | |/| | | Update docs on Tilt::Template in Asset Pipeline guide | ||||
| | * | | Update docs on Tilt::Template in Asset Pipeline guide | David Verhasselt | 2013-10-21 | 1 | -3/+8 |
| |/ / | |||||
| * | | remove trailing whitespace added with b057765 [ci skip]. | Yves Senn | 2013-10-21 | 1 | -2/+2 |
| | | | |||||
| * | | Merge pull request #12565 from stormsilver/unscope_fixes | Yves Senn | 2013-10-21 | 3 | -7/+23 |
| |\ \ | | | | | | | | | Allow unscope to work with `where.not` | ||||
| | * | | Allow unscope to work with `where.not` | Eric Hankins | 2013-10-21 | 3 | -7/+23 |
| |/ / | | | | | | | | | | | | | | | | Allows you to call #unscope on a relation with negative equality operators, i.e. Arel::Nodes::NotIn and Arel::Nodes::NotEqual that have been generated through the use of where.not. | ||||
| * | | Merge pull request #12549 from makimoto/raise-when-find-without-pk | Yves Senn | 2013-10-21 | 3 | -0/+13 |
| |\ \ | | | | | | | | | Raise an exception when model without primary key calls .find_with_ids | ||||
| | * | | Raise an exception when model without primary key calls .find_with_ids | Shimpei Makimoto | 2013-10-21 | 3 | -0/+13 |
| |/ / | |||||
| * | | Merge pull request #12591 from vipulnsward/remove_mail_merge | Yves Senn | 2013-10-20 | 1 | -3/+3 |
| |\ \ | | | | | | | | | Remove extra variable creation and merge. | ||||
| | * | | Remove extra variable creation and merge. | Vipul A M | 2013-10-20 | 1 | -3/+3 |
| | | | | |||||
| * | | | Merge pull request #12556 from dasch/dasch/nstrument-am-processing | José Valim | 2013-10-20 | 4 | -7/+29 |
| |\ \ \ | | |/ / | |/| | | Instrument the generation of Action Mailer messages | ||||
| | * | | Instrument the generation of Action Mailer messages | Daniel Schierbeck | 2013-10-20 | 4 | -7/+29 |
| |/ / | | | | | | | | | | | | | | | | The processing of outbound mail is instrumented with the key `process.action_mailer`. The payload includes the mailer name as well as the mailer method. | ||||
| * | | Merge pull request #12533 from szimek/use_exists_in_relation_empty | Santiago Pastorino | 2013-10-19 | 2 | -2/+5 |
| |\ \ | | |/ | |/| | In Relation#empty? use #exists? instead of #count. | ||||
| | * | In Relation#empty? use #exists? instead of #count. | Szymon Nowak | 2013-10-19 | 2 | -2/+5 |
| |/ | |||||
| * | Merge pull request #12560 from sue445/modify_find_lock_sample_code | Yves Senn | 2013-10-18 | 1 | -3/+3 |
| |\ | | | | | | | avoid deprecation warning in sample code [ci skip] | ||||
| | * | [ci skip] avoid deprecation warning in sample code | sue445 | 2013-10-18 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | Account.find(1, lock: true) -> DEPRECATION WARNING: Passing options to #find is deprecated. Please build a scope and then call #find on it. | ||||
| * | | Merge pull request #11839 from chocoby/fix/convert_port_number | Yves Senn | 2013-10-18 | 3 | -1/+15 |
| |\ \ | | | | | | | | | Convert Fixnum into String the port number like `db:structure:dump` task in MySQL. | ||||
| | * | | Convert Fixnum into String the port number in MySQL | Kenta Okamoto | 2013-10-18 | 3 | -1/+15 |
| |/ / | |||||
| * | | Merge pull request #12569 from arthurnn/autosave_small_cleanip | Rafael Mendonça França | 2013-10-17 | 1 | -196/+196 |
| |\ \ | | | | | | | | | Small cleanup on autosave association | ||||
| | * | | Fix some indentation on autosave association | Arthur Neves | 2013-10-17 | 1 | -196/+196 |
| | | | | |||||
| | * | | Make define_non_cyclic_method simpler | Arthur Neves | 2013-10-17 | 1 | -7/+7 |
| | | | | |||||
| * | | | Merge pull request #12218 from dv/add-sass-globbing-to-asset-pipeline-docs | Yves Senn | 2013-10-17 | 1 | -1/+5 |
| |\ \ \ | | |/ / | |/| | | Add sass globbing to asset pipeline docs [ci skip] | ||||
| | * | | Add Sass gobbling info to asset pipeline docs | David Verhasselt | 2013-10-17 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
| * | | | Merge pull request #12564 from JuanitoFatas/association-basics | Yves Senn | 2013-10-16 | 1 | -8/+8 |
| |\ \ \ | | | | | | | | | | | [ci skip] Fix number of methods added by association. | ||||
| | * | | | [ci skip] Fix number of methods added by association. | Juanito Fatas | 2013-10-17 | 1 | -8/+8 |
| | | | | | | | | | | | | | | | | | | | | Also clean up some trailing spaces on line 1143-1146. | ||||
| * | | | | Ensure the state is clean after one failure | Rafael Mendonça França | 2013-10-16 | 1 | -5/+4 |
| | | | | | |||||
| * | | | | Merge pull request #12540 from wyaeld/bug/fix-recursive-digest | Rafael Mendonça França | 2013-10-16 | 3 | -6/+37 |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | Ensure ActionView::Digestor.cache is correctly cleaned up | ||||
| | * | | | | add a new local variable to track if digests are being stored, to ensure the ↵ | Brad Murray | 2013-10-17 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | cleanup works correctly | ||||
| | * | | | | update digestor code based on review | Brad Murray | 2013-10-15 | 1 | -2/+2 |
| | | | | | |