| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
Fix typo in per-form CSRF token docs [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |_|/ /
|/| | | |
Move type method inside ActionDispatch::Journey::Nodes::Symbol
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This first started with moving type method inside
`ActionDispatch::Journey::Nodes::Symbol`.
`AD::Journey::Nodes::Symbol#type` was generated dynamically with an
`each` block. While this is OK for classes like `AD::Journey::Nodes::Slash`
or `AD::Journey::Nodes::Dot` which don't have further implementation, all
other classes containing more logic have this method defined in their class
body. This patch does the same in this case.
On code review process @kamipo suggested to fully expand over
metaprogramming for Slash and Dot classes, a topic on which I agree with him.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* No need to go through ruby
* Abort early if a generator command fails
* Reuse `rails_command` method
* Bump thor minimum dependency to 0.20.3
* Add some minimal docs
* Add a changelog entry
* Restore original logging
|
|\ \ \
| |/ /
|/| | |
Prevent non-primary mouse button clicks from triggering click events
|
| | |
| | |
| | |
| | |
| | | |
Firefox fires click events on left-, right-
and scroll-wheel (any non-primary mouse key) clicks while other browsers don't.
|
|\ \ \
| | | |
| | | | |
Stop trying to reconnect on unauthorized cable connections
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
And make sure new applications in Rails 6.0 has this config enabled.
Also, improve test coverage and add a CHANGELOG entry.
|
|\ \ \
| | | |
| | | | |
Fix join table column quoting with SQLite.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Make AJ::Base#enqueue return false if the job wasn't enqueued
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Update bundler to 2.0.0.pre.2
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add MailDeliveryJob for unified mail delivery
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add `MailDeliveryJob` for delivering both regular and parameterized mail.
Deprecate using `DeliveryJob` and `Parameterized::DeliveryJob`.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`test_serialized_attribute_works_under_concurrent_initial_access` test
Since bd62389307e138ee0f274a9d62697567a3334ea0, isolate test of `test_serialized_attribute_works_under_concurrent_initial_access` fails.
```
$ ./bin/test -w test/cases/serialized_attribute_test.rb -n test_serialized_attribute_works_under_concurrent_initial_access
Using sqlite3
Run options: -n test_serialized_attribute_works_under_concurrent_initial_access --seed 32129
# Running:
E
Error:
SerializedAttributeTest#test_serialized_attribute_works_under_concurrent_initial_access:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such table:
```
If duplicate an unloaded model, it seems that method invocation for that class
is not guaranteed. Use the original class to avoid it.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ysksn/use_safe_navigation_operator_for_railsguides_generator_constructor
Use String for direction of RailsGuides::Generator#new
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Use String for direction of RailsGuides::Generator
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Colorize the unpermitted params log message
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Add advanced test helpers docs to guides
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
utilum/bigdecimal_raises_on_comma_in_string_argument
Another Ruby 2.6 BigDecimal compatibility issue
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This patch modifies XmlMini::Parsing["decimal"] to handle a string that
contains an invalid number. Since [ruby/ruby@a0e438c#diff-6b866d482baf2bdfd8433893fb1f6d36R144](https://github.com/ruby/ruby/commit/a0e438cd3c28d2eaf4efa18243d5b6edafa14d88#diff-6b866d482baf2bdfd8433893fb1f6d36R144) this case raises an `ArgumentError`. `String.to_f` returns 0.0 if there is not a valid number at the start of the argument, so current behavior is conserved.
See https://travis-ci.org/rails/rails/jobs/463180341#L6264
Related: #34600, #34601
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix attribute decoration leak on serialized attribute test
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add note about symbols vs strings
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Now it accepts the base release to be compared with.
[ci skip]
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
option to disable all scopes that `ActiveRecord.enum` generates
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Ensure that `delete_all` on collection proxy returns affected count
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Unlike the `Relation#delete_all`, `delete_all` on collection proxy
doesn't return affected count. Since the `CollectionProxy` is a subclass
of the `Relation`, this inconsistency is probably not intended, so it
should return the count consistently.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Reset scope after collection delete
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Reset scope after delete on collection association to clear stale
offsets of removed records.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve parallel testing guide [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Fix formatting
- Don't repeat "Active Record automatically handles creating and migrating a new
database for each worker to use."
- Tell that AR loads the schema to a database for each process(Related to #33479)
- Clarify that `parallelize_teardown` is executed for each process
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Pass the `connection` to the `@instrumenter.instrument` method call
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix NumericData.average test on 2.6.0-dev
|
| |/ / / / / / |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
And hide the `READ_QUERY` internal constant.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Assigned but unused variable - bird
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
See: https://travis-ci.org/rails/rails/jobs/462233144#L1384
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
rmacklin/add-missing-authorship-to-changelog-entry
Add missing authorship to ActionCable changelog entry
|