| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |\
| | |
| | | |
Use `next` instead of `break`; avoid terminating whole loop
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We want to avoid terminating the whole loop here, because it will cause
parameters that should be removed to not be removed, since we are
terminating early. In this specific case, `param2` is processed before
`param1` due to the reversing of `route.parts`, and since `param2` fails
the check on this line, it would previously cause the whole loop to
fail, and `param1` would still be in `parameterized_parts`. Now, we are
simply calling `next`, which is the intended behavior.
Introduced by 8ca8a2d773b942c4ea76baabe2df502a339d05b1.
Fixes #27454.
|
| | |
|
| |\
| | |
| | | |
Update request.rb --ci skip
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Documentation for ActionDispatch::Request#key? [ci skip]
Update request.rb --ci skip
Documentation for ActionDispatch::Request#key? [ci skip]
Also made change after the review by @rafaelfranca .
Update request.rb --ci skip
Documentation for ActionDispatch::Request#key? [ci skip]
Also made change after the review by @rafaelfranca .
Update request.rb --ci skip
|
| |\
| | |
| | |
| | |
| | | |
kamipo/should_not_update_children_when_parent_creation_with_no_reason
Should not update children when the parent creation with no reason
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This issue was introduced with d849f42 to solve #19782. However, we can
solve #19782 without causing the issue. It is enough to save only when
necessary.
Fixes #27338.
|
| |\ \
| | |/
| |/| |
Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue`
|
| | |
| | |
| | |
| | |
| | |
| | | |
`AssociationQueryValue`
It is handled by `PolymorphicArrayValue`.
|
| |\ \
| | | |
| | | |
| | | | |
clear all environments log files by default
|
| | |\ \
| | |/ /
| |/| | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
jeremywadsack/doc_cache_importability""
This reverts commit 6961afefd2f163f30b9ae3aacb74b290287f9a80.
We were not able to keep backward compatibility in this case so it is
better to ask people to upgrade with cold cache.
|
| |\ \ \
| | | | |
| | | | | |
Upgrade to nio4r 2.0.0
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
nio4r 2.0.0 primarily includes new features and bugfixes, with few breaking
changes. The primary reason for bumping the major version is dropping support
for all Ruby versions prior to 2.2.2, so as to match Rails 5.
Full release announcement here:
https://groups.google.com/forum/#!topic/socketry/ZDIUj1ufiJ8
|
| |\ \ \
| | | | |
| | | | | |
Use `#execute` instead of `@connection.query`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`@connection.query` bypasses instrumenting "sql.active_record".
This behavior preventing us from debugging SQLs which Rails generates.
|
| |\ \ \ \
| | | | | |
| | | | | | |
do not mutate `object_name` of class in `fields_for`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since it affects the entire form, should not mutate `object_name` of class.
Fixes #26931
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some methods were added to public API in
5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of
the public API.
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Optimize Journey::Route#score for url_for
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Scoring routes based on constraints repeated many type conversions that
could be performed in the outer loop. Determinations of score and
fitness also used Array operations that required allocations. Against
my benchmark with a large routeset, this reduced object allocations by
over 30x and wall time by over 3x.
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Fix typo in action_view/template.rb [ci skip]
|
| |/ / / / / |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Add a record to target before any callbacks loads the record
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`append_record` was added at 15ddd51 for not double adding the record.
But adding `append_record` (checking `@target.include?(record)`) caused
performance regression #27434. Instead of checking not double adding the
record, add a record to target before any callbacks loads the record.
Fixes #27434.
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Small edits to CHANGELOG.md files
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
- add period where necessary
- add backticks where necessary
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
- change a period to a comma
- add backticks for class + method
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
- capitalize WebSocket
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Light CHANGELOG.md linting
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
renderers typo fix [ci skip]
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Restore missing Gemfile.lock entries
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
These lines were lost in https://github.com/rails/rails/commit/774be3ea3b9d25ab69daf11c5071deaf053d7d5b#diff-e79a60dc6b85309ae70a6ea8261eaf95L204.
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Bump sdoc to rc1 which includes zzak/sdoc#98
|
| |/ / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #27447
[Matthew Draper & Yuuji Yaginuma]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
minitest 6."
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
No need `:doc:` for `:nodoc:` classes [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c.
http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html
|