aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* commit the flash after the controller finishes being servicedAaron Patterson2015-09-253-25/+17
| | | | | Committing the flash needs to happen in order for the session to be written correctly, so lets guarantee that it actually does happen.
* move flash committing to the request object.Aaron Patterson2015-09-252-12/+16
| | | | | I'm doing this so that we can commit the flash to the session object Out of Band of the flash middleware
* Merge pull request #21766 from amitsuroliya/missing_breaketEileen M. Uchitelle2015-09-251-1/+1
|\ | | | | docs, add missing closing bracket. [ci skip]
| * docs, add missing closing bracket. [ci skip]amitkumarsuroliya2015-09-251-1/+1
| |
* | Merge pull request #21770 from pratik96/humanArthur Nogueira Neves2015-09-251-1/+1
|\ \ | |/ |/| Fixed humane -> human [ci skip]
| * Fixed humane -> human [ci skip]Pratik2015-09-261-1/+1
|/
* Merge pull request #21738 from cllns/remove-to_s-from-exampleEileen M. Uchitelle2015-09-251-19/+1
|\ | | | | [Engines Guide] Remove to_s example, since it's outside the scope
| * Remove to_s exampleSean Collins2015-09-241-19/+1
| | | | | | | | | | | | It's outside the scope of the Engines guide [skip ci]
* | `validates_acceptance_of` shouldn't require a database connectionSean Griffin2015-09-253-4/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | The implementation of `attribute_method?` on Active Record requires establishing a database connection and querying the schema. As a general rule, we don't want to require database connections for any class macro, as the class should be able to be loaded without a database (e.g. for things like compiling assets). Instead of eagerly defining these methods, we do it lazily the first time they are accessed via `method_missing`. This should not cause any performance hits, as it will only hit `method_missing` once for the entire class.
* | Merge pull request #21758 from yui-knk/fix_sanitize_test_exampleEileen M. Uchitelle2015-09-251-4/+4
|\ \ | | | | | | Quote prepared statements of `sanitize_sql_array`
| * | Quote prepared statements of `sanitize_sql_array`yui-knk2015-09-251-4/+4
| | | | | | | | | | | | | | | | | | Sure unquoted SQL code pass test, but this % style prepared statements are dangerous. Test codes and code examples are also "Rails" codes, so quote placeholder of prepared statements.
* | | Merge pull request #21759 from amitsuroliya/mime_deprecationKasper Timm Hansen2015-09-251-5/+5
|\ \ \ | | | | | | | | Fix deprecated mime types via constants
| * | | Fix deprecated mime types via constantsamitkumarsuroliya2015-09-251-5/+5
|/ / / | | | | | | Accessing mime types via constants is deprecated. Now, we are using `Mime::Type[:JSON]` instead of `Mime::JSON`
* | | Don't assert fractional seconds can be applied on unsupported adaptersSean Griffin2015-09-241-0/+1
| | | | | | | | | | | | | | | | | | | | | This was passing prior to 20b177b78ef5d21c8cc255f0376f6b2e948de234, because we were not properly applying our contract that `model.attr == model.tap(&:save).reload.attr` for this case. Now that that has been resolved, this test is invalid on some adapters
* | | Apply subsecond precision on assignment when using TZ aware attributesSean Griffin2015-09-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a time object was assigned to a datetime column, the decorator for TZ aware attributes wouldn't call super, so when using a database without support for subsecond precision, the nanosecond would not be truncated, leading to the value being marked as changed. Interestingly, this also shows our new implementation of dirty checking to be more robust than the old one (with less code and better performance! :tada:!!!)
* | | Remove debug statementsSean Griffin2015-09-241-4/+1
| | | | | | | | | | | | They didn't help.
* | | build the Set-Cookie header functionallyAaron Patterson2015-09-241-5/+18
| | | | | | | | | | | | | | | Use the Rack utility methods for functional header manipulation. This helps to eliminate coupling on the header hash
* | | move the Header hash to the super classAaron Patterson2015-09-242-28/+24
| | | | | | | | | | | | | | | | | | | | | I want to move the header hash to the super request object in order to consolidate behavior. We should be switching out buffering strategies rather than header strategies since things like "mutating headers after send" is an error in both cases (buffering vs streaming).
* | | mutate headers before committing the responseAaron Patterson2015-09-241-2/+8
| | | | | | | | | | | | We should not mutate headers after the response has been committed.
* | | Add a few debug statements to figure out the build failureSean Griffin2015-09-241-0/+3
| | | | | | | | | | | | Nobody can replicate locally and the failure makes no sense
* | | We still need to reset `@changed_attributes` in `changes_applied`Sean Griffin2015-09-241-0/+2
| | | | | | | | | | | | | | | | | | When I removed the call to `super` to avoid the setting of `@previous_changes`, I forgot to duplicate the other part of that behavior, which led to failing tests
* | | Improve the performance of `save` and friendsSean Griffin2015-09-243-4/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The biggest source of the performance regression in these methods occurred because dirty tracking required eagerly materializing and type casting the assigned values. In the previous commits, I've changed dirty tracking to perform the comparisons lazily. However, all of this is moot when calling `save`, since `changes_applied` will be called, which just ends up eagerly materializing everything, anyway. With the new mutation tracker, it's easy to just compare the previous two hashes in the same lazy fashion. We will not have aliasing issues with this setup, which is proven by the fact that we're able to detect nested mutation. Before: User.create! 2.007k (± 7.1%) i/s - 10.098k After: User.create! 2.557k (± 3.5%) i/s - 12.789k Fixes #19859
* | | Encapsulate a lot of the logic from `Dirty` in an objectSean Griffin2015-09-243-25/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | In order to improve the performance of dirty checking, we're going to need to duplicate all of the `previous_` methods in Active Model. However, these methods are basically the same as their non-previous counterparts, but comparing `@original_attributes` to `@previous_original_attributes` instead of `@attributes` and `@original_attributes`. This will help reduce that duplication.
* | | Clean up the implementation of AR::DirtySean Griffin2015-09-2413-89/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves a bit more of the logic required for dirty checking into the attribute objects. I had hoped to remove the `with_value_from_database` stuff, but unfortunately just calling `dup` on the attribute objects isn't enough, since the values might contain deeply nested data structures. I think this can be cleaned up further. This makes most dirty checking become lazy, and reduces the number of object allocations and amount of CPU time when assigning a value. This opens the door (but doesn't quite finish) to improving the performance of writes to a place comparable to 4.1
* | | Merge pull request #21754 from lucasmazza/lm-assert-differenceRafael Mendonça França2015-09-243-2/+23
|\ \ \ | | | | | | | | Make `assert_difference` return the result of the yielded block.
| * | | Make `assert_difference` return the result of the yielded block.Lucas Mazza2015-09-243-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this we can perform new assertions on the returned value without having to cache it with an outer variable or wrapping all subsequent assertions inside the `assert_difference` block. Before: ``` post = nil assert_difference -> { Post.count }, 1 do Post.create end assert_predicate post, :persisted? ``` Now: ``` post = assert_difference -> { Post.count } do Post.create end assert_predicate post, :persisted? ```
* | | | Merge pull request #21753 from jonatack/fix-typo-in-ignored_columns_testRafael Mendonça França2015-09-241-1/+1
|\ \ \ \ | | | | | | | | | | Fix typo in ignored_columns test [skip ci]
| * | | | Fix typo in ignored_columns test [skip ci]Jon Atack2015-09-241-1/+1
|/ / / / | | | | | | | | | | | | Follow-up to #21720.
* | | | Merge pull request #21720 from byroot/ignore-columnsSean Griffin2015-09-245-1/+37
|\ \ \ \ | |_|/ / |/| | | Implement ActiveRecord::Base.ignored_columns
| * | | Implement ActiveRecord::Base.ignored_columnsJean Boussier2015-09-245-1/+37
|/ / /
* | | Merge pull request #21550 from didacte/unscope-associationsSean Griffin2015-09-243-1/+26
|\ \ \ | | | | | | | | | | | | ActiveRecord: use association's `unscope` when preloading
| * | | Include association's `unscope` when preloadingJimmy Bourassa2015-09-092-1/+22
| | | |
* | | | Merge pull request #21697 from gdeglin/fix_returning_disabled_default_values_bugSean Griffin2015-09-242-1/+15
|\ \ \ \ | |_|/ / |/| | | | | | | Fix a bug with returning_disabled when using the postgresql adapter
| * | | Fix a bug with returning_disabled when using the postgresql adapterGeorge Deglin2015-09-202-1/+16
| | | | | | | | | | | | | | | | The returning_disabled configuration option is required to make postgresql partitioning triggers work. This commit fixes a bug where an invalid query would be made in cases where returning_disabled was true and objects were created with no attributes defined.
* | | | Merge pull request #21746 from amitsuroliya/doc_fixesKasper Timm Hansen2015-09-242-3/+3
|\ \ \ \ | | | | | | | | | | Improve readability of docs by using code tag [ci skip]
| * | | | Improve readability of docs by using code tag [ci skip]amitkumarsuroliya2015-09-242-3/+3
|/ / / /
* | | | Merge pull request #21740 from cllns/add-jbuilder-notesYves Senn2015-09-241-0/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] [Action View Overview Guide] Add note about Jbuilder
| * | | | Add note about JbuilderSean Collins2015-09-231-0/+33
| | |_|/ | |/| | | | | | | | | | [skip ci]
* | | | Merge pull request #21744 from amitsuroliya/doc_changesYves Senn2015-09-241-1/+1
|\ \ \ \ | | | | | | | | | | Fix ActiveRecord `instance_method_already_implemented` docs [ci skip]
| * | | | Fix ActiveRecord `instance_method_already_implemented` docs [ci skip]amitkumarsuroliya2015-09-241-1/+1
| | | | |
* | | | | Merge pull request #21745 from brandoncc/patch-1Yves Senn2015-09-241-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | Fix out of sync comment [ci skip]
| * | | | Fix out of sync commentBrandon Conway2015-09-231-1/+1
|/ / / / | | | | | | | | It appears that as of version 4 the `db:test:prepare` task no longer depends on the `abort_if_pending_migrations` task, which leaves this comment out of sync.
* | | | call `get` instead of controller.processAaron Patterson2015-09-231-12/+10
| | | | | | | | | | | | | | | | | | | | we want the request to go through the test harness, not directly call the methods on the controller
* | | | remove controller constructionAaron Patterson2015-09-231-8/+4
| | | | | | | | | | | | | | | | also remove req / res references
* | | | stop directly referencing the request and response objectsAaron Patterson2015-09-231-23/+21
| | | |
* | | | test framework allocates the controller for usAaron Patterson2015-09-231-1/+0
| | | |
* | | | type of response should not matterAaron Patterson2015-09-231-6/+0
| | | |
* | | | don't touch the response object until after we call `get`Aaron Patterson2015-09-231-5/+2
| | | |
* | | | stop directly setting headers on the controllerAaron Patterson2015-09-232-14/+1
| | | | | | | | | | | | | | | | | | | | again, since we are going through the test harness, all this is done for us.
* | | | stop constructing a request object in this setterAaron Patterson2015-09-231-1/+0
| | | | | | | | | | | | | | | | | | | | Since we just go through the normal test harness that sets up a request for us, we don't need to do this anymore.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 07:47:54 +0000