Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | wrap translate defaults to use translate helper features, closes #1102 | Sergey Nartimov | 2012-04-30 | 3 | -1/+41 |
| | |||||
* | Add note about using 303 See Other for XHR requests other than GET/POST | Andrew White | 2012-04-30 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IE since version 6 and recently Chrome and Firefox have started following 302 redirects from XHR requests other than GET/POST using the original request method. This can lead to DELETE requests being redirected amongst other things. Although it doesn't directly affect the Rails framework since it doesn't return a 302 redirect to any non-GET/POST request a note has been added to raise awareness of the issue. Some references: Original article from @technoweenie: http://techno-weenie.net/2011/8/19/ie9-deletes-stuff/ Hacker News discussion of the article: http://news.ycombinator.com/item?id=2903493 WebKit bug report: https://bugs.webkit.org/show_bug.cgi?id=46183 Firefox bug report and changeset: https://bugzilla.mozilla.org/show_bug.cgi?id=598304 https://hg.mozilla.org/mozilla-central/rev/9525d7e2d20d Chrome bug report: http://code.google.com/p/chromium/issues/detail?id=56373 HTTPbis bug report and changeset: http://trac.tools.ietf.org/wg/httpbis/trac/ticket/160 http://trac.tools.ietf.org/wg/httpbis/trac/changeset/1428 Roy T. Fielding's history of the issue: http://ftp.ics.uci.edu/pub/ietf/http/hypermail/1997q3/0611.html Automated browser tests for the issue: http://www.mnot.net/javascript/xmlhttprequest/ Fixes #4144 | ||||
* | Merge pull request #5923 from rafaelfranca/remove_javascript_helpers | Jeremy Kemper | 2012-04-29 | 4 | -65/+3 |
|\ | | | | | Remove button_to_function and link_to_function helpers | ||||
| * | Remove `button_to_function` and `link_to_function` helpers | Rafael Mendonça França | 2012-04-30 | 3 | -65/+2 |
| | | |||||
| * | Add missing require when helpers are used in isolation | Rafael Mendonça França | 2012-04-30 | 1 | -0/+1 |
|/ | |||||
* | Merge pull request #6074 from mark-rushakoff/unused-variables | Jeremy Kemper | 2012-04-29 | 9 | -15/+7 |
|\ | | | | | Remove some unused variable assignments | ||||
| * | Remove unused assignments | Mark Rushakoff | 2012-04-29 | 4 | -8/+4 |
| | | |||||
| * | Remove unused assignment in actionpack date helper test | Mark Rushakoff | 2012-04-29 | 1 | -1/+1 |
| | | |||||
| * | Remove unused assignments from activerecord tests | Mark Rushakoff | 2012-04-29 | 4 | -6/+2 |
| | | |||||
* | | Merge pull request #6075 from arunagw/warning_removed_unused_variable | Jeremy Kemper | 2012-04-29 | 1 | -1/+0 |
|\ \ | | | | | | | railties variable is not required here. | ||||
| * | | railties variable is not required here. | Arun Agrawal | 2012-04-30 | 1 | -1/+0 |
| | | | |||||
* | | | Merge pull request #6071 from marcandre/observer_redef | Jeremy Kemper | 2012-04-29 | 2 | -3/+14 |
|\ \ \ | |/ / |/| | | Fix Observer by acting on singleton class. Fixes #3505. | ||||
| * | | Fix Observer by acting on singleton class [#3505] | Marc-Andre Lafortune | 2012-04-29 | 2 | -3/+14 |
| | | | | | | | | | | | | Also [issue #1034] [pull #6068] | ||||
* | | | Merge pull request #5942 from ↵ | Aaron Patterson | 2012-04-29 | 7 | -11/+38 |
|\ \ \ | | | | | | | | | | | | | | | | | bcardarella/confirmation_error_message_on_confirmation_attribute confirmation validation error attribute | ||||
| * | | | Support i18n attributes for confirmation | Brian Cardarella | 2012-04-24 | 3 | -3/+23 |
| | | | | |||||
| * | | | Reordered changelog entry | Brian Cardarella | 2012-04-23 | 1 | -2/+2 |
| | | | | |||||
| * | | | Updated CHANGELOG | Brian Cardarella | 2012-04-23 | 1 | -0/+2 |
| | | | | |||||
| * | | | confirmation validation error attribute | Brian Cardarella | 2012-04-23 | 6 | -11/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will render the error message on :#{attribute}_confirmation instead of on attribute itself. When rendering confirmation errors inline on the form with form builders such as SimpleForm and Formtastic it is confusing to the ender user to see the confirmation error message on the attribute element. Instead it makes more sense to have this validation error render on the confirmation field instead. The i18n message has been updated for the confirmation validator error message to include the original attribute name. | ||||
* | | | | Merge pull request #6067 from Locke23rus/patch-2 | Aaron Patterson | 2012-04-29 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | Fix typo | ||||
| * | | | | Fix typo | Kirill Nikitin | 2012-04-30 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #5999 from bogdan/callbacks | Jeremy Kemper | 2012-04-29 | 1 | -7/+7 |
|\ \ \ \ \ | |/ / / / |/| | | | | AS::Callbacks#run_callbacks optimized to reduce backtrace | ||||
| * | | | | AS::Callbacks optimized to reduce call backtrace | Bogdan Gusiev | 2012-04-27 | 1 | -7/+7 |
| | | | | | |||||
* | | | | | Merge pull request #6036 from carlosantoniodasilva/routes-reloader-refactor | Santiago Pastorino | 2012-04-29 | 4 | -8/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove some warnings and minor refactor in RoutesReloader | ||||
| * | | | | | Refactor RoutesReloader a bit to avoid creating extra hash objects | Carlos Antonio da Silva | 2012-04-28 | 1 | -3/+2 |
| | | | | | | |||||
| * | | | | | Remove Declarative module extending, it is already part of AS::TestCase | Carlos Antonio da Silva | 2012-04-28 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | Removes method redefined warning. | ||||
| * | | | | | Define only writer method for queue, as reader is declared | Carlos Antonio da Silva | 2012-04-28 | 2 | -3/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | Remove deprecation warning of method redefined. | ||||
* | | | | | | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 2 | -1/+42 |
| | | | | | | |||||
* | | | | | | Merge pull request #6062 from marcandre/tweak_observer | Aaron Patterson | 2012-04-29 | 2 | -5/+21 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Tweak observer | ||||
| * | | | | | | Generate appropriate error more judiciously | Marc-Andre Lafortune | 2012-04-29 | 2 | -2/+18 |
| | | | | | | | |||||
| * | | | | | | Fix error message: | Marc-Andre Lafortune | 2012-04-28 | 1 | -3/+3 |
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | - can pass the class, not the instance - "instance method" is confusing, use "method :instance" instead | ||||
* | | | | | | Merge pull request #6065 from Locke23rus/patch-1 | Xavier Noria | 2012-04-29 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove repeated word | ||||
| * | | | | | | Remove repeated word | Kirill Nikitin | 2012-04-30 | 1 | -1/+1 |
|/ / / / / / | |||||
* | | | | | | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 2 | -1/+36 |
| | | | | | | |||||
* | | | | | | Merge pull request #6061 from twinturbo/scaffold-markup | Piotr Sarnacki | 2012-04-29 | 1 | -16/+20 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Close #3886 - Add THEAD and TBODY to scaffold markup | ||||
| * | | | | | | Close #3886 - Add THEAD and TBODY to scaffold markup | twinturbo | 2012-04-29 | 1 | -16/+20 |
|/ / / / / / | |||||
* | | | | | | Add failing test case for #6053 | Andrew White | 2012-04-29 | 1 | -0/+21 |
| | | | | | | |||||
* | | | | | | Fix controller_class_name for anonymous controllers. | Michael Schuerig | 2012-04-29 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #6059 from rafaelfranca/check_box_inverted | José Valim | 2012-04-29 | 2 | -6/+100 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Change check_box to work inverting the checked and unchecked value | ||||
| * | | | | | | Change check_box to work inverting the checked and unchecked value | Rafael Mendonça França | 2012-04-29 | 2 | -6/+100 |
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes: * Boolean with inverted logic * Integer with inverted logic * BigDecimal with inverted logic Fixes #3995 | ||||
* | | | | | | Merge pull request #6006 from ↵ | José Valim | 2012-04-29 | 6 | -16/+49 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | carlosantoniodasilva/partial-layout-collection-item Partial layout collection item | ||||
| * | | | | | | Add changelog entry and some docs for collection + layout | Carlos Antonio da Silva | 2012-04-29 | 3 | -3/+20 |
| | | | | | | | |||||
| * | | | | | | Move layout logic with collection to be handled only with explicit template ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -15/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is given Layout is never an available option when rendering with the shortcut `render @collection`. | ||||
| * | | | | | | Allow access to current object_counter variable from layout when rendering ↵ | Carlos Antonio da Silva | 2012-04-29 | 3 | -5/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | with partial + collection | ||||
| * | | | | | | Allow layout to access current object being rendered when using render ↵ | Carlos Antonio da Silva | 2012-04-29 | 2 | -1/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | partial + object | ||||
| * | | | | | | Allow layout rendering to access current object being rendered when using ↵ | Carlos Antonio da Silva | 2012-04-29 | 3 | -8/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | partial + collection | ||||
* | | | | | | | Merge pull request #6017 from larzconwell/remove_sanitize_dom_id | Jeremy Kemper | 2012-04-29 | 1 | -6/+1 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Removed the sanitize_dom_id method | ||||
| * | | | | | | | Removed the sanitize_dom_id method because HTML5 doctype let's us use ↵ | Larz Conwell | 2012-04-27 | 1 | -6/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | anything except nothing and whitespace for id's | ||||
* | | | | | | | | Merge pull request #6057 from jeremyf/remove-deprecation-warning-due-to-reload | José Valim | 2012-04-29 | 1 | -1/+1 |
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | | Removed extraneous .present? check for AR::Base#reload | ||||
| * | | | | | | | Removed extraneous .present? check for AR::Base#reload | Jeremy Friesen | 2012-04-29 | 1 | -1/+1 |
| | | | | | | | | |||||
* | | | | | | | | Merge pull request #6056 from jeremyf/remove-deprecation-warning-due-to-reload | José Valim | 2012-04-29 | 1 | -1/+7 |
|\| | | | | | | | |_|/ / / / / |/| | | | | | | Removed deprecation warning for #find as a result of AR::Base#reload |