| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
[ci skip] Subject-verb agreement
|
|/ |
|
| |
|
|\
| |
| |
| |
| | |
AndrewHendrie/AndrewHendrie-guides-testing-partials-patch
Asserting partials modification
|
| |
| |
| | |
Changed "create Articles view" to "new article view". The create action doesn't typically have a view assigned to it. The view that's being referred to is the 'new' Article view.
|
|\ \
| | |
| | | |
Add `rake initializer`
|
| | |
| | |
| | |
| | |
| | | |
This task prints out initializers for an application. It is useful to
develop a rubygem which involves the initialization process.
|
| | |
| | |
| | |
| | | |
Closes #19321. [ci skip]
|
|\ \ \
| | | |
| | | | |
Return truthy value from head method
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It was returning false in normal circumstances.
This broke the `head :ok and return if` construct.
Add appropriate test.
|
|\ \ \ \
| | | | |
| | | | | |
`QueueAdapters` now does lazy lookup
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | | |
Update sprockets links to point to rails org
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] correct output of select
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[CI SKIP] Correct output of options_for_select
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix typo in the Testing Your Mailers docs
|
|/ / /
| | |
| | | |
* [ci skip]
|
|\ \ \
| | | |
| | | | |
Use request.session.id instead of request.session_options[:id]
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As of the upgrade to Rack 1.5, request.session_options[:id] is no
longer populated. Reflect this change in the tests by using
request.session.id instead.
Related change in Rack:
https://github.com/rack/rack/commit/83a270d6
|
|\ \ \
| | | |
| | | | |
Use a more conservative `const_get` over `constantize`
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
304 response should not include Content-Type header
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Rack::Lint raises an error saying "Content-Type header found in 304
response, not allowed".
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Take NOTE: as paragraph to make NOTE block
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Isolate access to .default_scopes in ActiveRecord::Scoping::Default
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead use .scope_attributes? consistently in ActiveRecord to check whether
there are attributes currently associated with the scope.
Move the implementation of .scope_attributes? and .scope_attributes to
ActiveRecord::Scoping because they don't particularly have to do specifically
with Named scopes and their only dependency, in the case of
.scope_attributes?, and only caller, in the case of .scope_attributes is
contained in Scoping.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`setup do` creates unnecessary allocations of proc objects in callbacks.
This prevents that from happening and results in faster code.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
add `DateTime.now` to list of `TimeHelpers#travel_to` stubbing [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Require pg ~> 0.18 to ensure Ruby 2.2 compatibility
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Versions of the pg gem earlier than 0.18.0 cannot be used safely with Ruby 2.2.
Specifically, pg 0.17 when used with Ruby 2.2 has a known bug that causes
random bits to be added to the end of strings. Further explanation here:
https://bitbucket.org/ged/ruby-pg/issue/210/crazy-bytes-being-added-to-record
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
ActiveJob: queue_adapter can be inherited
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This allows different `queue_adapters` to be used in each `ActiveJob`
class heirarchy. Previously, all subclasses used a single global queue
adapter.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Action Controller guide edits for grammar and clarity
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`ActiveJob::QueueAdapters::*` are no longer singletons
|
| | | | | | |
|
| | |_|/ /
| |/| | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This introduces undesirable `Rails.logger` formatters (such as the syslog
formatter) onto a `Logger.new(STDERR)` for the console. The production
logger may be going elsewhere than standard io, so we can't presume to
reuse its formatter.
With syslog, this causes missing newlines in the console, so irb prompts
start at the end of the last log message.
We can work to expose the console formatter in another way to address
the original issue.
This reverts commit 026ce5ddf11c4cda0aae7f33a9266e54117db318, reversing
changes made to 6f0a69c5899ebdc892e2aa23e68e2604fa70fb73.
|
|\ \ \ \
| | | | |
| | | | | |
Unnecessary usage of self in the guides [ci skip]
|
| | | | |
| | | | |
| | | | | |
I deleted self from the callbacks guides code example because it's unnecessary and this way it's more like the other examples where self was not used.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Change to code element
|
|/ / / / / |
|