aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #22750 from nettofarah/patch-1Sean Griffin2015-12-231-1/+26
|\ | | | | Plugin Usage and Installation instructions
| * Plugin Usage and Installation instructionsNetto Farah2015-12-231-1/+26
| |
* | Move test coloring closer to where it's used.Kasper Timm Hansen2015-12-231-15/+9
| | | | | | | | | | | | | | | | | | | | | | Didn't like the constant being at the top of the file, gave it overdue importance. Now that `color_output` expects a result we can shorten some of the flexibility from earlier: * Inline COLOR_CODES constant (keep local variable for readability, but don't need names of colors at run time). * Inline color variable in `color_output`. Looks just as clear without it.
* | Remove local variable color.Kasper Timm Hansen2015-12-231-5/+5
| | | | | | | | | | Focus `color_output`'s intent on coloring output by a result. We aren't meant to pass it arbitrary codes to color output.
* | Rename color to color_output.Kasper Timm Hansen2015-12-231-6/+5
| | | | | | | | | | | | The word color is being thrown all around with slightly different meanings. Right now, I understand it. But I'd like to be more immediately clear.
* | Remove unused blue color.Kasper Timm Hansen2015-12-231-2/+1
| | | | | | | | I got the blues because we aren't coloring any lines blue.
* | Color failure line by result code.Kasper Timm Hansen2015-12-231-1/+1
| | | | | | | | | | | | | | The static red color wouldn't paint skips in their designated yellow. Use the color name we got from the result label earlier, which marks skips as yellow.
* | Rewrite aggregated results suppression.Kasper Timm Hansen2015-12-231-10/+4
| | | | | | | | | | | | | | | | I should have replaced the summary reporter with a subclass the first time I wrote this. For whatever reason, I didn't. Do it right and slim the methods added to Minitest in the process.
* | [ci skip] Clarify why we're clearing reporters.Kasper Timm Hansen2015-12-231-1/+1
| | | | | | | | | | | | Minitest by default includes a summary reporter and a progress reporter. To print colored output, we have to replace the progress reporter.
* | Merge pull request #22756 from lucasmazza/lm-test-reporter-colored-outputKasper Timm Hansen2015-12-233-4/+82
|\ \ | | | | | | Add colored output to the new test reporter.
| * | Add colored output to the new test reporter.Lucas Mazza2015-12-223-4/+82
| | |
* | | Merge pull request #22777 from djpowers/patch-1Rafael França2015-12-231-1/+1
|\ \ \ | | | | | | | | Improve readability of CacheHelper section
| * | | Improve readability of CacheHelper sectionDave Powers2015-12-231-1/+1
|/ / / | | | | | | [ci skip]
* | | Merge pull request #22776 from kamipo/fix_tenseRafael França2015-12-231-2/+2
|\ \ \ | | | | | | | | release notes, use past tense. [ci skip]
| * | | release notes, use past tense. [ci skip]Ryuta Kamizono2015-12-241-2/+2
|/ / /
* | | Merge pull request #20507 from rabbitt/bugfix/logger-threadsafetyRafael França2015-12-234-4/+120
|\ \ \ | | | | | | | | Fixes LoggerSilence#silence threadsafety
| * | | Fixes LoggerSilence#silence threadsafetyCarl P. Corliss2015-12-234-4/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - uses instance defined level if no custom local log level defined - Keeps track of local log level per [ thread + object-instance ] - prevents memory leakage by removing local level hash key/value on #silence method exit - avoids the use of Thread local variables
* | | | Merge pull request #22775 from derekprior/dp-number-to-currency-docsRafael França2015-12-232-0/+16
|\ \ \ \ | |/ / / |/| | | Add i18n caveat to number_to_currency docs [ci skip]
| * | | Add caveat to number_to_currency docs [ci skip]Derek Prior2015-12-232-0/+16
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've worked on a few applications that have gone through the internationalization process and had issues because they were using `number_to_currency`. The minute a user is allowed to change their locale, they can change the price displayed on a page from 10 US dollars to 10 Mexican Pesos, which is far from the same amount of money. Unlike other helpers that rely on i18n, `number_to_currency` does not produce equivalent results when the locale is changed. As I've explained this to a few groups of developers now, I thought it might make for a good caveat in the docs.
* | | Require only the concurrent/map featureRafael Mendonça França2015-12-231-1/+1
| | |
* | | release notes, Rails 5 won't support the protected_attribtues gem.Yves Senn2015-12-231-0/+3
| | | | | | | | | | | | [ci skip]
* | | release notes, extracted notable changes from Active Record CHANGELOG.Yves Senn2015-12-232-11/+176
| | | | | | | | | | | | [ci skip]
* | | release notes, extract notable changes from Active Model CHANGELOG.Yves Senn2015-12-231-0/+28
| | | | | | | | | | | | [ci skip]
* | | release notes, extract notable changes from Active Job CHANGELOG.Yves Senn2015-12-232-4/+17
| | | | | | | | | | | | [ci skip]
* | | release notes, extract notable changes from Active Support CHANGELOG.Yves Senn2015-12-232-13/+128
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #22769 from ↵Richard Schneeman2015-12-231-2/+2
|\ \ \ | | | | | | | | | | | | | | | | prathamesh-sonpatki/fix-typos-in-5-0-release-notes Fix typos in Rails 5.0 release notes [ci skip]
| * | | Fix typos in Rails 5.0 release notes [ci skip]Prathamesh Sonpatki2015-12-231-2/+2
|/ / /
* | | Merge pull request #22760 from reshleman/re-numericality-with-stringsSean Griffin2015-12-222-2/+51
|\ \ \ | | | | | | | | Fix Regression in Numericality Validations
| * | | Convert non-`Numeric` values to FloatsRobert Eshleman2015-12-221-1/+1
| | | |
| * | | Fix Regression in Numericality ValidationsRobert Eshleman2015-12-221-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A regression (#22744) introduced in 7500dae caused certain numericality validations to raise an error when run against an attribute with a string value. Previously, these validations would successfully run against string values because the value was cast to a numeric class. This commit resolves the regression by converting string values to floats before performing numericality comparison validations. [fixes #22744]
| * | | Failing Tests for Validating String NumbericalityRobert Eshleman2015-12-221-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Covers Regressions: * <= * < * == * > * >= * other than
* | | | Merge pull request #22762 from djpowers/patch-1Rafael França2015-12-221-1/+1
|\ \ \ \ | |/ / / |/| | | Fix letter case and grammar in Routing guide
| * | | Fix letter case and grammar in Routing guideDave Powers2015-12-221-1/+1
|/ / /
* | | Merge pull request #22620 from kamipo/join_to_delete_is_same_as_join_to_updateRafael França2015-12-223-11/+5
|\ \ \ | | | | | | | | `join_to_delete` is same as `join_to_update`
| * | | `join_to_delete` is same as `join_to_update`Ryuta Kamizono2015-12-173-11/+5
| | | | | | | | | | | | | | | | Reapply #22615.
* | | | Currectly test the Middleware#==Rafael Mendonça França2015-12-221-4/+8
| | | |
* | | | Merge pull request #22743 from maclover7/fix-22738Rafael Mendonça França2015-12-222-0/+21
|\ \ \ \ | | | | | | | | | | | | | | | Add #== back to ActionDispatch::MiddlewareStack::Middleware
| * | | | Add #== back to ActionDispatch::MiddlewareStack::MiddlewareJon Moss2015-12-212-0/+21
| | |/ / | |/| | | | | | | | | | | | | | This was causing bug #22738 to occur. Also added extra tests to make sure everything is A-OK.
* | | | Merge pull request #22749 from sblackstone/mysql2flagsMatthew Draper2015-12-232-2/+14
|\ \ \ \ | | | | | | | | | | Add support for passing flags to MySQL2 adapter by array
| * | | | Add support for passing flags to MySQL2 adapter by arrayStephen Blackstone2015-12-222-2/+14
| | |_|/ | |/| |
* | | | Merge pull request #22757 from paulkogel/patch-1Rafael França2015-12-221-1/+1
|\ \ \ \ | | | | | | | | | | seeds.rb.tt: fix English.
| * | | | seeds.rb.tt: fix English.Paul Kögel2015-12-221-1/+1
| | | | |
* | | | | Merge pull request #22758 from LaurierMantel/release_5_0_typoArun Agrawal2015-12-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | fixes typo in 5.0 release notes
| * | | | | fixes typo in 5.0 release notesLaurier Mantel2015-12-221-1/+1
|/ / / / /
* | | | | Merge pull request #22755 from y-yagi/remove_cors_initializer_from_rails_appSean Griffin2015-12-222-0/+12
|\ \ \ \ \ | |/ / / / |/| | | | remove cors initializer from rails app
| * | | | remove cors initializer from rails appyuuji.yaginuma2015-12-222-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | `rack-cors` gem is defined in Gemfile by default only if the api, not defined by default in rails app.
* | | | | release notes, extract notable changes from Action Mailer CHANGELOG.Yves Senn2015-12-222-3/+21
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | release notes, extract notable changes from Action View CHANGELOG.Yves Senn2015-12-222-7/+28
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | release notes, use past tense. [ci skip]Yves Senn2015-12-221-15/+15
| | | | |
* | | | | release notes, extract notable changes from Action Pack CHANGELOG.Yves Senn2015-12-222-24/+139
| | | | | | | | | | | | | | | | | | | | [ci skip]