aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * Solve some warnings and a failing test.José Valim2010-10-032-1/+2
| | |
| | * Move ETag and ConditionalGet logic from AD::Response to the middleware stack.José Valim2010-10-037-216/+51
| | |
| | * Rely on Rack::Session stores API for more compatibility across the Ruby world.José Valim2010-10-039-346/+90
| |/
| * PERF: more Hash + map changesSantiago Pastorino2010-10-031-3/+3
| |
| * PERF: more changes from inject({}) to Hash + mapSantiago Pastorino2010-10-031-1/+1
| |
| * PERF: Don't create unnecessary objectsSantiago Pastorino2010-10-031-1/+1
| |
| * PERF: change inject({}) with Hash + mapSantiago Pastorino2010-10-031-1/+1
| |
| * PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵Santiago Pastorino2010-10-031-3/+3
| | | | | | | | faster than var.sub('@', '')
| * Rename _assigns to view_assigns in AV::TCDavid Chelimsky2010-10-032-9/+52
| | | | | | | | | | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Be more explicit about what is deprecated.José Valim2010-10-021-1/+1
| |
| * Deprecate generators in Railties. You should use app_generators instead.José Valim2010-10-023-30/+32
| |
| * :'' is not valid ruby.José Valim2010-10-021-1/+1
| |
| * added test for form_for with search_fieldAditya Sanghi2010-10-021-0/+15
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * Fixing search_field to remove object attribute from options hash [#5730 ↵Aditya Sanghi2010-10-021-1/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * reload_routes! is part of the public API and should not be removed.José Valim2010-10-023-3/+16
| |
| * Fix a routing test. Reorganize middleware tests.José Valim2010-10-027-151/+180
| |
| * Refactor AssociationCollection#include? with objects in memoryCarlos Antonio da Silva2010-10-021-4/+3
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵José Valim2010-10-021-1/+5
| | | | | | | | | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9.
| * removing more duplicate code. :'(Aaron Patterson2010-10-011-13/+1
| |
| * fixing warnings with regexps on assert_matchAaron Patterson2010-10-011-2/+2
| |
| * removing more duplicate codeAaron Patterson2010-10-013-30/+17
| |
| * delete repeated codeAaron Patterson2010-10-013-36/+18
| |
| * remove another lolinjectAaron Patterson2010-10-011-1/+1
| |
| * use a method that actually existsAaron Patterson2010-10-011-1/+1
| |
| * speed up index_by by removing a lolinjectAaron Patterson2010-10-011-4/+1
| |
| * removing AS::Testing::Default in favor of just undefing default_testAaron Patterson2010-10-014-20/+2
| |
| * brings csrf_meta_tags back to the generated layoutXavier Noria2010-10-022-2/+2
| | | | | | | | | | | | | | | | | | | | After more discussion, it has be agreed that this kind of changes within reasonable margins are OK for 3.1. That is, it is fine to change a little bit the generators even if that means examples in existing books won't be exact. (Note that the singular csrf_meta_tag exists as an alias and thus those outdated examples will run, same for existing applications.)
| * Arel::Sql::Engine.new does not do anything anymoreAaron Patterson2010-09-302-2/+2
| |
| * type_name should check for blank because people may have messed up databasesAaron Patterson2010-09-302-1/+15
| |
| * build_where should be privateAaron Patterson2010-09-301-2/+2
| |
| * type_name is never a blank string, so use faster .nil? callAaron Patterson2010-09-301-1/+1
| |
| * AssociationCollection#include? working properly for objects added with build ↵Marcelo Giorgi2010-09-304-0/+39
| | | | | | | | method [#3472 state:resolved]
| * speeding up object instantiation by eliminating instance_evalAaron Patterson2010-09-301-7/+21
| |
| * changing map and include to findAaron Patterson2010-09-301-1/+1
| |
| * [#5441 state:resolved] refactoring code to determine aggregate columnAaron Patterson2010-09-301-11/+14
| |
| * group clause must be more specificAaron Patterson2010-09-301-1/+1
| |
| * Tests proving #5441oleg dashevskii2010-09-301-1/+11
| |
* | Refactoring JoinDependency and friends. This improves the code (IMO) ↵Jon Leighton2010-10-0610-209/+356
| | | | | | | | including adding some explanatory comments, but more importantly structures it in such a way as to allow a JoinAssociation to produce an arbitrary number of actual joins, which will be necessary for nested has many through support. Also added 3 tests covering functionality which existed but was not previously covered.
* | A failing test for a nested has many through association loaded via ↵Jon Leighton2010-10-051-0/+6
| | | | | | | | Foo.joins(:bar)
* | Fix the tests (I have actually verified that these are also the 'right' ↵Jon Leighton2010-10-036-24/+24
| | | | | | | | fixes, rather than just making the tests pass again)
* | Add support for table aliasing, with a test that needs aliasing in order to ↵Jon Leighton2010-10-027-15/+75
| | | | | | | | work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism).
* | Integrate nested support into ThroughAssociationScope, using my concept of ↵Jon Leighton2010-10-025-59/+107
| | | | | | | | generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though.
* | Started implementing nested :through associations by using the existing ↵Jon Leighton2010-10-014-32/+60
| | | | | | | | structure of ThroughAssociationScope rather than layering a module over the top
* | Prevent ↵Jon Leighton2010-09-301-2/+2
| | | | | | | | test_has_many_through_a_has_many_through_association_on_through_reflection failing for me due to ordering of the results
* | Merge branch 'master' into nested_has_many_through_2Jon Leighton2010-09-30166-849/+1536
|\|
| * Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵yalab2010-09-301-1/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * no need to check for nilNeeraj Singh2010-09-301-1/+1
| |
| * assert on empty array is always true. fixing test.Neeraj Singh2010-09-301-1/+1
| |
| * Revert "removing crazy finalizer code until there is proof that we need it"José Valim2010-09-301-0/+11
| | | | | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78.
| * Add more information to comments.José Valim2010-09-301-3/+5
| |