Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #9597 from senny/9110_serialized_not_null_default | Rafael Mendonça França | 2013-03-07 | 4 | -0/+13 |
|\ | | | | | test case for `serialize` default values. | ||||
| * | test case for `serialize` default values. | Yves Senn | 2013-03-07 | 4 | -0/+13 |
| | | | | | | | | Closes #9110 | ||||
* | | Merge pull request #9105 from bemurphy/cache_key_updated_on | Rafael Mendonça França | 2013-03-07 | 5 | -3/+39 |
|\ \ | |/ |/| | | | | | | | | | cache_key consults updated_on timestamp if present Conflicts: activerecord/CHANGELOG.md | ||||
| * | cache_key consults updated_on timestamp if present | Brendon Murphy | 2013-02-26 | 5 | -3/+39 |
| | | | | | | | | | | - Extract max timestamp retrieval for cache_key - Update changelog for cache_key changes | ||||
* | | Merge pull request #9474 from HonoreDB/master | Rafael Mendonça França | 2013-03-07 | 3 | -0/+21 |
|\ \ | | | | | | | | | | | | | | | | | | | More helpful error message when instantiating an abstract class Conflicts: activerecord/CHANGELOG.md | ||||
| * | | More helpful error message when instantiating an abstract class | Aaron Weiner | 2013-03-03 | 3 | -0/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling a literal ActiveRecord::Base.new raises NoMethodError, since it ends up calling Class.abstract_class? which does not exist. Similarly, instantiating an actual abstract class hits the database, when conventionally it should immediately throw NotImplementedError. ActiveRecord::Base can't be made abstract without breaking many, many things, so check for it separately. | ||||
* | | | Merge pull request #9545 from senny/9535_secure_password_blank | Rafael Mendonça França | 2013-03-07 | 5 | -3/+75 |
|\ \ \ | | | | | | | | | `has_secure_password` is not invalid when assigning empty Strings | ||||
| * | | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 3 | -2/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | ||||
| * | | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 3 | -1/+51 |
| | | | | |||||
* | | | | Merge pull request #9595 from senny/remove_non_breaking_spaces | Rafael Mendonça França | 2013-03-07 | 2 | -4/+4 |
|\ \ \ \ | | | | | | | | | | | replace non-breaking spaces with normal spaces [ci skip] | ||||
| * | | | | replace non-breaking spaces with normal spaces [ci skip] | Yves Senn | 2013-03-07 | 2 | -4/+4 |
| | | | | | |||||
* | | | | | Merge pull request #9596 from choudhuryanupam/master | Rafael Mendonça França | 2013-03-07 | 1 | -3/+3 |
|\ \ \ \ \ | |/ / / / |/| | | | | Refactored the code to remove irrelevant lines | ||||
| * | | | | Refactored and removed unnecessary lines in the test case | Anupam Choudhury | 2013-03-07 | 1 | -3/+3 |
|/ / / / | |||||
* | | | | Remove regression test added in 0268b5d8cdc3c5a1337462135f0a326a2654ba1a | Rafael Mendonça França | 2013-03-07 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | It was added because a regression caused by a712e08ebe21f6d8653a0e6602df2e0f5d40d9ca Closes #9255 | ||||
* | | | | debugger 1.4.0 works in Ruby 2.0 | Santiago Pastorino | 2013-03-06 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #9586 from robertomiranda/useless_tr | Rafael Mendonça França | 2013-03-06 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Change useless tr to gsub | ||||
| * | | | | Change useless tr to gsub | robertomiranda | 2013-03-06 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Merge pull request #9538 from senny/remove_structure_dump | Rafael Mendonça França | 2013-03-06 | 8 | -37/+24 |
|\ \ \ \ \ | | | | | | | | | | | | | `Connection#structure_dump` is no longer used | ||||
| * | | | | | rake db:structure:dump warns when `mysqldump` is not in PATH. | Yves Senn | 2013-03-06 | 3 | -2/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9518. The rake task used to fail silently and left an empty `structure.sql`. It's confusing for users to get to the root of the problem. The warning message tells them where to look. | ||||
| * | | | | | `Connection#structure_dump` is no longer used. #9518 | Yves Senn | 2013-03-06 | 6 | -35/+2 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base. | ||||
* | | | | | Merge pull request #9507 from senny/9483_migrations_without_transactions | Rafael Mendonça França | 2013-03-06 | 5 | -12/+97 |
|\ \ \ \ \ | | | | | | | | | | | | | Transactions can be turned off per Migration | ||||
| * | | | | | transactions can be turned off per Migration. | Yves Senn | 2013-03-05 | 5 | -9/+90 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9483. There are SQL Queries that can't run inside a transaction. Since the Migrator used to wrap all Migrations inside a transaction there was no way to run these queries within a migration. This patch adds `self.disable_ddl_transaction!` to the migration to turn transactions off when necessary. | ||||
| * | | | | | transactional migration test-case was broken. | Yves Senn | 2013-03-05 | 1 | -3/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cleanup commit a85625d broke the test-case. The schema was no longer modified so there was no way to check that the rollback actually happened. | ||||
* | | | | | | Merge pull request #9585 from RKushnir/patch-1 | Carlos Antonio da Silva | 2013-03-06 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Typo in comment to ActionView::Resolver#find_all | ||||
| * | | | | | | Typo in comment to ActionView::Resolver#find_all | RKushnir | 2013-03-06 | 1 | -1/+1 |
|/ / / / / / | |||||
* | | | | | | Merge pull request #9581 from senny/9559_changelog_singularizing_singular | Xavier Noria | 2013-03-06 | 1 | -1/+14 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | CHANGELOG entry for improved singularizing of singulars. | ||||
| * | | | | | | CHANGELOG entry for improved singularizing of singulars. | Yves Senn | 2013-03-06 | 1 | -1/+14 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9559. The actual patch was added with #4719 | ||||
* | | | | | | Add missing require to debug helper test | Carlos Antonio da Silva | 2013-03-05 | 1 | -2/+2 |
| | | | | | | |||||
* | | | | | | Merge pull request #9574 from robertomiranda/debug_helper_test | Rafael Mendonça França | 2013-03-05 | 1 | -0/+8 |
|\ \ \ \ \ \ | | |/ / / / | |/| | | | | Add DebugHelperTest | ||||
| * | | | | | Add DebugHelperTest | robertomiranda | 2013-03-05 | 1 | -0/+8 |
|/ / / / / | |||||
* | | | | | Merge pull request #9565 from kennyj/remove_unused_return_value | Xavier Noria | 2013-03-05 | 3 | -5/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove unused return value, because collecting_queries_for_explain isn't public API. | ||||
| * | | | | | Remove unused return value, because collecting_queries_for_explain isn't ↵ | kennyj | 2013-03-06 | 3 | -5/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | public API. | ||||
* | | | | | | Merge pull request #9573 from robertomiranda/useless_gsub | Guillermo Iguaran | 2013-03-05 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Use gsub intead of tr when the to_str is longer than the from_str | ||||
| * | | | | | | Use gsub intead of tr when the to_str is longer than the from_str | robertomiranda | 2013-03-05 | 1 | -1/+1 |
|/ / / / / / | |||||
* | | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-05 | 8 | -11/+9 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | |||||
| * | | | | | Fix typo | Carson McDonald | 2013-03-05 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | Remove reference to BugMash. Link hasn't been updated in 4 years. | Jonathan Roes | 2013-03-05 | 1 | -2/+0 |
| | | | | | | |||||
| * | | | | | Fix WhereChain docs to mention only not | Ernie Miller | 2013-03-04 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | Small Typo | Lebin Sebastian F | 2013-03-04 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | Add explanation of :dependent => :restrict | David Deller | 2013-03-01 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | Based on information here: http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many | ||||
| * | | | | | Reverting commit regarding public/index.html (no longer in Rails 4.) | Christine Hertzel | 2013-03-01 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f8461f73c77c186ad0aa735fe9877990bffe1990. | ||||
| * | | | | | Fixed grammatical error and simplified paragraph concerning controllers. | Christine Hertzel | 2013-03-01 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Chelsea Macaluso <c.macaluso@modcloth.com> | ||||
| * | | | | | Clarified removal of public/index.html file | Chelsea Macaluso | 2013-03-01 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Trent Michaels <t.michaels@modcloth.com> | ||||
| * | | | | | Clarified need to remove existing code in welcome index. | Trent Michaels | 2013-03-01 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Chelsea Macaluso <c.macaluso@modcloth.com> | ||||
| * | | | | | fix broken links to README docs in intro | Mike Munroe | 2013-02-28 | 1 | -2/+2 |
| | | | | | | |||||
| * | | | | | change log4r link to most recent, updated location | Mike Munroe | 2013-02-28 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #9564 from robertomiranda/useless_gsub | Guillermo Iguaran | 2013-03-05 | 4 | -5/+5 |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | change useless gsub to tr | ||||
| * | | | | | change useless gsub to tr | robertomiranda | 2013-03-05 | 4 | -5/+5 |
|/ / / / / | |||||
* | | | | | Merge pull request #9042 from senny/9034_float_0_0_is_always_dirty | Carlos Antonio da Silva | 2013-03-05 | 3 | -1/+32 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Assigning '0.0' to a nullable numeric column does not make it dirty Example: product = Product.create price: 0.0 product.price = '0.0' product.changed? # => false (this used to return true) product.changes # => {} (this used to return { price: [0.0, 0.0] }) | ||||
| * | | | | | assigning '0.0' to a nullable numeric column does not make it dirty | Yves Senn | 2013-03-05 | 3 | -1/+32 |
| | | | | | |