| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Supports the `touch` option from update_counters.
The default behavior is not to update timestamp columns.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
in case Array or any other ancestor class' respond_to_missing? was defined.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`type_condition` should be overwritten by `create_with_value` in `scope_for_create`
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`scope_for_create`
`type_condition` should be overwritten by `create_with_value`. So `type`
in `create_with_value` should be a string because `where_values_hash`
keys are converted to string.
Fixes #27600.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Small spelling error
|
|/ / / / /
| | | | |
| | | | | |
existing_acrnoyms -> existing_acronyms
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If a process is forked more than once, the pool was grabbing the oldest
spec, not the most recent spec. This wasn't noticed before because most
folks are lilely forking the process only once.
If you're forking the process multiple times however the wrong spec name
will be returned and an incorrect connection will be used for the
process.
This fixes the issue by reversing the list of spec names so we can grab
the most recent spec rather than the oldest spec.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
CI against JRuby 9.1.7.0
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix missing bracket.
|
|/ / / / / /
| | | | | |
| | | | | | |
Fix missing left bracket in exception message.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Update builder gem to avoid deprecations of 2.4
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix grammar in asset_url_helper.rb [ci skip]
|
|/ / / / / |
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
See: https://github.com/ruby/ruby/commit/44a2576f798b07139adde2d279e48fdbe71a0148
https://github.com/ruby/ruby/commit/9df88e9cae57aa421230f14500e88f33f127414f
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
it has some methods that override the accessors and calls the original accessors via `super`
this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
it has some methods that override the accessors and calls the original accessors via `super`
this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
|
| | | |
| | | |
| | | |
| | | | |
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
|\ \ \ \
| |_|/ /
|/| | | |
Fix typo extention -> extension [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
fix method name in `Renderer` doc [ci skip]
|
|/ / /
| | |
| | |
| | | |
`ActionController::Renderer.defaults` was removed in 2db7304
|
| | |
| | |
| | |
| | |
| | | |
The Numeric extensions like 1.day, 1.month, etc. shouldn't know
how the internals of ActiveSupport::Duration works.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since 1.month no longer equals 30.days add some tests to ensure that
addition maintains the same day in the month or is the last day in
the month if the month has less days than the current day. Also add
a test for the behaviour of 12.months == 1.year.
|
| | |
| | |
| | |
| | | |
(I personally prefer writing one string in one line no matter how long it is, though)
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix inconsistent parsing of Durations with both months and years
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
durations from code
ActiveSupport::Duration.parse('P3Y') == 3.years # It should be true
Duration parsing made independent from any moment of time:
Fixed length in seconds is assigned to each duration part during parsing.
Changed duration of months and years in seconds to more accurate and logical:
1. The value of 365.2425 days in Gregorian year is more accurate
as it accounts for every 400th non-leap year.
2. Month's length is bound to year's duration, which makes
sensible comparisons like `12.months == 1.year` to be `true`
and nonsensical ones like `30.days == 1.month` to be `false`.
Calculations on times and dates with durations shouldn't be affected as
duration's numeric value isn't used in calculations, only parts are used.
Methods on `Numeric` like `2.days` now use these predefined durations
to avoid duplicating of duration constants through the codebase and
eliminate creation of intermediate durations.
|
|\ \ \ \
| |_|_|/
|/| | | |
remove unused requires
|
| | | |
| | | |
| | | |
| | | | |
Related to 0129ca2eeb6d5b2ea8c6e6be38eeb770fe45f1fa, f7782812f7e727178e4a743aa2874c078b722eef, f9ed83321ac1d1902578a0aacdfe55d3db754219
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 5eff7a9ca7bb2ee7f16db1ab4d11cebe28757ba5, reversing
changes made to 5f03172f54a58a57a48a3121562beb2cef866cbe.
Reason: It caused a regression. The test case is on the PR.
|
|\ \ \ \
| | | | |
| | | | | |
Add .byebug_history to .gitignore
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
railties/lib/rails/generators.rb
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Removes space from the word; is now spelled in the standard way.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix grammar in action_dispatch/http/parameters.rb [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Fix indent
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
than a ruby encoding
|
|/ / / / / |
|
| | | | | |
|