| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
If it's enabled globally, it's on regardless of how individual threads
are set.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
It'll be re-cleared when it's rebuilt in with_new_connections_blocked's
ensure, but we still need to clear it inside this synchronize -- we've
disconnected connections that may be available in the queue, and while
other threads are not allowed to make *new* connections, they are still
allowed to take existing ones from there.
This was incorrectly removed in d314646c965b045724e6bdb9d61dcecfabc0ba8f.
|
|\
| |
| | |
Update RELEASING_RAILS.md for rails-ujs
|
|/
|
|
| |
[ci skip]
|
|\
| |
| | |
Add asset compilation Rake task for UJS
|
|/
|
|
|
| |
Uses same build pipeline (Blade) as Action Cable. Will run when Rails
gems are being built for release.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
I assume it's upset because of the change in d314646c965b045724e6bdb9d61dcecfabc0ba8f,
but I don't yet understand why.
|
|\
| |
| | |
use correct variable in BacktraceCleaner test
|
|/
|
|
| |
`@target_dir` variable was changed to local variable in 8e1714b.
|
| |
|
|\
| |
| |
| |
| | |
supercaracal/fix-force-ssl-if-session-store-disabled
Fix a force ssl redirection bug that occur when session store disabled.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Adjust to indifferent access around some ActiveModel::Errors methods
|
| | |
| | |
| | |
| | |
| | |
| | | |
`#[]` has already applied indifferent access, but some methods does not.
`#include?`, `#has_key?`, `#key?`, `#delete` and `#full_messages_for`.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/followup-uuid-extension-change
Followup of UUID default extension in the docs
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Mentioned clearly that for PostgreSQL < 9.4, you need to pass the
default option with "uuid_generate_v4()"
- Also updated PostgreSQL Active Record guide with this change.
- https://github.com/rails/rails/pull/25395#r66877078
|
|\ \ \ \
| | | | |
| | | | | |
`Broadcast#silence` breaks custom loggers that do not include `Logg…
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix `require_dependency` message format
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`depend_on` message format is `"No such file to load -- %s.rb"`.
But `require_dependency` message is missing `.rb` suffix.
```
% git grep -n 'No such file to load'
actionview/test/actionpack/abstract/helper_test.rb:112: assert_equal "No such file to load -- very_invalid_file_name.rb", e.message
activesupport/lib/active_support/dependencies.rb:245: def require_dependency(file_name, message = "No such file to load -- %s.rb")
activesupport/lib/active_support/dependencies.rb:333: def depend_on(file_name, message = "No such file to load -- %s.rb")
```
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix warning: method redefined; discarding old fields
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
Follow up to #26976.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Should test `test_change_column_default` in `PostgresqlUUIDTest`
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Follow up to #25395.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Suppress migration message in the test
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove blank else block
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Distribute connections to previously blocked threads when we're done
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Two methods block new connections; we were already doing the right thing
for clear_reloadable_connections, but it's better placed in
with_new_connections_blocked, where it can work for disconnect too.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Restore RecordNotFound when *_ids= can't find records by ID
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes casting of IDs to the data type of the association primary key,
rather than then the data type of the model's primary key. (Tests use a
string primary key on the association, rather than an int.)
Tests issue #20995
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
9c9fb19 changed the behaviour of the _ids= setters for associations to
raise an AssociationTypeMismatch when unknown IDs are given:
Class: <ActiveRecord::AssociationTypeMismatch>
Message: <"Developer(#43811860) expected, got NilClass(#16732720)">
This restores the original ActiveRecord::RecordNotFound exception with a
much clearer error message:
Class: <ActiveRecord::RecordNotFound>
Message: <"Couldn't find all Developers with 'id': (1, -9999) [WHERE \"contracts\".\"company_id\" = ?] (found 1 results, but was looking for 2)">
Fixes #25719
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
[ci skip] `MiniTest` -> `Minitest`
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
MiniTest was renamed to Minitest.
Already renamed on https://github.com/rails/rails/pull/13366
But slipped into on https://github.com/rails/rails/pull/18413/files#diff-6bb90a693835b0e92910b796c8b0ef59R27
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
yawboakye/use_gen_random_uuid_from_pgcrypto_extension
For PostgreSQL >= 9.4 use `gen_random_uuid()`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since 9.4, PostgreSQL recommends using `pgcrypto`'s `gen_random_uuid()`
to generate version 4 UUIDs instead of the functions in the `uuid-ossp`
extension.
These changes uses the appropriate UUID function depending on the
underlying PostgreSQL server's version, while maintaining
`uuid_generate_v4()` in older migrations.
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Don't want to add defensive programming to this fairly
simple thing.
Fixes #27060.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead of appending a format to the request, it's much better
to just pass a more appropriate accept header. Rails will figure
out the format from that instead.
This allows devs to use `:as` on routes that don't have a format.
Introduce an `IdentityEncoder` to avoid `if request_encoder`,
essentially a better version of the purpose of the `WWWFormEncoder`.
One that makes conceptual sense on GET requests too.
Fixes #27144.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Drop jQuery as a dependency
|
| | | | | | |
|
| | | | | | |
|
| | |_|_|/
| |/| | | |
|