| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add a new-line to the end of route method generated code.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix regression on route method that was added by
bac812a7ef2660a2fe2ab00822e5e66228379822. The regression was that when
calling the `route` method, we were not appending a \n anymore.
[fixes #19316]
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord: Add a changelog entry for issue #17680. [ci skip]
Conflicts:
activerecord/CHANGELOG.md
|
|\ \ \ \
| |_|_|/
|/| | | |
Active Record changelog pass [skip ci]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] use true as value rather than symbol
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
[skip ci] Fixed typo in asset pipeline documentation
|
|/ / / / |
|
|\| | |
| | | |
| | | | |
[ci skip] use false as value rather than symbol
|
|/ / / |
|
|\ \ \
| |/ /
|/| | |
Change commands in the Getting Started guide to use scripts in bin/ [ci skip]
|
|/ /
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a better test for 51660f0. It is testing that the SQL is the
same before and after the previously leaky scope is called. Before if
`hotel.drink_designers` was called first then `hotel.recipes` would
incorrectly get the scope applied. We want to be sure that the
polymorphic hm:t association is not leaking into or affecting the
SQL for the hm:t association on `Hotel`.
The reason I couldn't do this before was because there was an issue with
the SQL getting cached and wanted to resolve that later and then fix the
test to be better. Because of the caching, this test requires that
`Hotel.reflect_on_association(:recipes).clear_association_scope_cache`
be called after the first call to `hotel.recipes` to clear the
assocation scope chain and not interfere with the rest of the test.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the tests if I were to call `post.categorizations.to_a` and then later call
`post.categorizations.to_a` expecting to have different results the 2 queries
would be the same because of the caching involved in
`@association_scope_cache`. The chain gets cached and the queries will
be the same even if they are not supposed to be (i.e. testing an order
dependent scoping issue).
I found this issue because I was working on a bug with cached scoped
in hm:t and hm:t polymorphic relationships but `capture_sql` was
outputting the wrong SQL to write a good test.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove gem check in guides/rails_guides.rb
Conflicts:
guides/rails_guides.rb
|
| | |
| | |
| | |
| | |
| | | |
Now rails/Gemfile includes nokogiri and redcarpet,
so remove gem check from guides/rails_guides.rb
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This logic was just doing duplicated work, since the button_to helper
relies on tag/content_tag to generate the button html, which already
handles all boolean attributes it knows about.
The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Reuse the CollectionAssociation#reader proxy cache if the foreign key is present from the start.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
present from the start.
When a new record has the necessary information prior to save, we can
avoid busting the cache.
We could simply clear the @proxy on #reset or #reset_scope, but that
would clear the cache more often than necessary.
|
|\ \ \ \
| | | | |
| | | | | |
Make example code consistent for better understanding. [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Update old link in pessimistic.rb comments [ci skip]
|
|/ / / /
| | | |
| | | | |
Update link in comments to point to latest MySQL production version documentation. See here for reference: http://dev.mysql.com/doc/refman/5.0/en/choosing-version.html
|
|\ \ \ \
| |/ / /
|/| | | |
Fix NullRelation.update_all and .exists? signature to match the same on Relation
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix wrong model name for 'Articles', It should be 'Article' [ci skip]
|
|/ / /
| | |
| | |
| | | |
- Also changed 'a' to 'an' for 'Article' word.
|
|\ \ \
| | | |
| | | | |
Compare content_type with Mime::XML instead of regexp
|
| |/ /
| | |
| | |
| | |
| | | |
Regexp is broken for both content types including charsets and for
integration tests, where the content_type is a Mime::Type and not String
|
|\ \ \
| | | |
| | | | |
Skip the `:race_condition_ttl` branch if the option is 0 or nil.
|
| | | |
| | | |
| | | |
| | | | |
an issue with the redis cache, where this code will sometimes throw an error out of SETEX when passing 0 as the `expires_at`.
|
|\ \ \ \
| | | | |
| | | | | |
Add config.active_record.dump_schemas.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes db:structure:dump when using schema_search_path and PostgreSQL
extensions.
Closes #17157.
|
|\ \ \ \
| | | | |
| | | | | |
Drop `references_eager_loaded_tables?` test from `has_include?`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It is redundant with tests in `eager_loading?`, but for the difference
between `includes_values.present?` and `includes_values.any?`, which
is a difference without a distinction because `false` has no meaning
for `includes`.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix deprecation warning in rails_info_controller tests
|
|/ / / /
| | | |
| | | |
| | | | |
Use keyword arguments in request methods
|
|\ \ \ \
| | | | |
| | | | | |
Remove unused variable in activerecord reflection_test.
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] reflection doc fix about hierarchy
|
|/ / / / |
|