Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #35841 from robertomiranda/r/rake-db-prepare-changelog | Ryuta Kamizono | 2019-04-03 | 1 | -0/+4 |
|\ | | | | | | | | | Add rake db:prepare entry to the CHANGELOG.md [ci skip] | ||||
| * | Add rake db:prepare entry to the CHANGELOG.md | Roberto Miranda | 2019-04-03 | 1 | -0/+4 |
|/ | |||||
* | Don't normalize `original_app_name` | Ryuta Kamizono | 2019-04-03 | 1 | -2/+2 |
| | | | | | `original_app_name` is used to show error message if giving app name is invalid, it should be shown raw app name. | ||||
* | `bytes_margin` is only needed when `previous_packet` exists | Ryuta Kamizono | 2019-04-03 | 1 | -5/+2 |
| | |||||
* | Merge pull request #35840 from ↵ | Ryuta Kamizono | 2019-04-03 | 1 | -1/+1 |
|\ | | | | | | | | | abhaynikam/24405-update-honor-shallow-false-option-doc [ci skip] Doc for shallow: false options should use <tt> for better readability. | ||||
| * | [ci skip] Doc for shallow: false options should use <tt> for better ↵ | Abhay Nikam | 2019-04-03 | 1 | -1/+1 |
| | | | | | | | | readability. PR after #24405 | ||||
* | | Don't assign to `@changed_attributes` in `becomes` | Ryuta Kamizono | 2019-04-03 | 1 | -1/+0 |
|/ | | | | `@changed_attributes` is no longer used since #30985. | ||||
* | Use official database name [ci skip] | Ryuta Kamizono | 2019-04-03 | 7 | -11/+11 |
| | | | | | | | | * s/Postgres/PostgreSQL/ * s/MYSQL/MySQL/, s/Mysql/MySQL/ * s/Sqlite/SQLite/ Replaced all newly added them after 6089b31. | ||||
* | Fix the markup for `insert_all` and `upsert_all` docs [ci skip] | Ryuta Kamizono | 2019-04-03 | 1 | -7/+7 |
| | |||||
* | Remove duplicated CHANGELOG entry [ci skip] | Ryuta Kamizono | 2019-04-03 | 1 | -2/+0 |
| | |||||
* | Merge pull request #35833 from soartec-lab/update_guide_caching | Ryuta Kamizono | 2019-04-03 | 1 | -1/+1 |
|\ | | | | | Fixed description of the `cache_key_with_version` method [skip ci] | ||||
| * | Fixed description of the `cache_key_with_version` method [ci skip] | soartec-lab | 2019-04-03 | 1 | -1/+1 |
| | | |||||
* | | Auto-correct rubocop offences | Ryuta Kamizono | 2019-04-03 | 2 | -17/+17 |
| | | |||||
* | | Add `after_save_commit` callback as shortcut for `after_commit :hook, on: [ ↵ | David Heinemeier Hansson | 2019-04-02 | 3 | -0/+24 |
| | | | | | | | | :create, :update ]`. (#35804) | ||||
* | | Merge pull request #24405 from waits/shallow-false | Rafael França | 2019-04-02 | 2 | -1/+35 |
|\ \ | | | | | | | Honor shallow: false on nested resources | ||||
| * | | Honor shallow: false on nested resources | Dylan Waits | 2016-04-03 | 2 | -1/+35 |
| | | | | | | | | | | | | | | | | | | | | | | | | Previously there was no way to place a non-shallow resource inside a parent with `shallow: true` set. Now you can set `shallow: false` on a nested child resource to generate normal (non-shallow) routes for it. Fixes #23890. | ||||
* | | | Merge pull request #35805 from excid3/attachments-field-generators | Rafael França | 2019-04-02 | 13 | -25/+130 |
|\ \ \ | | | | | | | | | Add attachment and attachments field generators | ||||
| * | | | Add attachment and attachments field generators | Chris Oliver | 2019-03-30 | 13 | -25/+130 |
| | | | | |||||
* | | | | Merge pull request #35771 from timoschilling/hash-speed-improvements | Rafael França | 2019-04-02 | 2 | -4/+7 |
|\ \ \ \ | | | | | | | | | | | Hash / HashWithIndifferentAccess speed improvements | ||||
| * | | | | Speed improvement for HashWithIndifferentAccess#values_at | Timo Schilling | 2019-04-02 | 1 | -2/+2 |
| | | | | | |||||
| * | | | | Speed improvement for HashWithIndifferentAccess#fetch_values | Timo Schilling | 2019-04-02 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Speed improvement for HashWithIndifferentAccess#except | Timo Schilling | 2019-04-01 | 1 | -0/+3 |
| | | | | | |||||
| * | | | | Speed improvement for Hash#except | Timo Schilling | 2019-03-29 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Simplify ActionCable.createWebSocketURL and realphabetize exports (#35810) | rmacklin | 2019-04-02 | 4 | -12/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove unnecessary variable from ActionCable.createWebSocketURL * Improve ActionCable test by creating the Consumer before reassigning URL With this change, the test now actually verifies that the Consumer's url property changes dynamically (from testURL to `${testURL}foo`). * Fix alphabetization of ActionCable exports | ||||
* | | | | | Merge pull request #35768 from robertomiranda/r/rake-db-prepare | Eileen M. Uchitelle | 2019-04-02 | 3 | -0/+46 |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | Add db:prepare rake task. | ||||
| * | | | | Add migration in case of db:drop assertion | Roberto Miranda | 2019-04-02 | 1 | -0/+7 |
| | | | | | |||||
| * | | | | 💇 | Roberto Miranda | 2019-04-02 | 3 | -8/+5 |
| | | | | | |||||
| * | | | | Add test cases for rake db:prepare | Roberto Miranda | 2019-04-02 | 3 | -6/+39 |
| | | | | | |||||
| * | | | | Move db:migrate call to else block | Roberto Miranda | 2019-03-27 | 1 | -1/+2 |
| | | | | | |||||
| * | | | | Improve db:prepare description | Roberto Miranda | 2019-03-27 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Add rake db:prepare rake task. | Roberto Miranda | 2019-03-27 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It Creates the database, loads the schema, run the migrations and initializes with the seed data (use db:reset to also drop the database first). This rake task runs in an idempotent way ref https://github.com/rails/rails/pull/33139#discussion_r195930751 | ||||
* | | | | | Merge pull request #35831 from ↵ | Kasper Timm Hansen | 2019-04-02 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | abhaynikam/35826-updated-doc-template-rawfile-after-35826 [ci skip] Updated the doc after renaming Template::File -> Template::RawFile in #35826 | ||||
| * | | | | | [ci skip] Updated the doc after renaming Template::File -> Template::RawFile ↵ | Abhay Nikam | 2019-04-02 | 1 | -1/+1 |
|/ / / / / | | | | | | | | | | | | | | | | in #35826 | ||||
* | | | | | Merge pull request #35826 from cpruitt/rename-file-to-rawfile | Kasper Timm Hansen | 2019-04-02 | 5 | -5/+5 |
|\ \ \ \ \ | | | | | | | | | | | | | Rename `Template::File` to `Template::RawFile` | ||||
| * | | | | | Rename File to RawFile | Cliff Pruitt | 2019-04-01 | 5 | -5/+5 |
| | | | | | | |||||
* | | | | | | Merge pull request #35703 from y-yagi/add_database_option_to_dbconsole_command | Yuji Yaginuma | 2019-04-02 | 3 | -13/+42 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Rename `connection` option to `database` in `dbconsole` command | ||||
| * | | | | | | Rename `connection` option to `database` in `dbconsole` command | yuuji.yaginuma | 2019-04-02 | 3 | -13/+42 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We introduced `connection` option for specifying spec with 1acd9a6464668d4d54ab30d016829f60b70dbbeb. But now we are using the `database` to specify the same value in other commands. * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/migration/migration_generator.rb#L11 * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/model/model_generator.rb#L17 The options provided to the users should be uniform. Since the term "database" is used in rake task etc, So I want to be able to use it in `dbconsole` command. Also I deprecated the `connection` option because I think that it would be confusing if there are multiple options to specify a same value. | ||||
* | | | | | | | Merge pull request #35827 from abhaynikam/35824-fix-typo-in-changelog | Ryuta Kamizono | 2019-04-02 | 1 | -2/+2 |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | [ci skip] Fix typo for recieve -> receive | ||||
| * | | | | | | [ci skip] Fix typo for recieve -> receive | Abhay Nikam | 2019-04-02 | 1 | -2/+2 |
|/ / / / / / | |||||
* | | | | | | Merge pull request #35824 from connorshea/add-changelog-for-webdrivers | Rafael França | 2019-04-01 | 1 | -0/+6 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Add Changelog entry for #35732. | ||||
| * | | | | | Add Changelog entry for #35732. | Connor Shea | 2019-04-01 | 1 | -0/+6 |
|/ / / / / | |||||
* | | | | | [ci skip] Follow up c8bf334104 | Kasper Timm Hansen | 2019-04-01 | 1 | -1/+2 |
| | | | | | |||||
* | | | | | Only clear template caches in dev after changes (#35629) | John Hawthorn | 2019-04-01 | 6 | -7/+61 |
| | | | | | |||||
* | | | | | Merge pull request #35820 from sharang-d/url-to-URL-except-actionpack | Ryuta Kamizono | 2019-04-02 | 26 | -41/+41 |
|\ \ \ \ \ | | | | | | | | | | | | | url -> URL where apt except inside actionpack/ | ||||
| * | | | | | url -> URL where apt except inside actionpack/ | Sharang Dashputre | 2019-04-01 | 26 | -41/+41 |
| | | | | | | |||||
* | | | | | | Merge pull request #35821 from sharang-d/url-to-URL-in-actionpack | Ryuta Kamizono | 2019-04-02 | 10 | -24/+24 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | url -> URL where apt inside actionpack/ | ||||
| * | | | | | | url -> URL where apt inside actionpack/ | Sharang Dashputre | 2019-04-01 | 10 | -24/+24 |
| |/ / / / / | |||||
* | | | | | | Merge pull request #35819 from orhantoy/ruby-version-with-final-newline | Ryuta Kamizono | 2019-04-02 | 2 | -1/+3 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Include final newline in generated .ruby-version | ||||
| * | | | | | Include final newline in generated .ruby-version | Orhan Toy | 2019-04-01 | 2 | -1/+3 |
|/ / / / / | |||||
* | | | | | Merge pull request #35816 from ↵ | Ryuta Kamizono | 2019-04-02 | 15 | -147/+11 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/partly_revert_query_annotation_for_update_and_delete Revert unused code and re-using query annotation for `update_all` and `delete_all` |