Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Tighten the rescue clause when dealing with invalid instance variable names ↵ | Michael Koziarski | 2008-07-03 | 1 | -1/+5 | |
| | | | | in form_helper. | |||||
* | Move the file exists checks outside write_asset_file_contents. | Michael Koziarski | 2008-07-03 | 1 | -6/+4 | |
| | | | | This lets us avoid the relatively costly trip through compute_*_paths if the file already exists. | |||||
* | Move template_format logic out to the request so it's alongside the ↵ | Michael Koziarski | 2008-07-03 | 3 | -13/+15 | |
| | | | | | | 'regular' request format. Use xhr? instead of the expensive trip through Request#accepts. | |||||
* | Support for custom annotations with rake notes:custom and DRY up the task ↵ | Michael Koziarski | 2008-07-03 | 1 | -11/+8 | |
| | | | | | | definition. e.g. rake notes:custom ANNOTATION=WTF | |||||
* | Remove unused local_binding option to InstanceTag's Constructor | Michael Koziarski | 2008-07-03 | 3 | -17/+17 | |
| | ||||||
* | Remove nested ternary operators from select_year in favour of conditionals. | Michael Koziarski | 2008-07-03 | 1 | -11/+20 | |
| | ||||||
* | Remove unneeded ObjectWrapper class. | Michael Koziarski | 2008-07-03 | 3 | -11/+3 | |
| | | | | Was previously needed to work around the semantics of a deprecated (now removed) API to render :partial | |||||
* | Tighten the rescue clause here to prevent hiding strange mock related errors ↵ | Michael Koziarski | 2008-07-03 | 1 | -1/+1 | |
| | | | | behind the line offset test | |||||
* | Remove old method of including javascripts define_javascript_functions. | Michael Koziarski | 2008-07-03 | 3 | -34/+2 | |
| | | | | javascript_include_tag and friends do a much better job. | |||||
* | Remove strange alias for JavaScriptHelper | Michael Koziarski | 2008-07-03 | 1 | -2/+0 | |
| | ||||||
* | Use :namespace instead of :path_prefix for finding controller. [#544 ↵ | Tarmo Tänav | 2008-07-03 | 2 | -2/+21 | |
| | | | | | | | | | | state:resolved] :namespace is supposed to be the module where controller exists. :path_prefix can contain anything, including variables, which makes it unsuitable for determining the module for a controller. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Changing order of equality because comparing certain objects with false ↵ | Lucas Carlson | 2008-07-02 | 1 | -2/+2 | |
| | | | | | | | | | | | | | raises an error. >> require 'md5' => true >> MD5.new("Asds") == false TypeError: can't convert false into String from (irb):2:in `==' from (irb):2 >> false == MD5.new("Asds") => false | |||||
* | Deprecate :use_full_path render option. The supplying the option no longer ↵ | Joshua Peek | 2008-07-02 | 8 | -42/+45 | |
| | | | | has an effect. | |||||
* | Added Rails.initialized? flag | Joshua Peek | 2008-07-02 | 2 | -23/+34 | |
| | ||||||
* | Added application/jsonrequest as a synonym for application/json | Mike Subelsky | 2008-07-02 | 2 | -5/+12 | |
| | | | | [#536 state:resolved] | |||||
* | use mocha for TimeZone mocking in Form Options helper tests | rick | 2008-07-02 | 1 | -504/+495 | |
| | ||||||
* | Ensure script/plugin unsource 'Usage' text is correct. [#526 state:resolved] | Ricardo Santos | 2008-07-02 | 1 | -1/+1 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Make sure render :collection doesnt set nil local when :as is absent | Pratik Naik | 2008-07-02 | 3 | -1/+8 | |
| | ||||||
* | Add :as option to render a collection of partials with a custom local ↵ | Pratik Naik | 2008-07-02 | 8 | -12/+39 | |
| | | | | variable name. [#509 state:resolved] [Simon Jefford, Pratik Naik] | |||||
* | Add Inflection rules for String#humanize. [#535 state:resolved] [dcmanges] | Pratik Naik | 2008-07-02 | 3 | -8/+51 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Make rake test:uncommitted work with Git. | Tim Pope | 2008-07-02 | 2 | -4/+12 | |
| | | | | | | Note : rake test:uncommitted is considering only unstaged files. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Make sure render :template works with :locals. [#524 state:resolved] | Tim Haines | 2008-07-02 | 2 | -1/+13 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Improved test coverage and added RackRequest support for CGI environment ↵ | Joshua Peek | 2008-07-01 | 3 | -22/+154 | |
| | | | | variables. | |||||
* | Ensure Rails::Generator quotes file names while generating diff. [#264 ↵ | Carl Porth | 2008-07-02 | 1 | -1/+1 | |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ensure AssociationCollection#size considers all unsaved record. [#305 ↵ | Pratik Naik | 2008-07-02 | 2 | -1/+8 | |
| | | | | | | state:resolved] [sds] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ensure proper output when submit_tag is used with :disabled_with. [#388 ↵ | Scott Stewart | 2008-07-02 | 2 | -2/+11 | |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | TimeWithZone#advance: treat :weeks option as variable-length | gbuesing | 2008-06-29 | 1 | -2/+2 | |
| | ||||||
* | TimeWithZone: when crossing DST boundary, treat Durations of days, months or ↵ | gbuesing | 2008-06-29 | 3 | -12/+203 | |
| | | | | years as variable-length, and all other values as absolute length. A time + 24.hours will advance exactly 24 hours, but a time + 1.day will advance 23-25 hours, depending on the day. Ensure consistent behavior across all advancing methods. | |||||
* | Merge branch 'state_machine' | rick | 2008-06-29 | 22 | -167/+1078 | |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | Some big changes: * Added some redundant requires so active_support/inflecto can be loaded without the rest of ActiveSupport. * Disabled callbacks and validations until they are added and tested. * Converted specs back to tests, using ActiveSupport::TestCase and the new #test helper. * As an experiment, I imported Scott Barron's awesome AASM gem into ActiveModel. I added multiple state machine support and vastly improved the API (no more aasm_* prefixes). All the old tests pass. If this bothers people, I have no problems removing this and contributing the changes back to AASM. I just feel like AMo is a better spot for all these 'modelish' features. | |||||
| * | all aasm tests without activerecord moved over and passing | rick | 2008-06-28 | 5 | -59/+76 | |
| | | ||||||
| * | converted tests for more complex state transitions | rick | 2008-06-28 | 5 | -123/+142 | |
| | | ||||||
| * | add basic events and transitions. still more tests to convert | rick | 2008-06-28 | 10 | -108/+395 | |
| | | ||||||
| * | initial statemachine machine and state classes | rick | 2008-06-28 | 10 | -6/+571 | |
| | | ||||||
| * | tweak activemodel load order a bit | rick | 2008-06-27 | 7 | -30/+39 | |
| | | ||||||
| * | add special requires for ActiveSupport::Inflector so you can load it ↵ | rick | 2008-06-27 | 1 | -0/+5 | |
| | | | | | | | | individually | |||||
| * | convert specs to tests | rick | 2008-06-27 | 4 | -137/+146 | |
| | | ||||||
* | | Fix indentation and update changelogs for previous commit | gbuesing | 2008-06-29 | 3 | -2/+6 | |
| | | ||||||
* | | Added support for regexp matching of priority zones in time_zone_select ↵ | Ernie Miller | 2008-06-29 | 4 | -2/+40 | |
| | | | | | | | | [#195 state:resolved] | |||||
* | | Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] ↵ | Pratik Naik | 2008-06-29 | 2 | -11/+58 | |
| | | | | | | | | | | | | [Pascal Ehlert] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Dirty: recognize when an integer changes from zero to blank. [#433 ↵ | Tim Chater | 2008-06-27 | 2 | -1/+30 | |
| | | | | | | | | state:resolved] | |||||
* | | Add extra hash conditions tests for named_scope | Pratik Naik | 2008-06-28 | 2 | -0/+5 | |
| | | ||||||
* | | Allow conditions on multiple tables to be specified using hash. | Pratik Naik | 2008-06-28 | 3 | -9/+37 | |
| | | | | | | | | | | | | | | | | | | Examples: User.all :joins => :items, :conditions => { :age => 10, :items => { :color => 'black' } } Item.first :conditions => { :items => { :color => 'red' } } Note : Hash key in :conditions is referring to the actual table name or the alias defined in query. | |||||
* | | Fix typo in apparently-dead will_unload? method. | Jeremy Kemper | 2008-06-27 | 1 | -1/+1 | |
| | | ||||||
* | | Ensure observer test inherits from ActiveSupport::TestCase | Pratik Naik | 2008-06-27 | 1 | -1/+1 | |
| | | ||||||
* | | Warn and uses singularized ModelName if a plural ModelName is given to ↵ | Pat George | 2008-06-27 | 2 | -1/+50 | |
| | | | | | | | | | | | | script/generate. Override with --force-plural. [#333 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Allow single quote (the ' character) in the middle of URL when ↵ | Cheah Chu Yeow | 2008-06-27 | 2 | -1/+2 | |
| | | | | | | | | | | | | auto_link-ing. [#471 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | MySQL: treat integer with :limit => 11 as a display width, not byte size, ↵ | Jeremy Kemper | 2008-06-27 | 4 | -21/+29 | |
| | | | | | | | | for backward-compatibility. | |||||
* | | Make sure associated has_many/habtm objects get saved even when :validate => ↵ | Jan De Poorter | 2008-06-27 | 2 | -8/+30 | |
| | | | | | | | | | | | | false is used. [#486 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Cache sanitized conditions in reflection object for associations | Pratik Naik | 2008-06-27 | 2 | -1/+5 | |
| | | ||||||
* | | Extract owner_quoted_id so it can be overridden. [#292 state:committed] | Andre Arko | 2008-06-25 | 5 | -11/+15 | |
| | |