aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove link to rack.github.ioJon Moss2017-04-101-2/+0
| | | | | | | We mention the "resources" section of the guide in the next paragraph, and the link is listed there. IMHO we shouldn't list it twice. [ci skip]
* Small grammar fixesJon Moss2017-04-101-3/+6
| | | | [ci skip]
* Pluralize callbackJon Moss2017-04-101-1/+3
| | | | | | Users could have more than one `before_destroy` callback in their models. [ci skip]
* Merge pull request #28680 from vishalzambre/callback_doc_updateJon Moss2017-04-101-0/+2
|\ | | | | Documented issue related before_destroy with dependent: :destroy
| * [ci skip] documented issue related before_destroyvishalzambre2017-04-101-0/+2
| | | | | | | | Updated text
* | Implement `fetch_values` for HashWithIndifferentAccess (#28316)Josh Pencheon2017-04-103-0/+31
| | | | | | | | | | | | | | `fetch_values` was added to Hash in Ruby 2.3.0: https://bugs.ruby-lang.org/issues/10017 This patch adds an implemention for instances of HWAI, in line with the existing definitions of `fetch` and `values_at`.
* | exclude ORDER BY clause for exists? (#28699)Boris Slobodin2017-04-102-1/+6
| |
* | Merge pull request #28713 from kamipo/expose_queries_for_association_queriesMatthew Draper2017-04-102-48/+44
|\ \ | | | | | | Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`
| * | Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`Ryuta Kamizono2017-04-092-21/+25
| | |
| * | Avoid to handle polymorphic association for `AssociationQueryHandler`Ryuta Kamizono2017-03-282-29/+21
| | | | | | | | | | | | It should be handled by `PolymorphicArrayHandler` if polymorphic association.
* | | delegate_missing_to should fall back to superMatthew Draper2017-04-092-1/+23
| | |
* | | delegate_to_missing doesn't delegate private methodsMatthew Draper2017-04-092-1/+14
| | | | | | | | | | | | So we shouldn't claim they're there, even when asked explicitly.
* | | Merge pull request #28697 from ↵Kasper Timm Hansen2017-04-091-1/+0
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/remove_duplicated_delivery_method_definition Remove duplicated `delivery_method` definition
| * | | Remove duplicated `delivery_method` definitionyuuji.yaginuma2017-04-071-1/+0
| | | | | | | | | | | | | | | | | | | | `ActionMailer::Base.delivery_method` is already defined in https://github.com/rails/rails/blob/master/actionmailer/test/parameterized_test.rb#L13
* | | | Add text to "Upgrading to Rails 5.1"Jon Moss2017-04-081-1/+8
| | | | | | | | | | | | | | | | [ci skip]
* | | | Add scaffolding for different sections in 5.1 release notesJon Moss2017-04-081-0/+48
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #28678 from hedgesky/use_formatted_number_as_schema_versionRafael França2017-04-081-1/+9
|\ \ \ \ | | | | | | | | | | use formatted number as schema version
| * | | | use formatted number as schema versionAnton Chuchkalov2017-04-051-1/+9
| | | | |
* | | | | Merge pull request #28705 from kamipo/extract_construct_relation_for_existsRafael França2017-04-082-17/+33
|\ \ \ \ \ | | | | | | | | | | | | Extract `construct_relation_for_exists` in `FinderMethods`
| * | | | | Extract `construct_relation_for_exists` in `FinderMethods`Ryuta Kamizono2017-04-091-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | To ease to customize a relation for `exists?`.
| * | | | | More exercise `exists?` testsRyuta Kamizono2017-04-081-5/+18
| | | | | |
* | | | | | Drop the "Sanity Check" contributing stepMatthew Draper2017-04-091-10/+0
| | | | | |
* | | | | | Remove mentions and instructions for docrailsMatthew Draper2017-04-092-18/+2
|/ / / / / | | | | | | | | | | | | | | | It's been retired; all contributions now come in via PRs.
* | | | | Merge pull request #28692 from kmcphillips/masterRafael França2017-04-073-4/+49
|\ \ \ \ \ | | | | | | | | | | | | Calling fixture accessor method with no arguments returns all fixtures rather than empty array
| * | | | | Passing in no arguments to the dynamic fixture accessor method returns all ↵Kevin McPhillips2017-04-073-4/+49
| | | | | | | | | | | | | | | | | | | | | | | | fixtures, not an empty array.
* | | | | | SpacesRafael Mendonça França2017-04-071-0/+1
| | | | | |
* | | | | | More :scissors:Rafael Mendonça França2017-04-071-1/+1
| | | | | |
* | | | | | :scissors:Rafael França2017-04-071-1/+1
| | | | | |
* | | | | | Fix Guides to include #23138 [ci skip]claudiob2017-04-071-8/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A long-standing bug has been fixed in Rails 5.1 by @pixeltrix See https://github.com/rails/rails/blame/5-1-stable/actionpack/CHANGELOG.md#L52-L64 This PR updates the guides accordingly. Before: <img width="799" alt="before" src="https://cloud.githubusercontent.com/assets/10076/24809105/4ec7066c-1b73-11e7-98c6-c709c3465306.png"> After: <img width="799" alt="after" src="https://cloud.githubusercontent.com/assets/10076/24809109/50b21188-1b73-11e7-8a1a-32c3d0ed512a.png">
* | | | | Merge pull request #28670 from aledalgrande/activerecord-docs-fixRafael França2017-04-071-1/+5
|\ \ \ \ \ | | | | | | | | | | | | Fix edge guides for Active Record callbacks
| * | | | | Fix edge guides for Active Record callbacksAlessandro Dal Grande2017-04-041-1/+5
| | | | | |
* | | | | | Merge pull request #28632 from ↵Rafael França2017-04-071-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_warning_extra_states_are_no_longer_copied Fix `warning: extra states are no longer copied`
| * | | | | | Fix `warning: extra states are no longer copied`Ryuta Kamizono2017-04-011-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `messages` has `default_proc` so calling `reject` causes the warning. https://github.com/ruby/ruby/blob/v2_4_1/hash.c#L1335-L1337
* | | | | | | Merge pull request #28687 from kamipo/fix_warning_already_initialized_constantRafael França2017-04-061-1/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `warning: already initialized constant HashWithIndifferentAccessTest::HashWithIndifferentAccess`
| * | | | | | | Fix `warning: already initialized constant ↵Ryuta Kamizono2017-04-071-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HashWithIndifferentAccessTest::HashWithIndifferentAccess` Caused since #28607.
* | | | | | | | Merge pull request #28688 from kamipo/remove_duplicated_test_prefixRafael França2017-04-065-8/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove duplicated "test" prefix
| * | | | | | | | Remove duplicated "test" prefixRyuta Kamizono2017-04-075-8/+8
|/ / / / / / / /
* | | | | | | / Improve logging when Origin header doesn't matchJon Leighton2017-04-062-1/+16
| |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I came up against this while dealing with a misconfigured server. The browser was setting the Origin header to "https://example.com", but the Rails app returned "http://example.com" from request.base_url (because it was failing to detect that HTTPS was used). This caused verify_authenticity_token to fail, but the message in the log was "Can't verify CSRF token", which is confusing because the failure had nothing to do with the CSRF token sent in the request. This made it very hard to identify the issue, so hopefully this will make it more obvious for the next person.
* | | | | | | Work around all the thingsMatthew Draper2017-04-061-1/+11
| |_|_|/ / / |/| | | | |
* | | | | | Merge pull request #28673 from koic/oracle_does_not_support_index_commentAndrew White2017-04-051-5/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | Ignore AR tests of index comment when using Oracle
| * | | | | | Ignore AR tests of index comment when using OracleKoichi ITO2017-04-051-5/+9
| | |_|/ / / | |/| | | |
* | | | | | Merge pull request #28671 from y-yagi/use_appropriate_type_to_header_optionMatthew Draper2017-04-051-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Use appropriate type to `header` option
| * | | | | Use appropriate type to `header` optionyuuji.yaginuma2017-04-051-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | The `header` option checks only whether it is specified or not. https://github.com/rails/rails/blob/e8c33349bfabca28996ac74d344d69c7aaffec50/railties/lib/rails/commands/dbconsole/dbconsole_command.rb#L52
* | | | | Avoid "can't modify frozen IOError" failuresMatthew Draper2017-04-051-5/+16
| | | | | | | | | | | | | | | | | | | | https://bugs.ruby-lang.org/issues/13239
* | | | | Merge pull request #28665 from claudiob/don-t-highlight-code-in-linksClaudio B2017-04-041-4/+2
|\ \ \ \ \ | | | | | | | | | | | | Don't highlight code in anchorlink [ci skip]
| * | | | | Don't highlight code in anchorlink [ci skip]claudiob2017-04-041-4/+2
|/ / / / / | | | | | | | | | | | | | | | Minor fix to #28662
* | | | | Merge pull request #28662 from diazruy/guides-linksMatthew Draper2017-04-051-1/+4
|\ \ \ \ \ | |_|/ / / |/| | | | Downplay links in Guides headers
| * | | | Downplay links in Guides headersRuy Diaz2017-04-041-1/+4
|/ / / / | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #27832 from bdewater/backtrace-silencer-regexMatthew Draper2017-04-041-1/+1
|\ \ \ \ | | | | | | | | | | Update backtrace cleaner to use `Regexp#match?`
| * | | | Update backtrace cleaner to use `Regexp#match?`Bart de Water2017-02-131-1/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 08:17:17 +0000