| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Fixes #15705.
|
|\
| |
| | |
Remove `serialized?` from the type interface
|
| | |
|
|\ \
| | |
| | | |
Fix request's path_info when a rack app mounted at '/'.
|
| |/
| |
| |
| | |
Fixes issue #15511.
|
|\ \
| | |
| | | |
Open extension point for defining options in build_through_record
|
| | |
| | |
| | |
| | | |
This fixes #15496
|
|\ \ \
| | | |
| | | | |
Remove unused `method_missing` definition
|
| | | |
| | | |
| | | |
| | | | |
We always define attribute methods in the constructor or in `init_with`.
|
|\ \ \ \
| | | | |
| | | | | |
Add missing test cases for #assert_no_difference
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
prevent bad automatic inverse_of association
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
reflecting on wrong association
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | | |
In actionview, eliminate calls to tag that use html_safe parameter values.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is generally unnecessary, since tag handles string quoting, except in one case (utf8_enforcer_tag) where we want to specify the encoding ourselves.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Through associations should set both parent ids on join models
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
member = Member.new(club: Club.new)
member.save!
Before:
member.current_membership.club_id # => nil
After:
member.current_membership.club_id # => club's id
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | |
| | | | | | | |
ActionController::Parameters#require now accepts FalseClass values
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #15685.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Detect in-place changes on mutable AR attributes
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We have several mutable types on Active Record now. (Serialized, JSON,
HStore). We need to be able to detect if these have been modified in
place.
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|_|/ /
|/| | | | | | | |
Remove unused column types override
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|_|_|/
|/| | | | | | | |
Reorder test which does not represent real world usage
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We don't generally modify our classes at runtime like this. Let's create
the instance after the class is created. Original commit doesn't imply
that this was intentional behavior.
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
variables [ci skip]
Thanks to @matthewd for the excellent feedback! :heart:
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
skip]"
This partially reverts commit 1a203d5e07f639332880099fab610b886b1742fc.
Reason: It was committed by accident
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Rails 4.2 release notes [ci skip]
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Point to future 4-2-stable branch for detailed changes. [ci skip]
Sync Active Support changelogs with release notes [ci skip]
4.2 Release Notes is a work in progress [ci skip]
Assorted fixes for AS release notes [ci skip]
* `Hash#deep_transform_keys` has already been backported
* Mentioning `ActiveSupport::SafeBuffer#prepend` in the "Deprecations" section would be enough
* Fix syntax in `Kernel#concern` example
Sync AS release notes with the latest commits [ci skip]
Synced 4.2 release notes with commits in railties [ci skip]
Sync AP Deprecations and Notable changes from CHANGELOG [ci skip]
Removed 4.2 release notes from the index [ci skip]
This deprecation was reverted in 489a8f2 [ci skip]
Synced Active Record changelogs for 4.2 release notes [ci skip]
Synced Active Model changelog with the release notes [ci skip]
Added cc26b6b as a 'Removal' item in AP release notes [ci skip]
Use 'character' instead of 'symbol' to avoid confusion [ci skip]
Edit pass on 4.2 release notes [ci skip]
:memo: :lipstick: Use `.xyz` and `#xyz` appropiately [ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Ensure we always define attribute methods
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Introduce an Attribute object to handle the type casting dance
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
There's a lot more that can be moved to these, but this felt like a good
place to introduce the object. Plans are:
- Remove all knowledge of type casting from the columns, beyond a
reference to the cast_type
- Move type_cast_for_database to these objects
- Potentially make them mutable, introduce a state machine, and have
dirty checking handled here as well
- Move `attribute`, `decorate_attribute`, and anything else that
modifies types to mess with this object, not the columns hash
- Introduce a collection object to manage these, reduce allocations, and
not require serializing the types
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- image_tag is an instance method
- explain possible results when asset pipeline is used
|
| | | | | | | | |
|
| |_|_|_|/ / /
|/| | | | | |
| | | | | | |
| | | | | | | |
Related to a discussion on #15508
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Clarify ActiveModel::Model docs
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
ActiveModel attributes initialized with String return String values
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This was also removed from #15542
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
These were removed from #15542 unfortunately :(
|
| |_|_|_|/ / /
|/| | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Set flash in test session when necessary.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`to_session_value` returns nil when empty.
|
|\ \ \ \ \ \ \ \
| |_|_|_|/ / / /
|/| | | | | | | |
Fix parsed token value with header `Authorization token=`.
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
PG arrays should type cast user input
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We guarantee that `model.value` does not change after
`model.save && model.reload`. This requires type casting user input for
non-string types.
|