| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[Rdoc] Make clear that we are sending an AR object [ci skip]
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
has_many :through with dynamic condition merging
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
with dynamic conditions.
Fixes #16128
This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
so it's present from 4.1.2-rc1 and after.
https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
merges any relation scopes passed as proc objects to the relation,
but does *not* take into account the arity of the lambda.
To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix typo in rdoc [ci skip]
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Deprecated ActionMailer .deliver and updated ActionMailer / ActiveJob docs/guide
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Require ActiveJob in case a skip_xxx option is given
|
| | | |_|_|_|_|_|/
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
Change position of require active_job
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
[ci skip] Format pass of Active Job Basics guide.
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Zero has one digit, but Math.log10(0) returns -Infinity. The method
needs to special-case zero.
The patch adds a regression test that is not clearly related to the
underlying issue because digit_count is private and has no coverage.
Gray area.
This bug was uncovered by 60062cf.
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
don't log errors when all is fine
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Move as/test_test to as/test_case_test
|
| | | | | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
Revert "Do not gsub non ASCII characters in header anchor.".
|
| |/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This reverts commit 699babe.
Also change the upgrading_ruby_on_rails link back to original in 4_2_release_notes.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Updated the deprecation warnings to 5.0
|
| | | |_|_|/ / / /
| |/| | | | | | |
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove end-of-line spacing in development.rb, production.rb
|
| |/ / / / / / / / |
|
| |/ / / / / / / |
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Also moved comment for removal above `unless()` to not confuse RDoc with
the documentation for this method.
|
| | | | | | | |
|
| | |/ / / /
|/| | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Remove global helpers from the ActionMailer test suite.
|
| |/ / / / / |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Add `set_delivery_method` and `restore_delivery_method` to `ActionMailer::TestCase.
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`ActionMailer::TestCase`.
This way these methods are available outside the ActionMailer test suite, but
they are still duplicated inside `test/abstract_unit` for test cases that don't
inherit from the `ActionMailer::TestCase` class.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A combination of two commits led into these failures:
* The addition of a new active_record config in
24bb8347b6ff0da90059314d9aece7a2c94a272c
* The revert of the config to use config.x as options holder in
43073b393d234acd094ac7c220163f4e419d11f5
These tests remove activerecord from the load path, however the
configuration is still in the application file, and they blow up.
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
CSRF token mask from breach-mitigation-rails gem
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This merges in the code from the breach-mitigation-rails gem that masks
authenticity tokens on each request by XORing them with a random set of
bytes. The masking is used to make it impossible for an attacker to
steal a CSRF token from an SSL session by using techniques like the
BREACH attack.
The patch is pretty simple - I've copied over the [relevant
code](https://github.com/meldium/breach-mitigation-rails/blob/master/lib/breach_mitigation/masking_secrets.rb)
and updated the tests to pass, mostly by adjusting stubs and mocks.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
[Godfrey Chan, Genadi Samokovarov]
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously setting simple values to the config.x object resulted in the
following:
config.x.super_debugger = true
config.x.super_debugger #=> {}
Which was against the examples showed in the changelog/release notes.
|
