Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Convert unless/else into if/else. | thedarkone | 2010-09-27 | 1 | -4/+4 | |
| | | | | ||||||
| * | | | Performance: refactor convert_options_to_data_attributes. | thedarkone | 2010-09-27 | 1 | -10/+14 | |
| | | | | ||||||
| * | | | Remove dead code. | thedarkone | 2010-09-27 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | Clean up url_for. | thedarkone | 2010-09-27 | 1 | -3/+1 | |
| | | | | ||||||
| * | | | Hash#empty? is faster than Enumerable#any? when used on a Hash. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Do a single string interpolation. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Simple .empty? test will do fine here (rails_asset_id returns nice strings). | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | options[:action] is very likely to be nil. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Make assert_valid_keys slightly faster. | thedarkone | 2010-09-27 | 2 | -5/+7 | |
| | | | | ||||||
| * | | | No need for an extra wrapper array. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Cache 2 of Request's commonly called methods. | thedarkone | 2010-09-27 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | Cache url_options on a per-request basis. | thedarkone | 2010-09-27 | 1 | -9/+11 | |
| | | | | ||||||
| * | | | No need to create a separate lambda for each call. | thedarkone | 2010-09-27 | 1 | -15/+14 | |
| | | | | ||||||
| * | | | Make asset extension rewriting faster. | thedarkone | 2010-09-27 | 1 | -5/+11 | |
| | | | | ||||||
| * | | | Optimize relative_url_root rewriting code. | thedarkone | 2010-09-27 | 1 | -3/+5 | |
| | | | | ||||||
| * | | | Use native attr_* macros for performance reasons. | thedarkone | 2010-09-27 | 1 | -6/+13 | |
| | | | | ||||||
| * | | | Creating singleton class for every object whenever the instance-level ↵ | thedarkone | 2010-09-27 | 1 | -1/+21 | |
| | | | | | | | | | | | | | | | | accessor is used quite is expensive. | |||||
| * | | | Try to use Hash's native #[] for speed. | thedarkone | 2010-09-27 | 2 | -2/+8 | |
| | | | | ||||||
| * | | | Make InheritableOptions's constructor more flexible. | thedarkone | 2010-09-27 | 2 | -3/+7 | |
| | | | | ||||||
| * | | | Compile ActionController::Base.config's methods to avoid method_missing ↵ | thedarkone | 2010-09-27 | 5 | -4/+55 | |
| |/ / | | | | | | | | | | overhead. | |||||
* | / | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 | |
| |/ |/| | | | | | | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | |||||
* | | depending on arel 2.0.0 | Aaron Patterson | 2010-09-27 | 1 | -1/+1 | |
|/ | ||||||
* | third parameter is not used | Aaron Patterson | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | db:structure:dump should list current Rails.env adapter in errors, not ↵ | Nic Benders | 2010-09-26 | 1 | -1/+1 | |
| | | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Fix remove_index issue when provided :name is a symbol | Tim Connor | 2010-09-26 | 2 | -2/+2 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Fix the precedence issue here | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | Not need to do this double ternary | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | port is appended twice to HTTP_HOST when host already has the port | Santiago Pastorino | 2010-09-26 | 1 | -3/+3 | |
| | ||||||
* | Bump up some deps | Santiago Pastorino | 2010-09-26 | 4 | -5/+5 | |
| | ||||||
* | Partial revert of #d650b71 'Remove deprecated stuff in ActionController' | Carlos Antonio da Silva | 2010-09-26 | 4 | -0/+11 | |
| | | | | | This brings back the deprecated modules from ActionController, because they didn't have any deprecation warning. | |||||
* | We don't need to check if the format exists to generate the url, it already ↵ | Carlos Antonio da Silva | 2010-09-26 | 1 | -8/+7 | |
| | | | | does it internally | |||||
* | More cleanup on form helpers | Carlos Antonio da Silva | 2010-09-26 | 1 | -11/+12 | |
| | ||||||
* | Remove last tests with deprecated form_for and cleanup form_for helper | Carlos Antonio da Silva | 2010-09-26 | 2 | -67/+51 | |
| | | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before. | |||||
* | Select tags with array options are deprecated, removing | Carlos Antonio da Silva | 2010-09-26 | 2 | -10/+0 | |
| | ||||||
* | Refactor form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -21/+11 | |
| | ||||||
* | Review most of the form_for deprecated tests, missing tests with index like [] | Carlos Antonio da Silva | 2010-09-26 | 2 | -405/+322 | |
| | ||||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 29 | -58/+47 | |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | |||||
* | There is no need to open AC::Base three times to setup tests. | Carlos Antonio da Silva | 2010-09-26 | 1 | -27/+20 | |
| | ||||||
* | There is no DeprecatedBlockHelpers in AV, so remove it | Carlos Antonio da Silva | 2010-09-26 | 1 | -1/+0 | |
| | ||||||
* | Fix active_resource assertions. | José Valim | 2010-09-25 | 1 | -2/+2 | |
| | ||||||
* | Fix app and actions generators tests | Piotr Sarnacki | 2010-09-25 | 2 | -0/+9 | |
| | | | | | | | Normally Rails.application is an instance, but for those tests Rails.application needs to be class. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Refactor a few methods connected with namespacing in ↵ | Piotr Sarnacki | 2010-09-25 | 1 | -8/+9 | |
| | | | | | | Rails::Generators::NamedBase Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add namespacing to mailer generator | Piotr Sarnacki | 2010-09-25 | 3 | -0/+56 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add namespacing for observer generator | Piotr Sarnacki | 2010-09-25 | 3 | -0/+26 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add namespace for test_unit generators | Piotr Sarnacki | 2010-09-25 | 4 | -3/+9 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Allow per Resource format settings | Jacques Crocker | 2010-09-25 | 5 | -17/+25 | |
| | | | | | | | | | | Previously, ActiveResource was using the connection level formatter for get requests. This made it impossible to use custom formatters per resource. Additionally this commit makes the Connection request methods more consistent. It always returns a Response. The base will then decode it each the response using its format setting. Merging this commit will allow users to add custom formatters on a per Resource basis. This enables handling pagination responses from the server side, a very common use case that was previously impossible without monkeypatching XmlFormat. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Allow ActiveResource to work with non-generated ids [#5660 state:resolved] | Jacques Crocker | 2010-09-25 | 5 | -5/+80 | |
| | | | | | | This commit updates new? so that it knows whether or not the record was actually new or not, and doesn't rely solely on the presence of id. This enables the ability to set a custom primary_key that is not autogenerated by the server. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix 'warning: method redefined' [#5551 state:resolved] | Krekoten' Marjan | 2010-09-25 | 1 | -4/+4 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix logging when cache key contains % sign [#5570 state:resolved] | Krekoten' Marjan | 2010-09-25 | 2 | -1/+17 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Remove duplicate helper method | Krekoten' Marjan | 2010-09-25 | 1 | -3/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |